[GitHub] [geode] gesterzhou opened pull request #3040: GEODE-6143: remove PowerMock from TypeUtilsJUnitTest

["gesterzhou (GitHub)" <gi...@apache.org>]

Thank you for submitting a contribution to Apache Geode.

@boglesby @jhuynh1 

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/3040 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] gesterzhou closed pull request #3040: GEODE-6143: remove PowerMock from TypeUtilsJUnitTest

["gesterzhou (GitHub)" <gi...@apache.org>]

[ pull request closed by gesterzhou ]

[ Full content available at: https://github.com/apache/geode/pull/3040 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jhuynh1 commented on pull request #3040: GEODE-6143: remove PowerMock from TypeUtilsJUnitTest

["jhuynh1 (GitHub)" <gi...@apache.org>]

I think this and the other modified tests can be renamed now since they no longer assert that specific comparators are being used.  Instead it's just asserting that we can make comparisons against booleans, different numeric values and date/time objects

[ Full content available at: https://github.com/apache/geode/pull/3040 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] gesterzhou commented on issue #3040: GEODE-6143: remove PowerMock from TypeUtilsJUnitTest

["gesterzhou (GitHub)" <gi...@apache.org>]

@aditya87
The coverage is maintained. I carefully considered that. 

[ Full content available at: https://github.com/apache/geode/pull/3040 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org