[GitHub] [cassandra] josh-mckenzie commented on a change in pull request #1432: CASSANDRA-17332 Add support for vnodes in jvm-dtest

[GitBox <gi...@apache.org>]

josh-mckenzie commented on a change in pull request #1432:
URL: https://github.com/apache/cassandra/pull/1432#discussion_r833446298



##########
File path: test/distributed/org/apache/cassandra/distributed/impl/AbstractCluster.java
##########
@@ -200,6 +200,32 @@ public B withShutdownExecutor(ShutdownExecutor shutdownExecutor)
             this.shutdownExecutor = shutdownExecutor;
             return (B) this;
         }
+
+        @Override
+        public C createWithoutStarting() throws IOException
+        {
+            // if running as vnode but test sets disallowVNodes(), then skip the test
+            // AbstractCluster.createInstanceConfig has similar logic, but handles the cases where the test
+            // attempts to control tokens via config
+            Assume.assumeFalse("vnode is not supported", !isAllowVnodes() && isVnode());

Review comment:
       nit: is "supported" the right word here? It's about whether it's configured or not right?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org