You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2024/03/18 09:29:09 UTC
[PR] HDDS-10545. Repeated tests stop if fork does not return [ozone]
adoroszlai opened a new pull request, #6393:
URL: https://github.com/apache/ozone/pull/6393
## What changes were proposed in this pull request?
HDDS-10080 added a sanity check in `junit.sh` to stop iterations if no tests were run. However, it is also triggered if tests are run, but do not complete "normally", e.g. Surefire fork times out or crashes.
Example (each split stopped right after the first crash): https://github.com/adoroszlai/ozone/actions/runs/8191098889/job/22400265006#step:6:11998
This patch slightly tweaks the pattern.
https://issues.apache.org/jira/browse/HDDS-10545
## How was this patch tested?
Valid test class, iterations continue:
```
$ ITERATIONS=3 OZONE_REPO_CACHED=true \
./hadoop-ozone/dev-support/checks/junit.sh \
-am -pl :hdds-config -Dtest='TestConfigFileAppender'
...
$ cat target/unit/summary.txt
Iteration 1 exit code: 0
Iteration 2 exit code: 0
Iteration 3 exit code: 0
```
Non-existent class, iterations stop:
```
$ ITERATIONS=3 OZONE_REPO_CACHED=true \
./hadoop-ozone/dev-support/checks/junit.sh \
-am -pl :hdds-config -Dtest='NoSuchTest'
...
[INFO] BUILD SUCCESS
...
Iteration 1 exit code: 1
$ cat target/unit/iteration1/summary.txt
No tests were run
```
Non-existent method in existing class, iterations stop:
```
$ ITERATIONS=3 OZONE_REPO_CACHED=true \
./hadoop-ozone/dev-support/checks/junit.sh \
-am -pl :hdds-config -Dtest='TestConfigFileAppender#noSuchTest'
...
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
...
[INFO] BUILD SUCCESS
...
Iteration 1 exit code: 1
$ cat target/unit/iteration1/summary.txt
No tests were run
```
Abstract class, iterations stop:
```
$ ITERATIONS=3 OZONE_REPO_CACHED=true \
./hadoop-ozone/dev-support/checks/junit.sh \
-am -pl :ozone-integration-test -Dtest='AbstractContractGetFileStatusTest'
...
[INFO] BUILD SUCCESS
...
Iteration 1 exit code: 1
$ cat target/unit/iteration1/summary.txt
No tests were run
```
Regular CI:
https://github.com/adoroszlai/ozone/actions/runs/8322917313
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10545. Repeated tests stop if fork does not return [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #6393:
URL: https://github.com/apache/ozone/pull/6393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10545. Repeated tests stop if fork does not return [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #6393:
URL: https://github.com/apache/ozone/pull/6393#issuecomment-2068849808
Thanks @sadanand48 for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10545. Repeated tests stop if fork does not return [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #6393:
URL: https://github.com/apache/ozone/pull/6393#issuecomment-2067968985
@sadanand48 please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org