You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bloodhound.apache.org by Thimal Kempitiya <tk...@gmail.com> on 2014/12/15 19:26:31 UTC
Adding the project name to installation process
Hi devs,
In current installation process we have not ask the project name, but we
can add it using --project option. Same goes to the environments directory.
But it may be good to add those two parameters to the installation process.
(I have discuss this with Ryan and Gray)
I have created a patch to add project name and environments directory to
the bloodhound installation process. please give your feedback about this
change and my patch.
--
*Thimal Kempitiya <http://www.facebook.com/thimalk> UndergraduateDepartment
of Computer Science and Engineering University of Moratuwa.*
Re: Adding the project name to installation process
Posted by Gary Martin <ga...@wandisco.com>.
Excellent. Thanks for that!
On 6 January 2015 at 10:18, Thimal Kempitiya <tk...@gmail.com> wrote:
> Thanks Gray I commit the changes to the trunk
>
> On Tue, Jan 6, 2015 at 3:08 PM, Gary Martin <ga...@wandisco.com>
> wrote:
>
> > On 24 December 2014 at 03:40, Ryan Ollos <ry...@gmail.com> wrote:
> >
> > > On Tue, Dec 23, 2014 at 11:55 AM, Gary Martin <
> gary.martin@wandisco.com>
> > > wrote:
> > >
> > > > Hi Thimal,
> > > >
> > > > Sorry I left it so long. I was hoping someone else might want to say
> > > > something about your patch. Personally I am happy enough with it for
> it
> > > to
> > > > be committed. It might be worth cleaning up the wording and if I were
> > > being
> > > > more picky I would also point out that there are some deviations from
> > > PEP8
> > > > in the patch. Obviously the script as a whole suffers from some PEP8
> > > > problems which I wouldn't expect you to solve with your proposed
> > changes.
> > > >
> > > > If there are no objections I'd suggest that Thimal commits the
> changes
> > to
> > > > trunk himself and we can fix the wording later.
> > > >
> > >
> > > Sounds good to me.
> > >
> >
> >
> > Thimal,
> >
> > As nobody has raised any objections, you should commit the change to
> trunk.
> > Sorry for the delay.
> >
> > Cheers,
> > Gary
> >
>
>
>
> --
>
>
>
>
> *Thimal Kempitiya <http://www.facebook.com/thimalk>
> UndergraduateDepartment
> of Computer Science and Engineering University of Moratuwa.*
>
Re: Adding the project name to installation process
Posted by Thimal Kempitiya <tk...@gmail.com>.
Thanks Gray I commit the changes to the trunk
On Tue, Jan 6, 2015 at 3:08 PM, Gary Martin <ga...@wandisco.com>
wrote:
> On 24 December 2014 at 03:40, Ryan Ollos <ry...@gmail.com> wrote:
>
> > On Tue, Dec 23, 2014 at 11:55 AM, Gary Martin <ga...@wandisco.com>
> > wrote:
> >
> > > Hi Thimal,
> > >
> > > Sorry I left it so long. I was hoping someone else might want to say
> > > something about your patch. Personally I am happy enough with it for it
> > to
> > > be committed. It might be worth cleaning up the wording and if I were
> > being
> > > more picky I would also point out that there are some deviations from
> > PEP8
> > > in the patch. Obviously the script as a whole suffers from some PEP8
> > > problems which I wouldn't expect you to solve with your proposed
> changes.
> > >
> > > If there are no objections I'd suggest that Thimal commits the changes
> to
> > > trunk himself and we can fix the wording later.
> > >
> >
> > Sounds good to me.
> >
>
>
> Thimal,
>
> As nobody has raised any objections, you should commit the change to trunk.
> Sorry for the delay.
>
> Cheers,
> Gary
>
--
*Thimal Kempitiya <http://www.facebook.com/thimalk> UndergraduateDepartment
of Computer Science and Engineering University of Moratuwa.*
Re: Adding the project name to installation process
Posted by Gary Martin <ga...@wandisco.com>.
On 24 December 2014 at 03:40, Ryan Ollos <ry...@gmail.com> wrote:
> On Tue, Dec 23, 2014 at 11:55 AM, Gary Martin <ga...@wandisco.com>
> wrote:
>
> > Hi Thimal,
> >
> > Sorry I left it so long. I was hoping someone else might want to say
> > something about your patch. Personally I am happy enough with it for it
> to
> > be committed. It might be worth cleaning up the wording and if I were
> being
> > more picky I would also point out that there are some deviations from
> PEP8
> > in the patch. Obviously the script as a whole suffers from some PEP8
> > problems which I wouldn't expect you to solve with your proposed changes.
> >
> > If there are no objections I'd suggest that Thimal commits the changes to
> > trunk himself and we can fix the wording later.
> >
>
> Sounds good to me.
>
Thimal,
As nobody has raised any objections, you should commit the change to trunk.
Sorry for the delay.
Cheers,
Gary
Re: Adding the project name to installation process
Posted by Ryan Ollos <ry...@gmail.com>.
On Tue, Dec 23, 2014 at 11:55 AM, Gary Martin <ga...@wandisco.com>
wrote:
> Hi Thimal,
>
> Sorry I left it so long. I was hoping someone else might want to say
> something about your patch. Personally I am happy enough with it for it to
> be committed. It might be worth cleaning up the wording and if I were being
> more picky I would also point out that there are some deviations from PEP8
> in the patch. Obviously the script as a whole suffers from some PEP8
> problems which I wouldn't expect you to solve with your proposed changes.
>
> If there are no objections I'd suggest that Thimal commits the changes to
> trunk himself and we can fix the wording later.
>
Sounds good to me.
Re: Adding the project name to installation process
Posted by Gary Martin <ga...@wandisco.com>.
Hi Thimal,
Sorry I left it so long. I was hoping someone else might want to say
something about your patch. Personally I am happy enough with it for it
to be committed. It might be worth cleaning up the wording and if I were
being more picky I would also point out that there are some deviations
from PEP8 in the patch. Obviously the script as a whole suffers from
some PEP8 problems which I wouldn't expect you to solve with your
proposed changes.
If there are no objections I'd suggest that Thimal commits the changes
to trunk himself and we can fix the wording later.
Cheers,
Gary
On 15/12/14 19:48, Thimal Kempitiya wrote:
> Thanks Gray and sorry for the inconvenience caused
>
> I have used the ASF pastebin and here is the link for the patch.
> https://paste.apache.org/5JfA
>
> On Tue, Dec 16, 2014 at 1:10 AM, Gary Martin <ga...@wandisco.com>
> wrote:
>> On 15/12/14 18:26, Thimal Kempitiya wrote:
>>
>>> Hi devs,
>>>
>>> In current installation process we have not ask the project name, but we
>>> can add it using --project option. Same goes to the environments directory.
>>> But it may be good to add those two parameters to the installation process.
>>> (I have discuss this with Ryan and Gray)
>>> I have created a patch to add project name and environments directory to
>>> the bloodhound installation process. please give your feedback about this
>>> change and my patch.
>>> --
>>>
>>> /Thimal Kempitiya <http://www.facebook.com/thimalk>
>>> Undergraduate
>>> Department of Computer Science and Engineering
>>> University of Moratuwa./
>>>
>> Hi Thimal,
>>
>> Thanks for that. It seems that the attachment get lost here. There are a
>> few choices for how to get your patch viewable here. You can either:
>>
>> * paste the patch directly in the email, or
>> * raise a ticket and attach it there, or
>> * use the ASF pastebin: https://paste.apache.org/
>>
>> I imagine that we will ask you to commit the change directly for yourself
>> assuming that all is well, but a pre-commit review from the other devs
>> shouldn't hurt as long as we get to it in a timely fashion!
>>
>> Cheers,
>> Gary
>>
>
Re: Adding the project name to installation process
Posted by Thimal Kempitiya <tk...@gmail.com>.
Thanks Gray and sorry for the inconvenience caused
I have used the ASF pastebin and here is the link for the patch.
https://paste.apache.org/5JfA
On Tue, Dec 16, 2014 at 1:10 AM, Gary Martin <ga...@wandisco.com>
wrote:
>
> On 15/12/14 18:26, Thimal Kempitiya wrote:
>
>>
>> Hi devs,
>>
>> In current installation process we have not ask the project name, but we
>> can add it using --project option. Same goes to the environments directory.
>> But it may be good to add those two parameters to the installation process.
>> (I have discuss this with Ryan and Gray)
>> I have created a patch to add project name and environments directory to
>> the bloodhound installation process. please give your feedback about this
>> change and my patch.
>> --
>>
>> /Thimal Kempitiya <http://www.facebook.com/thimalk>
>> Undergraduate
>> Department of Computer Science and Engineering
>> University of Moratuwa./
>>
>
> Hi Thimal,
>
> Thanks for that. It seems that the attachment get lost here. There are a
> few choices for how to get your patch viewable here. You can either:
>
> * paste the patch directly in the email, or
> * raise a ticket and attach it there, or
> * use the ASF pastebin: https://paste.apache.org/
>
> I imagine that we will ask you to commit the change directly for yourself
> assuming that all is well, but a pre-commit review from the other devs
> shouldn't hurt as long as we get to it in a timely fashion!
>
> Cheers,
> Gary
>
--
*Thimal Kempitiya <http://www.facebook.com/thimalk> UndergraduateDepartment
of Computer Science and Engineering University of Moratuwa.*
Re: Adding the project name to installation process
Posted by Gary Martin <ga...@wandisco.com>.
On 15/12/14 18:26, Thimal Kempitiya wrote:
>
> Hi devs,
>
> In current installation process we have not ask the project name, but
> we can add it using --project option. Same goes to the environments
> directory. But it may be good to add those two parameters to the
> installation process. (I have discuss this with Ryan and Gray)
> I have created a patch to add project name and environments directory
> to the bloodhound installation process. please give your feedback
> about this change and my patch.
> --
>
> /Thimal Kempitiya <http://www.facebook.com/thimalk>
> Undergraduate
> Department of Computer Science and Engineering
> University of Moratuwa./
Hi Thimal,
Thanks for that. It seems that the attachment get lost here. There are a
few choices for how to get your patch viewable here. You can either:
* paste the patch directly in the email, or
* raise a ticket and attach it there, or
* use the ASF pastebin: https://paste.apache.org/
I imagine that we will ask you to commit the change directly for
yourself assuming that all is well, but a pre-commit review from the
other devs shouldn't hurt as long as we get to it in a timely fashion!
Cheers,
Gary