You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@subversion.apache.org by Branko Čibej <br...@xbc.nu> on 2001/09/08 10:23:50 UTC

Why is the client condensing the targets twice?

While I was tracing the / vs. \ problems during commit on Win32, I 
noticed something strange:

    * svn_cl__commit does:
          * some argument processing
          * get current working directory
          * svn_path_condense_targets()
          * create commit editor
          * svn_client_commit()
    * svn_client_commit does:
          * svn_path_condense_targets()

This is not particularly important, but I wonder why 
svn_path_condense_targets gets called twice. As I understand it, 
svn_cl__commit has to do it so that it can pass the correct base path to 
the commit editor. But, if all clients have to do that, 
svn_client_commit should just require that its target list is 
pre-condensed, so to speak.

Hm. Could svn_client_commit call condense_targets and modify the editor? 
Then svn_cl__commit wouldn't have to do that.


-- 
Brane ďż˝ibej   <br...@xbc.nu>            http://www.xbc.nu/brane/



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org