[GitHub] [spark] amaliujia commented on a diff in pull request #38914: [SPARK-41381][CONNECT][PYTHON] Implement `count_distinct` and `sum_distinct` functions

[GitBox <gi...@apache.org>]

amaliujia commented on code in PR #38914:
URL: https://github.com/apache/spark/pull/38914#discussion_r1039886159


##########
connector/connect/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -141,11 +141,14 @@ message Expression {
     // (Optional) Function arguments. Empty arguments are allowed.
     repeated Expression arguments = 2;
 
+    // (Required) Indicate if this function should be applied on distinct values.
+    bool is_distinct = 3;

Review Comment:
   Do we need a negative test case here where for example if I call `substr` but with this `is_distinct=true`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org