You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/07/17 10:06:57 UTC
[GitHub] [dubbo-go-samples] cjphaha opened a new pull request #173: Fix: delete useless & wrong xml files in .run folder
cjphaha opened a new pull request #173:
URL: https://github.com/apache/dubbo-go-samples/pull/173
修复 https://github.com/apache/dubbo-go-samples/pull/129 中的问题
* 修改一些错误的目录
* 删除无用 / 重复的 xml文件
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] cjphaha commented on pull request #173: Fix: delete useless & wrong xml files in .run folder
Posted by GitBox <gi...@apache.org>.
cjphaha commented on pull request #173:
URL: https://github.com/apache/dubbo-go-samples/pull/173#issuecomment-881895858
> 
> Pls make sure there is no unrunable samples
fixed it
<img src="https://user-images.githubusercontent.com/23278645/126037601-049c62b8-5808-4884-9bac-42287454ddf5.png" width="30%" height="30%">
<img src="https://user-images.githubusercontent.com/23278645/126037677-5e893831-1185-49cc-a2a9-dd943a7fb9ac.png" width="30%" height="30%">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] cjphaha commented on a change in pull request #173: Fix: delete useless & wrong xml files in .run folder
Posted by GitBox <gi...@apache.org>.
cjphaha commented on a change in pull request #173:
URL: https://github.com/apache/dubbo-go-samples/pull/173#discussion_r671687078
##########
File path: .run/triple/triple-server.run.xml
##########
@@ -8,7 +8,7 @@
</envs>
<kind value="PACKAGE" />
Review comment:
好的，我再核对一下，thx👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] LaurenceLiZhixin commented on pull request #173: Fix: delete useless & wrong xml files in .run folder
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on pull request #173:
URL: https://github.com/apache/dubbo-go-samples/pull/173#issuecomment-881880756
Pls make sure there is no unrunable samples
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] AlexStocks merged pull request #173: Fix: delete useless & wrong xml files in .run folder
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #173:
URL: https://github.com/apache/dubbo-go-samples/pull/173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] LaurenceLiZhixin commented on a change in pull request #173: Fix: delete useless & wrong xml files in .run folder
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #173:
URL: https://github.com/apache/dubbo-go-samples/pull/173#discussion_r671671706
##########
File path: .run/triple/triple-server.run.xml
##########
@@ -8,7 +8,7 @@
</envs>
<kind value="PACKAGE" />
Review comment:
package 下面却指向一个server.go
你在goland上面打开，看看哪些是爆红的，爆红的都是跑不了的例子。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] LaurenceLiZhixin commented on pull request #173: Fix: delete useless & wrong xml files in .run folder
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on pull request #173:
URL: https://github.com/apache/dubbo-go-samples/pull/173#issuecomment-881900283
merge 一下 3.0 分支，重新提交下就好了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org