You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Miklos Gergely <mg...@hortonworks.com> on 2017/04/27 22:36:06 UTC
Review Request 58822: Add Log Level Filter to the Log Search config
API
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58822/
-----------------------------------------------------------
Review request for Ambari, Oliver Szabo and Robert Nettleton.
Bugs: AMBARI-20881
https://issues.apache.org/jira/browse/AMBARI-20881
Repository: ambari
Description
-------
Log Level Filters should be handled by the config API too
Also Log Level Filters should be per cluster, not only one for the Log Search Server. This means that some UI modifications are also necessary in order to query/persist changes of the log level filters for a specific cluster only.
Diffs
-----
ambari-logsearch/ambari-logsearch-config-api/pom.xml e9abed0
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/InputConfigMonitor.java df26920
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogLevelFilterMonitor.java PRE-CREATION
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfig.java 0bb0b78
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/loglevelfilter/LogLevelFilter.java PRE-CREATION
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/loglevelfilter/LogLevelFilterMap.java PRE-CREATION
ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass1.java 969eb30
ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass2.java 664ecc9
ambari-logsearch/ambari-logsearch-config-zookeeper/pom.xml 4ed8eba
ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/LogSearchConfigZK.java 738fde2
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java 074fedb
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputConfigUploader.java b70fbd1
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FilterLogData.java a05a916
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigFetcher.java 12c744c
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandler.java 0ece637
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilter.java 60c8ae8
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilterWrapper.java 9199cd3
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/FilterLogData.java PRE-CREATION
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/LogLevelFilterHandler.java PRE-CREATION
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java 135fb32
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/LogFeederUtil.java bb2f0a9
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandlerTest.java 266108f
ambari-logsearch/ambari-logsearch-logfeeder/src/test/resources/logfeeder.properties 59020cc
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/LogfeederFilterConfigurer.java c2d27f9
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java 8fb27a7
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java 00adb67
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ShipperConfigManager.java c0c1167
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/UserConfigManager.java a60fc5c
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LogFeederDataMap.java cc7d53d
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LogfeederFilterData.java e0f8013
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/ShipperConfigResource.java 47e6ba2
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/UserConfigResource.java 41dda05
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java dbbbf20
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-properties.xml 1ff8ad3
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml a18c5c5
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json 0adcbde
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java 607a94e
Diff: https://reviews.apache.org/r/58822/diff/1/
Testing
-------
Tested on local cluster, using Postman to test PUT/POST endpoints
Thanks,
Miklos Gergely
Re: Review Request 58822: Add Log Level Filter to the Log Search
config API
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58822/#review173314
-----------------------------------------------------------
ambari-logsearch/ambari-logsearch-config-api/pom.xml
Lines 35 (patched)
<https://reviews.apache.org/r/58822/#comment246333>
remove swagger and/or jakson dependencies in order to keep the api clean
- Oliver Szabo
On April 28, 2017, 11:31 a.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58822/
> -----------------------------------------------------------
>
> (Updated April 28, 2017, 11:31 a.m.)
>
>
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
>
>
> Bugs: AMBARI-20881
> https://issues.apache.org/jira/browse/AMBARI-20881
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Log Level Filters should be handled by the config API too
>
> Also Log Level Filters should be per cluster, not only one for the Log Search Server. This means that some UI modifications are also necessary in order to query/persist changes of the log level filters for a specific cluster only.
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-config-api/pom.xml e9abed0
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/InputConfigMonitor.java df26920
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogLevelFilterMonitor.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfig.java 0bb0b78
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/loglevelfilter/LogLevelFilter.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/loglevelfilter/LogLevelFilterMap.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass1.java 969eb30
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass2.java 664ecc9
> ambari-logsearch/ambari-logsearch-config-zookeeper/pom.xml 4ed8eba
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/LogSearchConfigZK.java 738fde2
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java 074fedb
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputConfigUploader.java b70fbd1
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FilterLogData.java a05a916
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigFetcher.java 12c744c
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandler.java 0ece637
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilter.java 60c8ae8
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilterWrapper.java 9199cd3
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/FilterLogData.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/LogLevelFilterHandler.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java 135fb32
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/LogFeederUtil.java bb2f0a9
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandlerTest.java 266108f
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/resources/logfeeder.properties 59020cc
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/LogfeederFilterConfigurer.java c2d27f9
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java 8fb27a7
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java 00adb67
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ShipperConfigManager.java c0c1167
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/UserConfigManager.java a60fc5c
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LogFeederDataMap.java cc7d53d
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LogfeederFilterData.java e0f8013
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/ShipperConfigResource.java 47e6ba2
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/UserConfigResource.java 41dda05
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java dbbbf20
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-properties.xml 1ff8ad3
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml a18c5c5
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json 0adcbde
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java 607a94e
>
>
> Diff: https://reviews.apache.org/r/58822/diff/2/
>
>
> Testing
> -------
>
> Tested on local cluster, using Postman to test PUT/POST endpoints
>
>
> Thanks,
>
> Miklos Gergely
>
>
Re: Review Request 58822: Add Log Level Filter to the Log Search
config API
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58822/#review173335
-----------------------------------------------------------
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/ShipperConfigResource.java
Line 89 (original), 89 (patched)
<https://reviews.apache.org/r/58822/#comment246355>
this path is too long and contains more nouns
- Oliver Szabo
On April 28, 2017, 4:17 p.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58822/
> -----------------------------------------------------------
>
> (Updated April 28, 2017, 4:17 p.m.)
>
>
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
>
>
> Bugs: AMBARI-20881
> https://issues.apache.org/jira/browse/AMBARI-20881
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Log Level Filters should be handled by the config API too
>
> Also Log Level Filters should be per cluster, not only one for the Log Search Server. This means that some UI modifications are also necessary in order to query/persist changes of the log level filters for a specific cluster only.
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-config-api/pom.xml e9abed0
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/InputConfigMonitor.java df26920
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogLevelFilterMonitor.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfig.java 0bb0b78
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/loglevelfilter/LogLevelFilter.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/loglevelfilter/LogLevelFilterMap.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass1.java 969eb30
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass2.java 664ecc9
> ambari-logsearch/ambari-logsearch-config-zookeeper/pom.xml 4ed8eba
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/LogSearchConfigZK.java 738fde2
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java 074fedb
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputConfigUploader.java b70fbd1
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FilterLogData.java a05a916
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigFetcher.java 12c744c
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandler.java 0ece637
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilter.java 60c8ae8
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilterWrapper.java 9199cd3
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/FilterLogData.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/LogLevelFilterHandler.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java 135fb32
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/LogFeederUtil.java bb2f0a9
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandlerTest.java 266108f
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/resources/logfeeder.properties 59020cc
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/LogfeederFilterConfigurer.java c2d27f9
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java 8fb27a7
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java 00adb67
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ShipperConfigManager.java c0c1167
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/UserConfigManager.java a60fc5c
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerLogLevelFilter.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerLogLevelFilterMap.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LogFeederDataMap.java cc7d53d
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LogfeederFilterData.java e0f8013
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/ShipperConfigResource.java 47e6ba2
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/UserConfigResource.java 41dda05
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java dbbbf20
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-properties.xml 1ff8ad3
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml a18c5c5
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json 0adcbde
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java 607a94e
>
>
> Diff: https://reviews.apache.org/r/58822/diff/5/
>
>
> Testing
> -------
>
> Tested on local cluster, using Postman and swagger UI to test PUT/POST endpoints
>
>
> Thanks,
>
> Miklos Gergely
>
>
Re: Review Request 58822: Add Log Level Filter to the Log Search
config API
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58822/#review175239
-----------------------------------------------------------
Ship it!
Ship It!
- Oliver Szabo
On May 17, 2017, 12:04 p.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58822/
> -----------------------------------------------------------
>
> (Updated May 17, 2017, 12:04 p.m.)
>
>
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
>
>
> Bugs: AMBARI-20881
> https://issues.apache.org/jira/browse/AMBARI-20881
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Log Level Filters should be handled by the config API too
>
> Also Log Level Filters should be per cluster, not only one for the Log Search Server. This means that some UI modifications are also necessary in order to query/persist changes of the log level filters for a specific cluster only.
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-config-api/pom.xml e9abed0
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/InputConfigMonitor.java df26920
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogLevelFilterMonitor.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfig.java 0bb0b78
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/loglevelfilter/LogLevelFilter.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/loglevelfilter/LogLevelFilterMap.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass1.java 969eb30
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass2.java 664ecc9
> ambari-logsearch/ambari-logsearch-config-zookeeper/pom.xml 4ed8eba
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/LogSearchConfigZK.java 738fde2
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java 074fedb
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputConfigUploader.java b70fbd1
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FilterLogData.java a05a916
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigFetcher.java 12c744c
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandler.java 0ece637
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilter.java 60c8ae8
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilterWrapper.java 9199cd3
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/FilterLogData.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/LogLevelFilterHandler.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java 135fb32
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/LogFeederUtil.java bb2f0a9
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandlerTest.java 266108f
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/resources/logfeeder.properties 59020cc
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/LogfeederFilterConfigurer.java c2d27f9
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java 8fb27a7
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java 00adb67
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ShipperConfigManager.java c0c1167
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/UserConfigManager.java a60fc5c
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerLogLevelFilter.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerLogLevelFilterMap.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LogFeederDataMap.java cc7d53d
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LogfeederFilterData.java e0f8013
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/ShipperConfigResource.java 47e6ba2
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/UserConfigResource.java 41dda05
> ambari-logsearch/ambari-logsearch-web/src/main/webapp/templates/common/Header_tmpl.html 5f1bbdb
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java dc6037e
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-properties.xml 1ff8ad3
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml a18c5c5
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json 0adcbde
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java 8f1510b
>
>
> Diff: https://reviews.apache.org/r/58822/diff/9/
>
>
> Testing
> -------
>
> Tested on local cluster, using Postman and swagger UI to test PUT/POST endpoints
>
>
> Thanks,
>
> Miklos Gergely
>
>
Re: Review Request 58822: Add Log Level Filter to the Log Search
config API
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58822/
-----------------------------------------------------------
(Updated May 17, 2017, 12:04 p.m.)
Review request for Ambari, Oliver Szabo and Robert Nettleton.
Changes
-------
remove filters from ui until it is fixed to support multiple clusters
Bugs: AMBARI-20881
https://issues.apache.org/jira/browse/AMBARI-20881
Repository: ambari
Description
-------
Log Level Filters should be handled by the config API too
Also Log Level Filters should be per cluster, not only one for the Log Search Server. This means that some UI modifications are also necessary in order to query/persist changes of the log level filters for a specific cluster only.
Diffs (updated)
-----
ambari-logsearch/ambari-logsearch-config-api/pom.xml e9abed0
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/InputConfigMonitor.java df26920
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogLevelFilterMonitor.java PRE-CREATION
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfig.java 0bb0b78
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/loglevelfilter/LogLevelFilter.java PRE-CREATION
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/loglevelfilter/LogLevelFilterMap.java PRE-CREATION
ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass1.java 969eb30
ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass2.java 664ecc9
ambari-logsearch/ambari-logsearch-config-zookeeper/pom.xml 4ed8eba
ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/LogSearchConfigZK.java 738fde2
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java 074fedb
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputConfigUploader.java b70fbd1
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FilterLogData.java a05a916
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigFetcher.java 12c744c
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandler.java 0ece637
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilter.java 60c8ae8
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilterWrapper.java 9199cd3
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/FilterLogData.java PRE-CREATION
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/LogLevelFilterHandler.java PRE-CREATION
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java 135fb32
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/LogFeederUtil.java bb2f0a9
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandlerTest.java 266108f
ambari-logsearch/ambari-logsearch-logfeeder/src/test/resources/logfeeder.properties 59020cc
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/LogfeederFilterConfigurer.java c2d27f9
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java 8fb27a7
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java 00adb67
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ShipperConfigManager.java c0c1167
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/UserConfigManager.java a60fc5c
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerLogLevelFilter.java PRE-CREATION
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerLogLevelFilterMap.java PRE-CREATION
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LogFeederDataMap.java cc7d53d
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LogfeederFilterData.java e0f8013
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/ShipperConfigResource.java 47e6ba2
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/UserConfigResource.java 41dda05
ambari-logsearch/ambari-logsearch-web/src/main/webapp/templates/common/Header_tmpl.html 5f1bbdb
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java dc6037e
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-properties.xml 1ff8ad3
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml a18c5c5
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json 0adcbde
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java 8f1510b
Diff: https://reviews.apache.org/r/58822/diff/9/
Changes: https://reviews.apache.org/r/58822/diff/8-9/
Testing
-------
Tested on local cluster, using Postman and swagger UI to test PUT/POST endpoints
Thanks,
Miklos Gergely
Re: Review Request 58822: Add Log Level Filter to the Log Search
config API
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58822/
-----------------------------------------------------------
(Updated May 2, 2017, 11:04 a.m.)
Review request for Ambari, Oliver Szabo and Robert Nettleton.
Changes
-------
Change REST API path order
Bugs: AMBARI-20881
https://issues.apache.org/jira/browse/AMBARI-20881
Repository: ambari
Description
-------
Log Level Filters should be handled by the config API too
Also Log Level Filters should be per cluster, not only one for the Log Search Server. This means that some UI modifications are also necessary in order to query/persist changes of the log level filters for a specific cluster only.
Diffs (updated)
-----
ambari-logsearch/ambari-logsearch-config-api/pom.xml e9abed0
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/InputConfigMonitor.java df26920
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogLevelFilterMonitor.java PRE-CREATION
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfig.java 0bb0b78
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/loglevelfilter/LogLevelFilter.java PRE-CREATION
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/loglevelfilter/LogLevelFilterMap.java PRE-CREATION
ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass1.java 969eb30
ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass2.java 664ecc9
ambari-logsearch/ambari-logsearch-config-zookeeper/pom.xml 4ed8eba
ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/LogSearchConfigZK.java 738fde2
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java 074fedb
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputConfigUploader.java b70fbd1
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FilterLogData.java a05a916
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigFetcher.java 12c744c
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandler.java 0ece637
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilter.java 60c8ae8
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilterWrapper.java 9199cd3
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/FilterLogData.java PRE-CREATION
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/LogLevelFilterHandler.java PRE-CREATION
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java 135fb32
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/LogFeederUtil.java bb2f0a9
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandlerTest.java 266108f
ambari-logsearch/ambari-logsearch-logfeeder/src/test/resources/logfeeder.properties 59020cc
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/LogfeederFilterConfigurer.java c2d27f9
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java 8fb27a7
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java 00adb67
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ShipperConfigManager.java c0c1167
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/UserConfigManager.java a60fc5c
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerLogLevelFilter.java PRE-CREATION
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerLogLevelFilterMap.java PRE-CREATION
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LogFeederDataMap.java cc7d53d
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LogfeederFilterData.java e0f8013
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/ShipperConfigResource.java 47e6ba2
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/UserConfigResource.java 41dda05
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java dbbbf20
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-properties.xml 1ff8ad3
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml a18c5c5
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json 0adcbde
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java 607a94e
Diff: https://reviews.apache.org/r/58822/diff/8/
Changes: https://reviews.apache.org/r/58822/diff/7-8/
Testing
-------
Tested on local cluster, using Postman and swagger UI to test PUT/POST endpoints
Thanks,
Miklos Gergely
Re: Review Request 58822: Add Log Level Filter to the Log Search
config API
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58822/
-----------------------------------------------------------
(Updated May 2, 2017, 8:57 a.m.)
Review request for Ambari, Oliver Szabo and Robert Nettleton.
Changes
-------
fix doc constants
Bugs: AMBARI-20881
https://issues.apache.org/jira/browse/AMBARI-20881
Repository: ambari
Description
-------
Log Level Filters should be handled by the config API too
Also Log Level Filters should be per cluster, not only one for the Log Search Server. This means that some UI modifications are also necessary in order to query/persist changes of the log level filters for a specific cluster only.
Diffs (updated)
-----
ambari-logsearch/ambari-logsearch-config-api/pom.xml e9abed0
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/InputConfigMonitor.java df26920
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogLevelFilterMonitor.java PRE-CREATION
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfig.java 0bb0b78
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/loglevelfilter/LogLevelFilter.java PRE-CREATION
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/loglevelfilter/LogLevelFilterMap.java PRE-CREATION
ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass1.java 969eb30
ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass2.java 664ecc9
ambari-logsearch/ambari-logsearch-config-zookeeper/pom.xml 4ed8eba
ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/LogSearchConfigZK.java 738fde2
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java 074fedb
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputConfigUploader.java b70fbd1
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FilterLogData.java a05a916
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigFetcher.java 12c744c
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandler.java 0ece637
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilter.java 60c8ae8
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilterWrapper.java 9199cd3
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/FilterLogData.java PRE-CREATION
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/LogLevelFilterHandler.java PRE-CREATION
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java 135fb32
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/LogFeederUtil.java bb2f0a9
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandlerTest.java 266108f
ambari-logsearch/ambari-logsearch-logfeeder/src/test/resources/logfeeder.properties 59020cc
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/LogfeederFilterConfigurer.java c2d27f9
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java 8fb27a7
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java 00adb67
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ShipperConfigManager.java c0c1167
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/UserConfigManager.java a60fc5c
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerLogLevelFilter.java PRE-CREATION
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerLogLevelFilterMap.java PRE-CREATION
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LogFeederDataMap.java cc7d53d
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LogfeederFilterData.java e0f8013
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/ShipperConfigResource.java 47e6ba2
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/UserConfigResource.java 41dda05
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java dbbbf20
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-properties.xml 1ff8ad3
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml a18c5c5
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json 0adcbde
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java 607a94e
Diff: https://reviews.apache.org/r/58822/diff/7/
Changes: https://reviews.apache.org/r/58822/diff/6-7/
Testing
-------
Tested on local cluster, using Postman and swagger UI to test PUT/POST endpoints
Thanks,
Miklos Gergely
Re: Review Request 58822: Add Log Level Filter to the Log Search
config API
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58822/#review173495
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On April 28, 2017, 4:39 p.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58822/
> -----------------------------------------------------------
>
> (Updated April 28, 2017, 4:39 p.m.)
>
>
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
>
>
> Bugs: AMBARI-20881
> https://issues.apache.org/jira/browse/AMBARI-20881
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Log Level Filters should be handled by the config API too
>
> Also Log Level Filters should be per cluster, not only one for the Log Search Server. This means that some UI modifications are also necessary in order to query/persist changes of the log level filters for a specific cluster only.
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-config-api/pom.xml e9abed0
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/InputConfigMonitor.java df26920
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogLevelFilterMonitor.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfig.java 0bb0b78
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/loglevelfilter/LogLevelFilter.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/loglevelfilter/LogLevelFilterMap.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass1.java 969eb30
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass2.java 664ecc9
> ambari-logsearch/ambari-logsearch-config-zookeeper/pom.xml 4ed8eba
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/LogSearchConfigZK.java 738fde2
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java 074fedb
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputConfigUploader.java b70fbd1
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FilterLogData.java a05a916
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigFetcher.java 12c744c
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandler.java 0ece637
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilter.java 60c8ae8
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilterWrapper.java 9199cd3
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/FilterLogData.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/LogLevelFilterHandler.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java 135fb32
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/LogFeederUtil.java bb2f0a9
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandlerTest.java 266108f
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/resources/logfeeder.properties 59020cc
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/LogfeederFilterConfigurer.java c2d27f9
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java 8fb27a7
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java 00adb67
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ShipperConfigManager.java c0c1167
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/UserConfigManager.java a60fc5c
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerLogLevelFilter.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerLogLevelFilterMap.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LogFeederDataMap.java cc7d53d
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LogfeederFilterData.java e0f8013
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/ShipperConfigResource.java 47e6ba2
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/UserConfigResource.java 41dda05
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java dbbbf20
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-properties.xml 1ff8ad3
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml a18c5c5
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json 0adcbde
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java 607a94e
>
>
> Diff: https://reviews.apache.org/r/58822/diff/6/
>
>
> Testing
> -------
>
> Tested on local cluster, using Postman and swagger UI to test PUT/POST endpoints
>
>
> Thanks,
>
> Miklos Gergely
>
>
Re: Review Request 58822: Add Log Level Filter to the Log Search
config API
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58822/
-----------------------------------------------------------
(Updated April 28, 2017, 4:39 p.m.)
Review request for Ambari, Oliver Szabo and Robert Nettleton.
Changes
-------
Fix REST API path
Bugs: AMBARI-20881
https://issues.apache.org/jira/browse/AMBARI-20881
Repository: ambari
Description
-------
Log Level Filters should be handled by the config API too
Also Log Level Filters should be per cluster, not only one for the Log Search Server. This means that some UI modifications are also necessary in order to query/persist changes of the log level filters for a specific cluster only.
Diffs (updated)
-----
ambari-logsearch/ambari-logsearch-config-api/pom.xml e9abed0
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/InputConfigMonitor.java df26920
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogLevelFilterMonitor.java PRE-CREATION
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfig.java 0bb0b78
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/loglevelfilter/LogLevelFilter.java PRE-CREATION
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/loglevelfilter/LogLevelFilterMap.java PRE-CREATION
ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass1.java 969eb30
ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass2.java 664ecc9
ambari-logsearch/ambari-logsearch-config-zookeeper/pom.xml 4ed8eba
ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/LogSearchConfigZK.java 738fde2
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java 074fedb
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputConfigUploader.java b70fbd1
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FilterLogData.java a05a916
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigFetcher.java 12c744c
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandler.java 0ece637
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilter.java 60c8ae8
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilterWrapper.java 9199cd3
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/FilterLogData.java PRE-CREATION
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/LogLevelFilterHandler.java PRE-CREATION
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java 135fb32
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/LogFeederUtil.java bb2f0a9
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandlerTest.java 266108f
ambari-logsearch/ambari-logsearch-logfeeder/src/test/resources/logfeeder.properties 59020cc
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/LogfeederFilterConfigurer.java c2d27f9
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java 8fb27a7
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java 00adb67
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ShipperConfigManager.java c0c1167
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/UserConfigManager.java a60fc5c
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerLogLevelFilter.java PRE-CREATION
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerLogLevelFilterMap.java PRE-CREATION
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LogFeederDataMap.java cc7d53d
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LogfeederFilterData.java e0f8013
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/ShipperConfigResource.java 47e6ba2
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/UserConfigResource.java 41dda05
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java dbbbf20
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-properties.xml 1ff8ad3
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml a18c5c5
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json 0adcbde
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java 607a94e
Diff: https://reviews.apache.org/r/58822/diff/6/
Changes: https://reviews.apache.org/r/58822/diff/5-6/
Testing
-------
Tested on local cluster, using Postman and swagger UI to test PUT/POST endpoints
Thanks,
Miklos Gergely
Re: Review Request 58822: Add Log Level Filter to the Log Search
config API
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58822/
-----------------------------------------------------------
(Updated April 28, 2017, 4:17 p.m.)
Review request for Ambari, Oliver Szabo and Robert Nettleton.
Changes
-------
Renamed UI classes as Oliver requested
Bugs: AMBARI-20881
https://issues.apache.org/jira/browse/AMBARI-20881
Repository: ambari
Description
-------
Log Level Filters should be handled by the config API too
Also Log Level Filters should be per cluster, not only one for the Log Search Server. This means that some UI modifications are also necessary in order to query/persist changes of the log level filters for a specific cluster only.
Diffs (updated)
-----
ambari-logsearch/ambari-logsearch-config-api/pom.xml e9abed0
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/InputConfigMonitor.java df26920
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogLevelFilterMonitor.java PRE-CREATION
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfig.java 0bb0b78
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/loglevelfilter/LogLevelFilter.java PRE-CREATION
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/loglevelfilter/LogLevelFilterMap.java PRE-CREATION
ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass1.java 969eb30
ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass2.java 664ecc9
ambari-logsearch/ambari-logsearch-config-zookeeper/pom.xml 4ed8eba
ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/LogSearchConfigZK.java 738fde2
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java 074fedb
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputConfigUploader.java b70fbd1
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FilterLogData.java a05a916
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigFetcher.java 12c744c
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandler.java 0ece637
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilter.java 60c8ae8
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilterWrapper.java 9199cd3
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/FilterLogData.java PRE-CREATION
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/LogLevelFilterHandler.java PRE-CREATION
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java 135fb32
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/LogFeederUtil.java bb2f0a9
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandlerTest.java 266108f
ambari-logsearch/ambari-logsearch-logfeeder/src/test/resources/logfeeder.properties 59020cc
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/LogfeederFilterConfigurer.java c2d27f9
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java 8fb27a7
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java 00adb67
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ShipperConfigManager.java c0c1167
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/UserConfigManager.java a60fc5c
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerLogLevelFilter.java PRE-CREATION
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerLogLevelFilterMap.java PRE-CREATION
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LogFeederDataMap.java cc7d53d
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LogfeederFilterData.java e0f8013
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/ShipperConfigResource.java 47e6ba2
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/UserConfigResource.java 41dda05
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java dbbbf20
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-properties.xml 1ff8ad3
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml a18c5c5
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json 0adcbde
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java 607a94e
Diff: https://reviews.apache.org/r/58822/diff/5/
Changes: https://reviews.apache.org/r/58822/diff/4-5/
Testing (updated)
-------
Tested on local cluster, using Postman and swagger UI to test PUT/POST endpoints
Thanks,
Miklos Gergely
Re: Review Request 58822: Add Log Level Filter to the Log Search
config API
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58822/
-----------------------------------------------------------
(Updated April 28, 2017, 3:57 p.m.)
Review request for Ambari, Oliver Szabo and Robert Nettleton.
Changes
-------
Remove swagger version from pom.
Bugs: AMBARI-20881
https://issues.apache.org/jira/browse/AMBARI-20881
Repository: ambari
Description
-------
Log Level Filters should be handled by the config API too
Also Log Level Filters should be per cluster, not only one for the Log Search Server. This means that some UI modifications are also necessary in order to query/persist changes of the log level filters for a specific cluster only.
Diffs (updated)
-----
ambari-logsearch/ambari-logsearch-config-api/pom.xml e9abed0
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/InputConfigMonitor.java df26920
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogLevelFilterMonitor.java PRE-CREATION
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfig.java 0bb0b78
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/loglevelfilter/LogLevelFilter.java PRE-CREATION
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/loglevelfilter/LogLevelFilterMap.java PRE-CREATION
ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass1.java 969eb30
ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass2.java 664ecc9
ambari-logsearch/ambari-logsearch-config-zookeeper/pom.xml 4ed8eba
ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/LogSearchConfigZK.java 738fde2
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java 074fedb
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputConfigUploader.java b70fbd1
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FilterLogData.java a05a916
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigFetcher.java 12c744c
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandler.java 0ece637
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilter.java 60c8ae8
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilterWrapper.java 9199cd3
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/FilterLogData.java PRE-CREATION
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/LogLevelFilterHandler.java PRE-CREATION
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java 135fb32
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/LogFeederUtil.java bb2f0a9
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandlerTest.java 266108f
ambari-logsearch/ambari-logsearch-logfeeder/src/test/resources/logfeeder.properties 59020cc
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/LogfeederFilterConfigurer.java c2d27f9
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java 8fb27a7
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java 00adb67
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ShipperConfigManager.java c0c1167
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/UserConfigManager.java a60fc5c
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LogFeederDataMap.java cc7d53d
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LogfeederFilterData.java e0f8013
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/loglevelfilter/LogLevelFilterMapModel.java PRE-CREATION
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/loglevelfilter/LogLevelFilterModel.java PRE-CREATION
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/ShipperConfigResource.java 47e6ba2
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/UserConfigResource.java 41dda05
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java dbbbf20
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-properties.xml 1ff8ad3
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml a18c5c5
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json 0adcbde
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java 607a94e
Diff: https://reviews.apache.org/r/58822/diff/4/
Changes: https://reviews.apache.org/r/58822/diff/3-4/
Testing
-------
Tested on local cluster, using Postman to test PUT/POST endpoints
Thanks,
Miklos Gergely
Re: Review Request 58822: Add Log Level Filter to the Log Search
config API
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58822/#review173333
-----------------------------------------------------------
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/loglevelfilter/LogLevelFilterMapModel.java
Lines 32 (patched)
<https://reviews.apache.org/r/58822/#comment246353>
you can put that inside org.apache.ambari.logsearch.model.common package (i guess you deleted that), also dont call it to model
- Oliver Szabo
On April 28, 2017, 3:32 p.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58822/
> -----------------------------------------------------------
>
> (Updated April 28, 2017, 3:32 p.m.)
>
>
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
>
>
> Bugs: AMBARI-20881
> https://issues.apache.org/jira/browse/AMBARI-20881
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Log Level Filters should be handled by the config API too
>
> Also Log Level Filters should be per cluster, not only one for the Log Search Server. This means that some UI modifications are also necessary in order to query/persist changes of the log level filters for a specific cluster only.
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-config-api/pom.xml e9abed0
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/InputConfigMonitor.java df26920
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogLevelFilterMonitor.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfig.java 0bb0b78
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/loglevelfilter/LogLevelFilter.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/loglevelfilter/LogLevelFilterMap.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass1.java 969eb30
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass2.java 664ecc9
> ambari-logsearch/ambari-logsearch-config-zookeeper/pom.xml 4ed8eba
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/LogSearchConfigZK.java 738fde2
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java 074fedb
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputConfigUploader.java b70fbd1
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FilterLogData.java a05a916
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigFetcher.java 12c744c
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandler.java 0ece637
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilter.java 60c8ae8
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilterWrapper.java 9199cd3
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/FilterLogData.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/LogLevelFilterHandler.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java 135fb32
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/LogFeederUtil.java bb2f0a9
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandlerTest.java 266108f
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/resources/logfeeder.properties 59020cc
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/LogfeederFilterConfigurer.java c2d27f9
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java 8fb27a7
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java 00adb67
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ShipperConfigManager.java c0c1167
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/UserConfigManager.java a60fc5c
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LogFeederDataMap.java cc7d53d
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LogfeederFilterData.java e0f8013
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/loglevelfilter/LogLevelFilterMapModel.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/loglevelfilter/LogLevelFilterModel.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/ShipperConfigResource.java 47e6ba2
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/UserConfigResource.java 41dda05
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java dbbbf20
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-properties.xml 1ff8ad3
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml a18c5c5
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json 0adcbde
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java 607a94e
>
>
> Diff: https://reviews.apache.org/r/58822/diff/3/
>
>
> Testing
> -------
>
> Tested on local cluster, using Postman to test PUT/POST endpoints
>
>
> Thanks,
>
> Miklos Gergely
>
>
Re: Review Request 58822: Add Log Level Filter to the Log Search
config API
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58822/
-----------------------------------------------------------
(Updated April 28, 2017, 3:32 p.m.)
Review request for Ambari, Oliver Szabo and Robert Nettleton.
Changes
-------
Removed unused annotations from the LogLevelFilter API POJOs, and also moved moved out swagger specific annotations from the API.
Bugs: AMBARI-20881
https://issues.apache.org/jira/browse/AMBARI-20881
Repository: ambari
Description
-------
Log Level Filters should be handled by the config API too
Also Log Level Filters should be per cluster, not only one for the Log Search Server. This means that some UI modifications are also necessary in order to query/persist changes of the log level filters for a specific cluster only.
Diffs (updated)
-----
ambari-logsearch/ambari-logsearch-config-api/pom.xml e9abed0
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/InputConfigMonitor.java df26920
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogLevelFilterMonitor.java PRE-CREATION
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfig.java 0bb0b78
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/loglevelfilter/LogLevelFilter.java PRE-CREATION
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/loglevelfilter/LogLevelFilterMap.java PRE-CREATION
ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass1.java 969eb30
ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass2.java 664ecc9
ambari-logsearch/ambari-logsearch-config-zookeeper/pom.xml 4ed8eba
ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/LogSearchConfigZK.java 738fde2
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java 074fedb
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputConfigUploader.java b70fbd1
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FilterLogData.java a05a916
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigFetcher.java 12c744c
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandler.java 0ece637
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilter.java 60c8ae8
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilterWrapper.java 9199cd3
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/FilterLogData.java PRE-CREATION
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/LogLevelFilterHandler.java PRE-CREATION
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java 135fb32
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/LogFeederUtil.java bb2f0a9
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandlerTest.java 266108f
ambari-logsearch/ambari-logsearch-logfeeder/src/test/resources/logfeeder.properties 59020cc
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/LogfeederFilterConfigurer.java c2d27f9
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java 8fb27a7
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java 00adb67
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ShipperConfigManager.java c0c1167
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/UserConfigManager.java a60fc5c
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LogFeederDataMap.java cc7d53d
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LogfeederFilterData.java e0f8013
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/loglevelfilter/LogLevelFilterMapModel.java PRE-CREATION
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/loglevelfilter/LogLevelFilterModel.java PRE-CREATION
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/ShipperConfigResource.java 47e6ba2
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/UserConfigResource.java 41dda05
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java dbbbf20
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-properties.xml 1ff8ad3
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml a18c5c5
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json 0adcbde
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java 607a94e
Diff: https://reviews.apache.org/r/58822/diff/3/
Changes: https://reviews.apache.org/r/58822/diff/2-3/
Testing
-------
Tested on local cluster, using Postman to test PUT/POST endpoints
Thanks,
Miklos Gergely
Re: Review Request 58822: Add Log Level Filter to the Log Search
config API
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58822/
-----------------------------------------------------------
(Updated April 28, 2017, 11:31 a.m.)
Review request for Ambari, Oliver Szabo and Robert Nettleton.
Changes
-------
Fix javadoc
Bugs: AMBARI-20881
https://issues.apache.org/jira/browse/AMBARI-20881
Repository: ambari
Description
-------
Log Level Filters should be handled by the config API too
Also Log Level Filters should be per cluster, not only one for the Log Search Server. This means that some UI modifications are also necessary in order to query/persist changes of the log level filters for a specific cluster only.
Diffs (updated)
-----
ambari-logsearch/ambari-logsearch-config-api/pom.xml e9abed0
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/InputConfigMonitor.java df26920
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogLevelFilterMonitor.java PRE-CREATION
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfig.java 0bb0b78
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/loglevelfilter/LogLevelFilter.java PRE-CREATION
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/loglevelfilter/LogLevelFilterMap.java PRE-CREATION
ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass1.java 969eb30
ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass2.java 664ecc9
ambari-logsearch/ambari-logsearch-config-zookeeper/pom.xml 4ed8eba
ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/LogSearchConfigZK.java 738fde2
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java 074fedb
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputConfigUploader.java b70fbd1
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FilterLogData.java a05a916
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigFetcher.java 12c744c
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandler.java 0ece637
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilter.java 60c8ae8
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilterWrapper.java 9199cd3
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/FilterLogData.java PRE-CREATION
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/LogLevelFilterHandler.java PRE-CREATION
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java 135fb32
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/LogFeederUtil.java bb2f0a9
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandlerTest.java 266108f
ambari-logsearch/ambari-logsearch-logfeeder/src/test/resources/logfeeder.properties 59020cc
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/LogfeederFilterConfigurer.java c2d27f9
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java 8fb27a7
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java 00adb67
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ShipperConfigManager.java c0c1167
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/UserConfigManager.java a60fc5c
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LogFeederDataMap.java cc7d53d
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LogfeederFilterData.java e0f8013
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/ShipperConfigResource.java 47e6ba2
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/UserConfigResource.java 41dda05
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java dbbbf20
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-properties.xml 1ff8ad3
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml a18c5c5
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json 0adcbde
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java 607a94e
Diff: https://reviews.apache.org/r/58822/diff/2/
Changes: https://reviews.apache.org/r/58822/diff/1-2/
Testing
-------
Tested on local cluster, using Postman to test PUT/POST endpoints
Thanks,
Miklos Gergely