You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2023/04/17 18:26:34 UTC

[native-toolchain-CR] IMPALA-12070: Use autotools/bison from the OS rather than building it

Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19756


Change subject: IMPALA-12070: Use autotools/bison from the OS rather than building it
......................................................................

IMPALA-12070: Use autotools/bison from the OS rather than building it

This stops building autoconf, automake, bison, and libtool.
These utilities are already installed in the docker images,
so this removes any code that used the toolchain version
of these. This is useful from a license perspective, because
several of these are GPL licensed. Removing them avoids any
complications due to licensing, and it brings the native-toolchain
code closer to compatibility with Apache Impala.

This also removes unused build code for cyrus-sasl, krb5,
and openssl. This code remains in the history and can be
revived at any time.

Testing:
 - Ran a full toolchain build

Change-Id: I2f0603671fa443b26b3a339874f4154e853e2a06
---
M build-kudu-only.sh
M buildall.sh
M functions.sh
M init-compiler.sh
M init.sh
D source/autoconf/build.sh
D source/automake/automake-1.14.1-patches/0001-make-help2man-work-with-perl.patch
D source/automake/build.sh
D source/bison/bison-3.0.4-patches/110-glibc-change-work-around.patch
D source/bison/build.sh
M source/crcutil/build.sh
D source/cyrus-sasl/build.sh
D source/krb5/build.sh
D source/libtool/build.sh
D source/openssl/build.sh
M source/thrift/build.sh
16 files changed, 3 insertions(+), 392 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/56/19756/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19756
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f0603671fa443b26b3a339874f4154e853e2a06
Gerrit-Change-Number: 19756
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>

[native-toolchain-CR] IMPALA-12070: Use autotools/bison from the OS rather than building it

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19756 )

Change subject: IMPALA-12070: Use autotools/bison from the OS rather than building it
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19756
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0603671fa443b26b3a339874f4154e853e2a06
Gerrit-Change-Number: 19756
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Apr 2023 21:50:41 +0000
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-12070: Use autotools/bison from the OS rather than building it

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19756 )

Change subject: IMPALA-12070: Use autotools/bison from the OS rather than building it
......................................................................


Patch Set 1: Code-Review+2

Carry +1 from Michael


-- 
To view, visit http://gerrit.cloudera.org:8080/19756
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0603671fa443b26b3a339874f4154e853e2a06
Gerrit-Change-Number: 19756
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 18 Apr 2023 17:32:57 +0000
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-12070: Use autotools/bison from the OS rather than building it

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19756 )

Change subject: IMPALA-12070: Use autotools/bison from the OS rather than building it
......................................................................

IMPALA-12070: Use autotools/bison from the OS rather than building it

This stops building autoconf, automake, bison, and libtool.
These utilities are already installed in the docker images,
so this removes any code that used the toolchain version
of these. This is useful from a license perspective, because
several of these are GPL licensed. Removing them avoids any
complications due to licensing, and it brings the native-toolchain
code closer to compatibility with Apache Impala.

This also removes unused build code for cyrus-sasl, krb5,
and openssl. This code remains in the history and can be
revived at any time.

Testing:
 - Ran a full toolchain build

Change-Id: I2f0603671fa443b26b3a339874f4154e853e2a06
Reviewed-on: http://gerrit.cloudera.org:8080/19756
Reviewed-by: Michael Smith <mi...@cloudera.com>
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
---
M build-kudu-only.sh
M buildall.sh
M functions.sh
M init-compiler.sh
M init.sh
D source/autoconf/build.sh
D source/automake/automake-1.14.1-patches/0001-make-help2man-work-with-perl.patch
D source/automake/build.sh
D source/bison/bison-3.0.4-patches/110-glibc-change-work-around.patch
D source/bison/build.sh
M source/crcutil/build.sh
D source/cyrus-sasl/build.sh
D source/krb5/build.sh
D source/libtool/build.sh
D source/openssl/build.sh
M source/thrift/build.sh
16 files changed, 3 insertions(+), 392 deletions(-)

Approvals:
  Michael Smith: Looks good to me, but someone else must approve
  Wenzhe Zhou: Looks good to me, approved
  Joe McDonnell: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/19756
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f0603671fa443b26b3a339874f4154e853e2a06
Gerrit-Change-Number: 19756
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[native-toolchain-CR] IMPALA-12070: Use autotools/bison from the OS rather than building it

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19756 )

Change subject: IMPALA-12070: Use autotools/bison from the OS rather than building it
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19756
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0603671fa443b26b3a339874f4154e853e2a06
Gerrit-Change-Number: 19756
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 17 Apr 2023 18:43:19 +0000
Gerrit-HasComments: No