You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@plc4x.apache.org by GitBox <gi...@apache.org> on 2021/08/24 16:37:17 UTC

[GitHub] [plc4x] ottobackwards commented on a change in pull request #257: Feature/nifi record

ottobackwards commented on a change in pull request #257:
URL: https://github.com/apache/plc4x/pull/257#discussion_r695020436



##########
File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/main/java/org/apache/plc4x/nifi/Plc4xSourceRecordProcessor.java
##########
@@ -154,11 +163,24 @@ public void onTrigger(final ProcessContext context, final ProcessSession session
 				}
 			});
 			PlcReadRequest readRequest = builder.build();
-			PlcReadResponse readResponse = readRequest.execute().get(10, TimeUnit.SECONDS);
+			final FlowFile originalFlowFile = fileToProcess;
 			resultSetFF = session.write(resultSetFF, out -> {
 				try {

Review comment:
       @chrisdutz :  is there any cleanup of the readRequest that should be done here before throwing out of this method?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org