[8/9] git commit: Add comment about RebindTestFixture checkSerializable

[al...@apache.org]

Add comment about RebindTestFixture checkSerializable

Project: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/commit/8b69ff7b
Tree: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/tree/8b69ff7b
Diff: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/diff/8b69ff7b

Branch: refs/heads/master
Commit: 8b69ff7bd56e7a088e9d1ee101c1fac11b902236
Parents: bb28e29
Author: Aled Sage <al...@gmail.com>
Authored: Mon Nov 3 14:23:48 2014 +0000
Committer: Aled Sage <al...@gmail.com>
Committed: Mon Nov 3 14:23:48 2014 +0000

----------------------------------------------------------------------
 .../test/java/brooklyn/entity/rebind/RebindTestFixture.java   | 7 +++++++
 1 file changed, 7 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/blob/8b69ff7b/core/src/test/java/brooklyn/entity/rebind/RebindTestFixture.java
----------------------------------------------------------------------
diff --git a/core/src/test/java/brooklyn/entity/rebind/RebindTestFixture.java b/core/src/test/java/brooklyn/entity/rebind/RebindTestFixture.java
index d4e47dd..1466405 100644
--- a/core/src/test/java/brooklyn/entity/rebind/RebindTestFixture.java
+++ b/core/src/test/java/brooklyn/entity/rebind/RebindTestFixture.java
@@ -122,6 +122,13 @@ public abstract class RebindTestFixture<T extends StartableApplication> {
         return rebind(true);
     }
 
+    /**
+     * TODO We should (probably?!) change everywhere from asserting that they are serializable. 
+     * They only need to be xstream-serializable, which does not require `implements Serializable`. 
+     * Also, the xstream serializer has some special hooks that replaces an entity reference with 
+     * a marker for that entity, etc. Suggest we change the default {@link #rebind()} to use 
+     * {@code checkSerializable==false}, and deprecate this + the other overloaded methods?
+     */
     protected T rebind(boolean checkSerializable) throws Exception {
         // TODO What are sensible defaults?!
         return rebind(checkSerializable, false);