You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/17 14:18:38 UTC
[GitHub] [airflow] egibbm opened a new issue #9347: QuboleHook unable to build command with list tags
egibbm opened a new issue #9347:
URL: https://github.com/apache/airflow/issues/9347
<!--
Welcome to Apache Airflow! For a smooth issue process, try to answer the following questions.
Don't worry if they're not all applicable; just try to include what you can :-)
If you need to include code snippets or logs, please put them in fenced code
blocks. If they're super-long, please use the details tag like
<details><summary>super-long log</summary> lots of stuff </details>
Please delete these comment blocks before submitting the issue.
-->
<!--
IMPORTANT!!!
PLEASE CHECK "SIMILAR TO X EXISTING ISSUES" OPTION IF VISIBLE
NEXT TO "SUBMIT NEW ISSUE" BUTTON!!!
PLEASE CHECK IF THIS ISSUE HAS BEEN REPORTED PREVIOUSLY USING SEARCH!!!
Please complete the next sections or the issue will be closed.
This questions are the first thing we need to know to understand the context.
-->
**Apache Airflow version**: 1.10.10
**Kubernetes version (if you are using kubernetes)** (use `kubectl version`):
**Environment**:
- **Cloud provider or hardware configuration**: Google Cloud
- **OS** (e.g. from /etc/os-release): Ubuntu 18.04.4 LTS
- **Kernel** (e.g. `uname -a`): Linux int-vidio-stats-airflow-bionic 5.0.0-1034-gcp #35-Ubuntu SMP Tue Mar 17 03:56:45 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
- **Install tools**: pip
- **Others**:
**What happened**:
Recently, we upgraded airflow version from v1.10.5 to v1.10.10 due to airflow instance that upgraded to ubuntu bionic. Existing dag configuration having tags as list causes an issue at some jobs that use Qubole.
Error log:
```
Traceback (most recent call last):
File "/home/jenkins/virtualenv/airflow/lib/python3.6/site-packages/airflow/models/taskinstance.py", line 983, in _run_raw_task
result = task_copy.execute(context=context)
File "/home/jenkins/virtualenv/airflow/lib/python3.6/site-packages/airflow/contrib/operators/qubole_operator.py", line 207, in execute
return self.get_hook().execute(context)
File "/home/jenkins/virtualenv/airflow/lib/python3.6/site-packages/airflow/contrib/hooks/qubole_hook.py", line 131, in execute
args = self.cls.parse(self.create_cmd_args(context))
File "/home/jenkins/virtualenv/airflow/lib/python3.6/site-packages/airflow/contrib/hooks/qubole_hook.py", line 248, in create_cmd_args
self._add_tags(tags, value)
File "/home/jenkins/virtualenv/airflow/lib/python3.6/site-packages/airflow/contrib/hooks/qubole_hook.py", line 267, in _add_tags
tags.extend(value)
AttributeError: 'set' object has no attribute 'extend'
```
**What you expected to happen**:
the tags should be included as a comma separated arguments to the build command.
**How to reproduce it**:
using sample dag having list tags
```
t2 = QuboleOperator(
task_id='hive_gcs_location',
command_type="hivecmd",
script_location="s3n://public-qubole/qbol-library/scripts/show_table.hql",
notify=True,
tags=['tag1', 'tag2'],
trigger_rule="all_done"
)
```
and do an airflow run.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #9347: QuboleHook unable to build command with list tags
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #9347:
URL: https://github.com/apache/airflow/issues/9347#issuecomment-691994453
@chattarajoy I assigned you to these tickets.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] chattarajoy commented on issue #9347: QuboleHook unable to build command with list tags
Posted by GitBox <gi...@apache.org>.
chattarajoy commented on issue #9347:
URL: https://github.com/apache/airflow/issues/9347#issuecomment-691993896
sure @mik-laj create issues for both the points mentioned will look into it. Could you pls change the assignee for the to me?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #9347: QuboleHook unable to build command with list tags
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #9347:
URL: https://github.com/apache/airflow/issues/9347#issuecomment-691988305
@chattarajoy Awesome!
This is one more topic. We are trying to improve our documentation, and I see a guides that explains how to use these operators is missing. Here are guides for other operators: https://airflow.readthedocs.io/en/latest/howto/operator/index.html
Wouldn't you like to write a guide for this operator?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on issue #9347: QuboleHook unable to build command with list tags
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on issue #9347:
URL: https://github.com/apache/airflow/issues/9347#issuecomment-691988305
@chattarajoy Awesome!
This is one more topic. We are trying to improve our documentation, and I see a guides that explains how to use these operators is missing. Here are guides for other operators: https://airflow.readthedocs.io/en/latest/howto/operator/index.html
Wouldn't you like to write a guide for this operator? In practice, the guide is an example DAG file + description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj closed issue #9347: QuboleHook unable to build command with list tags
Posted by GitBox <gi...@apache.org>.
mik-laj closed issue #9347:
URL: https://github.com/apache/airflow/issues/9347
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #9347: QuboleHook unable to build command with list tags
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #9347:
URL: https://github.com/apache/airflow/issues/9347#issuecomment-691983886
@chattarajoy @anmol-dhingra @randuhmm Can you take a look at this ticket? Would you like to help solve it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #9347: QuboleHook unable to build command with list tags
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #9347:
URL: https://github.com/apache/airflow/issues/9347#issuecomment-691988905
This provider also has poor typing coverage.
https://github.com/apache/airflow/issues/9708#issuecomment-687518888
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] chattarajoy commented on issue #9347: QuboleHook unable to build command with list tags
Posted by GitBox <gi...@apache.org>.
chattarajoy commented on issue #9347:
URL: https://github.com/apache/airflow/issues/9347#issuecomment-691986313
@mik-laj this was fixed with https://github.com/apache/airflow/pull/9349
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] chattarajoy edited a comment on issue #9347: QuboleHook unable to build command with list tags
Posted by GitBox <gi...@apache.org>.
chattarajoy edited a comment on issue #9347:
URL: https://github.com/apache/airflow/issues/9347#issuecomment-691993896
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #9347: QuboleHook unable to build command with list tags
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #9347:
URL: https://github.com/apache/airflow/issues/9347#issuecomment-645402731
Thanks for opening your first issue here! Be sure to follow the issue template!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org