You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by "Hendrik Maryns (JIRA)" <ji...@apache.org> on 2006/07/06 18:26:34 UTC

[jira] Created: (COLLECTIONS-216) MultiKey's toString method should use Arrays.toString

MultiKey's toString method should use Arrays.toString
-----------------------------------------------------

         Key: COLLECTIONS-216
         URL: http://issues.apache.org/jira/browse/COLLECTIONS-216
     Project: Commons Collections
        Type: Improvement

    Versions: 3.2    
    Reporter: Hendrik Maryns
    Priority: Minor


Some minor comments on MultiKey:

- its toString method unnecessarily creates an extra Object.
- there are some unnecessary casts
- there is a mistake in the javadocs (actually, this mistake, 'lookup', which should be in two words, is prevalent in all of the map API)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Commented: (COLLECTIONS-216) MultiKey's toString method should use Arrays.toString

Posted by "Hendrik Maryns (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/COLLECTIONS-216?page=comments#action_12419570 ] 

Hendrik Maryns commented on COLLECTIONS-216:
--------------------------------------------

Ah, I didn't notice that.  However, at least the typo can be fixed.

I'll submit this bug in the sourceforge collections15 project.

> MultiKey's toString method should use Arrays.toString
> -----------------------------------------------------
>
>          Key: COLLECTIONS-216
>          URL: http://issues.apache.org/jira/browse/COLLECTIONS-216
>      Project: Commons Collections
>         Type: Improvement

>     Versions: 3.2
>     Reporter: Hendrik Maryns
>     Priority: Minor
>  Attachments: MultiKey.diff
>
> Some minor comments on MultiKey:
> - its toString method unnecessarily creates an extra Object.
> - there are some unnecessary casts
> - there is a mistake in the javadocs (actually, this mistake, 'lookup', which should be in two words, is prevalent in all of the map API)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Commented: (COLLECTIONS-216) MultiKey's toString method should use Arrays.toString

Posted by "Matt Benson (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/COLLECTIONS-216?page=comments#action_12419569 ] 

Matt Benson commented on COLLECTIONS-216:
-----------------------------------------

Since Arrays.toString() is only available beginning with Java 1.5, this patch cannot be applied until the [collections] trunk is 1.5-only.

> MultiKey's toString method should use Arrays.toString
> -----------------------------------------------------
>
>          Key: COLLECTIONS-216
>          URL: http://issues.apache.org/jira/browse/COLLECTIONS-216
>      Project: Commons Collections
>         Type: Improvement

>     Versions: 3.2
>     Reporter: Hendrik Maryns
>     Priority: Minor
>  Attachments: MultiKey.diff
>
> Some minor comments on MultiKey:
> - its toString method unnecessarily creates an extra Object.
> - there are some unnecessary casts
> - there is a mistake in the javadocs (actually, this mistake, 'lookup', which should be in two words, is prevalent in all of the map API)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Updated: (COLLECTIONS-216) MultiKey's toString method should use Arrays.toString

Posted by "Hendrik Maryns (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/COLLECTIONS-216?page=all ]

Hendrik Maryns updated COLLECTIONS-216:
---------------------------------------

    Attachment: MultiKey.diff

A patch with the alterations I suggest, plus one typo.

> MultiKey's toString method should use Arrays.toString
> -----------------------------------------------------
>
>          Key: COLLECTIONS-216
>          URL: http://issues.apache.org/jira/browse/COLLECTIONS-216
>      Project: Commons Collections
>         Type: Improvement

>     Versions: 3.2
>     Reporter: Hendrik Maryns
>     Priority: Minor
>  Attachments: MultiKey.diff
>
> Some minor comments on MultiKey:
> - its toString method unnecessarily creates an extra Object.
> - there are some unnecessary casts
> - there is a mistake in the javadocs (actually, this mistake, 'lookup', which should be in two words, is prevalent in all of the map API)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Closed: (COLLECTIONS-216) MultiKey's toString method should use Arrays.toString

Posted by "Stephen Colebourne (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/COLLECTIONS-216?page=all ]
     
Stephen Colebourne closed COLLECTIONS-216:
------------------------------------------

    Fix Version: 3.3
     Resolution: Fixed

Spelling fix checked in

> MultiKey's toString method should use Arrays.toString
> -----------------------------------------------------
>
>          Key: COLLECTIONS-216
>          URL: http://issues.apache.org/jira/browse/COLLECTIONS-216
>      Project: Commons Collections
>         Type: Improvement

>     Versions: 3.2
>     Reporter: Hendrik Maryns
>     Priority: Minor
>      Fix For: 3.3
>  Attachments: MultiKey.diff
>
> Some minor comments on MultiKey:
> - its toString method unnecessarily creates an extra Object.
> - there are some unnecessary casts
> - there is a mistake in the javadocs (actually, this mistake, 'lookup', which should be in two words, is prevalent in all of the map API)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org