[jira] [Commented] (SENTRY-2091) User-based Privilege is broken by SENTRY-769

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SENTRY-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283817#comment-16283817 ] 

Hadoop QA commented on SENTRY-2091:
-----------------------------------

Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12901255/SENTRY-2091.001.patch against master.

{color:red}Overall:{color} -1 due to 2 errors

{color:red}ERROR:{color} mvn test exited 1
{color:red}ERROR:{color} Failed: org.apache.sentry.binding.solr.TestSolrAuthzBinding

Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3568/console

This message is automatically generated.

> User-based Privilege is broken by SENTRY-769
> --------------------------------------------
>
>                 Key: SENTRY-2091
>                 URL: https://issues.apache.org/jira/browse/SENTRY-2091
>             Project: Sentry
>          Issue Type: Bug
>          Components: Sentry
>    Affects Versions: 2.1.0
>            Reporter: Na Li
>            Assignee: Na Li
>         Attachments: SENTRY-2091.001.patch
>
>
> SENTRY-769 throws exception when a user has no group. This breaks user-based privilege as the exception prevents getting privilege using user-based privilege.
> For example, in the following code
> {code}
> Set<String> userPrivileges =
>         authProvider.getPolicyEngine().getPrivileges(
>             authProvider.getGroupMapping().getGroups(userName), Sets.newHashSet(userName),
>             hiveAuthzBinding.getActiveRoleSet(), hiveAuthzBinding.getAuthServer());
> {code}
> when user has no group, the exception causes the processing stops even when user has privilege. 
> The solution is to catch the exception, and continue the processing. 
> {code}
> try {
> Set<String> groups = null;
> try {
>   groups = authProvider.getGroupMapping().getGroups(userName)
> } catch (SentryGroupNotFoundException ex) {
>   log.debug(...);
>   groups = new HashSet<String>();
> }
> Set<String> userPrivileges =
>         authProvider.getPolicyEngine().getPrivileges(
>             groups, Sets.newHashSet(userName),
>             hiveAuthzBinding.getActiveRoleSet(), hiveAuthzBinding.getAuthServer());
>         ...
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)