[jira] [Commented] (CALCITE-4905) JdbcCalc does not extend Calc

["Julian Hyde (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450185#comment-17450185 ] 

Julian Hyde commented on CALCITE-4905:
--------------------------------------

Please note that JIRA uses braces rather than backticks. Can you reformat your description.

Well done for noticing this; however, I am not convinced that this is a bug, and therefore I am not sure that we should fix it.

{{Calc}} is not a fundamental relational operation; it is introduced during planning to help us optimize certain code generation. So, at {{RelToSqlConverter}} time, perhaps we should split {{JdbcCalc}} into {{JdbcFilter}} followed by {{JdbcProject}}. That would be preferable to repeating a lot of logic.

Do you have test case for the {{RelToSqlConverter}} problem that you observed?

> JdbcCalc does not extend Calc
> -----------------------------
>
>                 Key: CALCITE-4905
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4905
>             Project: Calcite
>          Issue Type: Bug
>          Components: jdbc-adapter
>    Affects Versions: 1.28.0
>            Reporter: Francesco Gini
>            Assignee: Francesco Gini
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.29.0
>
>
> `JdbcCalc` class does not implement Calc. Failing to do that means that `
> RelToSqlConverter` cannot translate a plan with `JdbcCalc` into sql because `RelToSqlConverter` expects
> ```
> {color:#cc7832}public {color}Result {color:#ffc66d}visit{color}(Calc e)
> ```



--
This message was sent by Atlassian Jira
(v8.20.1#820001)