[GitHub] [arrow] JabariBooker commented on a change in pull request #12014: ARROW-10924: [C++] Validate temporal data in ValidateArrayFull

[GitBox <gi...@apache.org>]

JabariBooker commented on a change in pull request #12014:
URL: https://github.com/apache/arrow/pull/12014#discussion_r797114295



##########
File path: dev/archery/archery/integration/tester_cpp.py
##########
@@ -60,6 +60,10 @@ def _run(self, arrow_path=None, json_path=None, command='VALIDATE',
         if quirks:
             if "no_decimal_validate" in quirks:
                 cmd.append("--validate_decimals=false")
+            if "no_date64_validate" in quirks:
+                cmd.append("--validate_date64=false")
+            if "no_times_validate" in quirks:
+                cmd.append("--validate_times=false")

Review comment:
       There were 3 golden files that had invalid times resulting failure in the integration tests. So not all of them. However I think that all files did had invalid date64 value.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org