You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/05/07 16:44:33 UTC

[GitHub] [pulsar] Persi commented on a change in pull request #6905: [Issue #6842] feat(schema): allow for schema reader and writer registration on SchemaDefinition

Persi commented on a change in pull request #6905:
URL: https://github.com/apache/pulsar/pull/6905#discussion_r421645548



##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/SchemaDefinitionBuilderImpl.java
##########
@@ -114,6 +120,18 @@
         return this;
     }
 
+    @Override
+    public SchemaDefinitionBuilder<T> withSchemaReader(SchemaReader<T> reader) {
+        this.reader=reader;
+        return null;

Review comment:
       Welll ... obviously I meant that ... you should never do two things at once ...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org