[GitHub] beliefer commented on a change in pull request #23650: [SPARK-26728]Make rdd.unpersist blocking configurable

[GitBox <gi...@apache.org>]

beliefer commented on a change in pull request #23650: [SPARK-26728]Make rdd.unpersist blocking configurable
URL: https://github.com/apache/spark/pull/23650#discussion_r251297717
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/rdd/RDD.scala
 ##########
 @@ -209,13 +210,14 @@ abstract class RDD[T: ClassTag](
    */
   def cache(): this.type = persist()
 
+  private val unpersistBlocking = conf.get(RDD_UNPERSIST_BLOCKING)
   /**
    * Mark the RDD as non-persistent, and remove all blocks for it from memory and disk.
    *
    * @param blocking Whether to block until all blocks are deleted.
    * @return This RDD.
    */
-  def unpersist(blocking: Boolean = true): this.type = {
+  def unpersist(blocking: Boolean = unpersistBlocking): this.type = {
 
 Review comment:
   Maybe this pr is a temp solution for how to avoid RPC issue. There are unable to prove the the measure is effective before a lot of discussion about the blocking of unpersist in detail. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org