[PR] [CELEBORN-1965] Rely on all default hadoop providers for S3 auth [celeborn]

["ashangit (via GitHub)" <gi...@apache.org>]

ashangit opened a new pull request, #3243:
URL: https://github.com/apache/celeborn/pull/3243

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     - Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
     - Be sure to keep the PR description updated to reflect all changes.
     - Please write your PR title to summarize what this PR proposes.
     - If possible, provide a concise example to reproduce the issue for a faster review.
   -->
   
   ### What changes were proposed in this pull request?
   
   Support all [default hadoop provider](https://github.com/apache/hadoop/blob/rel/release-3.3.6/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AUtils.java#L563) for S3 authentication
   
   ### Why are the changes needed?
   
   As of now celeborn only support authentication based on ACESS/SECRET key while other authentication mechanism can be required (for ex. ENV var, relying on [AWS_CONTAINER_CREDENTIALS_RELATIVE_URI](https://docs.aws.amazon.com/sdkref/latest/guide/feature-container-credentials.html))
   
   ### Does this PR introduce _any_ user-facing change?
   
   yes, the `celeborn.storage.s3.secret.key` and `celeborn.storage.s3.access.key` are removed. In order to still provide those we should rely on the hadoop config (`celeborn.hadoop.fs.s3a.access.key` / `celeborn.hadoop.fs.s3a.secret.key `)
   
   ### How was this patch tested?
   
   Tested on celeborn cluster deployed on kubernetes and configured to use S3 relying on `IAMInstanceCredentialsProvider`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1965] Rely on all default hadoop providers for S3 auth [celeborn]

["FMX (via GitHub)" <gi...@apache.org>]

FMX commented on code in PR #3243:
URL: https://github.com/apache/celeborn/pull/3243#discussion_r2078781996


##########
worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/TierWriterHelper.java:
##########
@@ -17,29 +17,24 @@
 
 package org.apache.celeborn.service.deploy.worker.storage;
 
+import org.apache.hadoop.conf.Configuration;
+
 import org.apache.celeborn.reflect.DynConstructors;
 import org.apache.celeborn.server.common.service.mpu.MultipartUploadHandler;
 
 public class TierWriterHelper {
   public static MultipartUploadHandler getS3MultipartUploadHandler(
-      String bucketName,
-      String s3AccessKey,
-      String s3SecretKey,
-      String s3EndpointRegion,
-      String key,
-      int maxRetryies) {
+      Configuration conf, String bucketName, String key, int maxRetryies) {
     return (MultipartUploadHandler)
         DynConstructors.builder()
             .impl(
                 "org.apache.celeborn.S3MultipartUploadHandler",
-                String.class,
-                String.class,
-                String.class,
+                Configuration.class,

Review Comment:
   Pass the Hadoop file system instance here, and you won't need to modify the worker's pom file.



##########
worker/pom.xml:
##########
@@ -143,6 +143,42 @@
   </build>
 
   <profiles>
+
+    <profile>

Review Comment:
   Looks like these changes are not necessary.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1965] Rely on all default hadoop providers for S3 auth [celeborn]

["FMX (via GitHub)" <gi...@apache.org>]

FMX closed pull request #3243: [CELEBORN-1965] Rely on all default hadoop providers for S3 auth
URL: https://github.com/apache/celeborn/pull/3243


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org