You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2023/05/17 13:18:54 UTC

[GitHub] [arrow-adbc] lidavidm commented on a diff in pull request #686: feat(format): add AdbcStatementExecuteSchema

lidavidm commented on code in PR #686:
URL: https://github.com/apache/arrow-adbc/pull/686#discussion_r1196507165


##########
go/adbc/adbc.go:
##########
@@ -536,3 +536,16 @@ type Statement interface {
 	// an error with a StatusNotImplemented code.
 	ExecutePartitions(context.Context) (*arrow.Schema, Partitions, int64, error)
 }
+
+// Statement110 is an extension interface for methods added to Statement in
+// ADBC API revision 1.1.0.
+type Statement110 interface {
+	Statement
+
+	// ExecuteSchema returns the schema of the result set of a query without
+	// executing it.
+	//
+	// If the driver does not support this, this will return an error with a
+	// StatusNotImplemented code.
+	ExecuteSchema(context.Context) (*arrow.Schema, error)
+}

Review Comment:
   @zeroshade for this sort of thing, would it make more sense to actually add a new package so we could just name this `Statement` and re-export all the types?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org