You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by ji...@codehaus.org on 2004/06/25 22:25:33 UTC

[jira] Created: (MPEAR-17) plugin could generate more elements in application.xml

Message:

  A new issue has been created in JIRA.

---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MPEAR-17

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPEAR-17
    Summary: plugin could generate more elements in application.xml
       Type: Improvement

     Status: Unassigned
   Priority: Minor

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven-ear-plugin

   Assignee: 
   Reporter: Charles Crouch

    Created: Fri, 25 Jun 2004 4:25 PM
    Updated: Fri, 25 Jun 2004 4:25 PM
Environment: maven-ear-plugin-1.5, maven-1.0-rc3, windows XP SP1

Description:
The EAR plugin can generate an application.xml containing display-name and module elements but it lacks several others, i.e.

1) application/description
2) application/security-role/role-name

The changes described below are quite small and enable the creation of the above elements by specifying more properties, e.g.

1) maven.ear.appxml.description=Product ${pom.groupId}, version ${pom.currentVersion}
2) maven.ear.appxml.securityRoles=UserRole, AdminRole

The changes to the plugin.jelly, positioned correctly, would be:

1)     <j:set var="applicationDescription" value="${maven.ear.appxml.description}"/>
	<j:if test="${!empty(applicationDescription)}">
	   <x:element name="description">${maven.ear.appxml.description}</x:element>
        </j:if >
     
2)       <j:set var="securityRoles" value="${maven.ear.appxml.securityRoles}"/>
	 <j:if test="${!empty(securityRoles)}">
	 	<util:tokenize var="roles" delim="," trim="true">${maven.ear.appxml.securityRoles}</util:tokenize>
	 	<j:forEach var="role" items="${roles}">
	 		<x:element name="security-role">
	 			<x:element name="role-name">${role.trim()}</x:element>
	                 </x:element>
	 	</j:forEach>
	 </j:if > 
   


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MPEAR-17) plugin could generate more elements in application.xml

Posted by ji...@codehaus.org.
The following comment has been added to this issue:

     Author: Morten Kristiansen
    Created: Wed, 26 Jan 2005 3:45 PM
       Body:
We have solved this differently in our project:

We develop our application in WSAD for deployment on WAS, using J2EE security (hence security roles in application.xml). I think the connection between the standard application.xml and the WAS' vendor specific .xmi files are rather tight, so only generating the security roles might not work (because of numeric id reference between the files, generated in IDE).

Our solution is that we override the standard goal in EAR plugin that generates application.xml and copy security roles from the original application.xml file (if it exist and contains security roles of course).

I'll be glad to submit a patch if you're interessted.
---------------------------------------------------------------------
View this comment:
  http://jira.codehaus.org/browse/MPEAR-17?page=comments#action_29309

---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MPEAR-17

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPEAR-17
    Summary: plugin could generate more elements in application.xml
       Type: Improvement

     Status: Unassigned
   Priority: Minor

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven-ear-plugin

   Assignee: 
   Reporter: Charles Crouch

    Created: Fri, 25 Jun 2004 4:25 PM
    Updated: Wed, 26 Jan 2005 3:45 PM
Environment: maven-ear-plugin-1.5, maven-1.0-rc3, windows XP SP1

Description:
The EAR plugin can generate an application.xml containing display-name and module elements but it lacks several others, i.e.

1) application/description
2) application/security-role/role-name

The changes described below are quite small and enable the creation of the above elements by specifying more properties, e.g.

1) maven.ear.appxml.description=Product ${pom.groupId}, version ${pom.currentVersion}
2) maven.ear.appxml.securityRoles=UserRole, AdminRole

The changes to the plugin.jelly, positioned correctly, would be:

1)     <j:set var="applicationDescription" value="${maven.ear.appxml.description}"/>
	<j:if test="${!empty(applicationDescription)}">
	   <x:element name="description">${maven.ear.appxml.description}</x:element>
        </j:if >
     
2)       <j:set var="securityRoles" value="${maven.ear.appxml.securityRoles}"/>
	 <j:if test="${!empty(securityRoles)}">
	 	<util:tokenize var="roles" delim="," trim="true">${maven.ear.appxml.securityRoles}</util:tokenize>
	 	<j:forEach var="role" items="${roles}">
	 		<x:element name="security-role">
	 			<x:element name="role-name">${role.trim()}</x:element>
	                 </x:element>
	 	</j:forEach>
	 </j:if > 
   


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MPEAR-17) plugin could generate more elements in application.xml

Posted by ji...@codehaus.org.
The following comment has been added to this issue:

     Author: dion gillard
    Created: Sat, 26 Jun 2004 3:38 AM
       Body:
It'd be better if this was a patch.

Also,
- documentation for the new properties and how they're used
- updated test case to check the new properties are being processed correctly

would really help
---------------------------------------------------------------------
View this comment:
  http://jira.codehaus.org/browse/MPEAR-17?page=comments#action_21053

---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MPEAR-17

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPEAR-17
    Summary: plugin could generate more elements in application.xml
       Type: Improvement

     Status: Unassigned
   Priority: Minor

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven-ear-plugin

   Assignee: 
   Reporter: Charles Crouch

    Created: Fri, 25 Jun 2004 4:25 PM
    Updated: Sat, 26 Jun 2004 3:38 AM
Environment: maven-ear-plugin-1.5, maven-1.0-rc3, windows XP SP1

Description:
The EAR plugin can generate an application.xml containing display-name and module elements but it lacks several others, i.e.

1) application/description
2) application/security-role/role-name

The changes described below are quite small and enable the creation of the above elements by specifying more properties, e.g.

1) maven.ear.appxml.description=Product ${pom.groupId}, version ${pom.currentVersion}
2) maven.ear.appxml.securityRoles=UserRole, AdminRole

The changes to the plugin.jelly, positioned correctly, would be:

1)     <j:set var="applicationDescription" value="${maven.ear.appxml.description}"/>
	<j:if test="${!empty(applicationDescription)}">
	   <x:element name="description">${maven.ear.appxml.description}</x:element>
        </j:if >
     
2)       <j:set var="securityRoles" value="${maven.ear.appxml.securityRoles}"/>
	 <j:if test="${!empty(securityRoles)}">
	 	<util:tokenize var="roles" delim="," trim="true">${maven.ear.appxml.securityRoles}</util:tokenize>
	 	<j:forEach var="role" items="${roles}">
	 		<x:element name="security-role">
	 			<x:element name="role-name">${role.trim()}</x:element>
	                 </x:element>
	 	</j:forEach>
	 </j:if > 
   


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MPEAR-17) plugin could generate more elements in application.xml

Posted by ji...@codehaus.org.
The following comment has been added to this issue:

     Author: Felipe Leme
    Created: Tue, 16 Nov 2004 2:14 PM
       Body:
Charles,

Your patch seems to be fine, but as dIon commented, we need the documentation and test cases too (if you don't provide these, we need to create them by ourselves, which in turns delays fixing this issue). 

The documentation is pretty easy: you just need to udpate the xdocs/properties.xml file (you can also change project.xml to add yourself as contributor and xdocs/changes.xml with this issue, if you prefer). The testcase is a little bit trickier, so here is a sample script:

1.Create the directory src/plugin-tests/test06. I will refer to this directory as the testcase directory
2.Add a new project.properties  on the new directory contain the common properties for all testcases (in this case, I would say maven.ear.appxml.generate=true)
3.Copy the project.xml from another testcase (for instance, test05) and change the proper settings (testcase description, your info, etc...)
4.Then you need to create the maven.xml with the testcase. In this case, I would suggest 4 testcases, 2 for each new propertie: 1 for the case where the property is set; 1 for the case where it is not. A good example on how to create multiple tests in just one maven.xml is the testcase for the hibernate plugin
5.Regarding the tests themself, they consist of generating the EAR, extracting the application.xml and verifying that the expected elements are there (using XPath).

If you have any more doubts, please let us know (through this issue).

-- Felipe

PS: please provide a new patch with everything then
---------------------------------------------------------------------
View this comment:
  http://jira.codehaus.org/browse/MPEAR-17?page=comments#action_26486

---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MPEAR-17

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPEAR-17
    Summary: plugin could generate more elements in application.xml
       Type: Improvement

     Status: Unassigned
   Priority: Minor

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven-ear-plugin

   Assignee: 
   Reporter: Charles Crouch

    Created: Fri, 25 Jun 2004 4:25 PM
    Updated: Tue, 16 Nov 2004 2:14 PM
Environment: maven-ear-plugin-1.5, maven-1.0-rc3, windows XP SP1

Description:
The EAR plugin can generate an application.xml containing display-name and module elements but it lacks several others, i.e.

1) application/description
2) application/security-role/role-name

The changes described below are quite small and enable the creation of the above elements by specifying more properties, e.g.

1) maven.ear.appxml.description=Product ${pom.groupId}, version ${pom.currentVersion}
2) maven.ear.appxml.securityRoles=UserRole, AdminRole

The changes to the plugin.jelly, positioned correctly, would be:

1)     <j:set var="applicationDescription" value="${maven.ear.appxml.description}"/>
	<j:if test="${!empty(applicationDescription)}">
	   <x:element name="description">${maven.ear.appxml.description}</x:element>
        </j:if >
     
2)       <j:set var="securityRoles" value="${maven.ear.appxml.securityRoles}"/>
	 <j:if test="${!empty(securityRoles)}">
	 	<util:tokenize var="roles" delim="," trim="true">${maven.ear.appxml.securityRoles}</util:tokenize>
	 	<j:forEach var="role" items="${roles}">
	 		<x:element name="security-role">
	 			<x:element name="role-name">${role.trim()}</x:element>
	                 </x:element>
	 	</j:forEach>
	 </j:if > 
   


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MPEAR-17) plugin could generate more elements in application.xml

Posted by ji...@codehaus.org.
The following issue has been updated:

    Updater: Charles Crouch (mailto:eeouhki02@sneakemail.com)
       Date: Tue, 29 Jun 2004 11:43 AM
    Comment:
Changes to plugin.jelly as a patch
    Changes:
             Attachment changed to plugin.jelly.patch
    ---------------------------------------------------------------------
For a full history of the issue, see:

  http://jira.codehaus.org/browse/MPEAR-17?page=history

---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MPEAR-17

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPEAR-17
    Summary: plugin could generate more elements in application.xml
       Type: Improvement

     Status: Unassigned
   Priority: Minor

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven-ear-plugin

   Assignee: 
   Reporter: Charles Crouch

    Created: Fri, 25 Jun 2004 4:25 PM
    Updated: Tue, 29 Jun 2004 11:43 AM
Environment: maven-ear-plugin-1.5, maven-1.0-rc3, windows XP SP1

Description:
The EAR plugin can generate an application.xml containing display-name and module elements but it lacks several others, i.e.

1) application/description
2) application/security-role/role-name

The changes described below are quite small and enable the creation of the above elements by specifying more properties, e.g.

1) maven.ear.appxml.description=Product ${pom.groupId}, version ${pom.currentVersion}
2) maven.ear.appxml.securityRoles=UserRole, AdminRole

The changes to the plugin.jelly, positioned correctly, would be:

1)     <j:set var="applicationDescription" value="${maven.ear.appxml.description}"/>
	<j:if test="${!empty(applicationDescription)}">
	   <x:element name="description">${maven.ear.appxml.description}</x:element>
        </j:if >
     
2)       <j:set var="securityRoles" value="${maven.ear.appxml.securityRoles}"/>
	 <j:if test="${!empty(securityRoles)}">
	 	<util:tokenize var="roles" delim="," trim="true">${maven.ear.appxml.securityRoles}</util:tokenize>
	 	<j:forEach var="role" items="${roles}">
	 		<x:element name="security-role">
	 			<x:element name="role-name">${role.trim()}</x:element>
	                 </x:element>
	 	</j:forEach>
	 </j:if > 
   


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MPEAR-17) plugin could generate more elements in application.xml

Posted by "Martijn de Bruijn (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MPEAR-17?page=comments#action_51204 ] 

Martijn de Bruijn commented on MPEAR-17:
----------------------------------------

Morten,
I've got the same problem with the binding between the WSAD application.xml extentions and the application.xml generated by Maven.
Could you submit your patch? Maybee I an use it to solve my problem.
I think the securoty roles should be configurable for the ear plugin. Something like:
<plugin>
	<groupId>org.apache.maven.plugins</groupId>
	<artifactId>maven-ear-plugin</artifactId>
	<configuration>
		<security>
			<security-role id="SecurityRole_1131964323008">
				<description></description>
				<role-name>manager</role-name>
			</security-role>
			<security-role id="SecurityRole_1131964323018">
				<description></description>
				<role-name>teller</role-name>
			</security-role>
		</security>	
	</configuration>
</plugin>

Thanks.

Martijn de Bruijn

> plugin could generate more elements in application.xml
> ------------------------------------------------------
>
>          Key: MPEAR-17
>          URL: http://jira.codehaus.org/browse/MPEAR-17
>      Project: maven-ear-plugin
>         Type: Improvement
>  Environment: maven-ear-plugin-1.5, maven-1.0-rc3, windows XP SP1
>     Reporter: Charles Crouch
>     Priority: Minor
>  Attachments: plugin.jelly, plugin.jelly.patch
>
>
> The EAR plugin can generate an application.xml containing display-name and module elements but it lacks several others, i.e.
> 1) application/description
> 2) application/security-role/role-name
> The changes described below are quite small and enable the creation of the above elements by specifying more properties, e.g.
> 1) maven.ear.appxml.description=Product ${pom.groupId}, version ${pom.currentVersion}
> 2) maven.ear.appxml.securityRoles=UserRole, AdminRole
> The changes to the plugin.jelly, positioned correctly, would be:
> 1)     <j:set var="applicationDescription" value="${maven.ear.appxml.description}"/>
> 	<j:if test="${!empty(applicationDescription)}">
> 	   <x:element name="description">${maven.ear.appxml.description}</x:element>
>         </j:if >
>      
> 2)       <j:set var="securityRoles" value="${maven.ear.appxml.securityRoles}"/>
> 	 <j:if test="${!empty(securityRoles)}">
> 	 	<util:tokenize var="roles" delim="," trim="true">${maven.ear.appxml.securityRoles}</util:tokenize>
> 	 	<j:forEach var="role" items="${roles}">
> 	 		<x:element name="security-role">
> 	 			<x:element name="role-name">${role.trim()}</x:element>
> 	                 </x:element>
> 	 	</j:forEach>
> 	 </j:if >

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MPEAR-17) plugin could generate more elements in application.xml

Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MPEAR-17?page=all ]

Stephane Nicoll updated MPEAR-17:
---------------------------------

    Fix Version: 1.9

> plugin could generate more elements in application.xml
> ------------------------------------------------------
>
>          Key: MPEAR-17
>          URL: http://jira.codehaus.org/browse/MPEAR-17
>      Project: maven-ear-plugin
>         Type: Improvement

>  Environment: maven-ear-plugin-1.5, maven-1.0-rc3, windows XP SP1
>     Reporter: Charles Crouch
>     Priority: Minor
>      Fix For: 1.9
>  Attachments: plugin.jelly, plugin.jelly.patch
>
>
> The EAR plugin can generate an application.xml containing display-name and module elements but it lacks several others, i.e.
> 1) application/description
> 2) application/security-role/role-name
> The changes described below are quite small and enable the creation of the above elements by specifying more properties, e.g.
> 1) maven.ear.appxml.description=Product ${pom.groupId}, version ${pom.currentVersion}
> 2) maven.ear.appxml.securityRoles=UserRole, AdminRole
> The changes to the plugin.jelly, positioned correctly, would be:
> 1)     <j:set var="applicationDescription" value="${maven.ear.appxml.description}"/>
> 	<j:if test="${!empty(applicationDescription)}">
> 	   <x:element name="description">${maven.ear.appxml.description}</x:element>
>         </j:if >
>      
> 2)       <j:set var="securityRoles" value="${maven.ear.appxml.securityRoles}"/>
> 	 <j:if test="${!empty(securityRoles)}">
> 	 	<util:tokenize var="roles" delim="," trim="true">${maven.ear.appxml.securityRoles}</util:tokenize>
> 	 	<j:forEach var="role" items="${roles}">
> 	 		<x:element name="security-role">
> 	 			<x:element name="role-name">${role.trim()}</x:element>
> 	                 </x:element>
> 	 	</j:forEach>
> 	 </j:if >

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MPEAR-17) plugin could generate more elements in application.xml

Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MPEAR-17?page=comments#action_51207 ] 

Stephane Nicoll commented on MPEAR-17:
--------------------------------------

Martijn,

This project is for the maven 1 EAR plugin, not maven2. Please file an issue in the MNG project (maven-ear-plugin component).

Thanks.

> plugin could generate more elements in application.xml
> ------------------------------------------------------
>
>          Key: MPEAR-17
>          URL: http://jira.codehaus.org/browse/MPEAR-17
>      Project: maven-ear-plugin
>         Type: Improvement
>  Environment: maven-ear-plugin-1.5, maven-1.0-rc3, windows XP SP1
>     Reporter: Charles Crouch
>     Priority: Minor
>  Attachments: plugin.jelly, plugin.jelly.patch
>
>
> The EAR plugin can generate an application.xml containing display-name and module elements but it lacks several others, i.e.
> 1) application/description
> 2) application/security-role/role-name
> The changes described below are quite small and enable the creation of the above elements by specifying more properties, e.g.
> 1) maven.ear.appxml.description=Product ${pom.groupId}, version ${pom.currentVersion}
> 2) maven.ear.appxml.securityRoles=UserRole, AdminRole
> The changes to the plugin.jelly, positioned correctly, would be:
> 1)     <j:set var="applicationDescription" value="${maven.ear.appxml.description}"/>
> 	<j:if test="${!empty(applicationDescription)}">
> 	   <x:element name="description">${maven.ear.appxml.description}</x:element>
>         </j:if >
>      
> 2)       <j:set var="securityRoles" value="${maven.ear.appxml.securityRoles}"/>
> 	 <j:if test="${!empty(securityRoles)}">
> 	 	<util:tokenize var="roles" delim="," trim="true">${maven.ear.appxml.securityRoles}</util:tokenize>
> 	 	<j:forEach var="role" items="${roles}">
> 	 		<x:element name="security-role">
> 	 			<x:element name="role-name">${role.trim()}</x:element>
> 	                 </x:element>
> 	 	</j:forEach>
> 	 </j:if >

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MPEAR-17) plugin could generate more elements in application.xml

Posted by ji...@codehaus.org.
The following issue has been updated:

    Updater: Charles Crouch (mailto:eeouhki02@sneakemail.com)
       Date: Fri, 25 Jun 2004 4:26 PM
    Comment:
Attached is a plugin.jelly with the changes included in the correct places
    Changes:
             Attachment changed to plugin.jelly
    ---------------------------------------------------------------------
For a full history of the issue, see:

  http://jira.codehaus.org/browse/MPEAR-17?page=history

---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MPEAR-17

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPEAR-17
    Summary: plugin could generate more elements in application.xml
       Type: Improvement

     Status: Unassigned
   Priority: Minor

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven-ear-plugin

   Assignee: 
   Reporter: Charles Crouch

    Created: Fri, 25 Jun 2004 4:25 PM
    Updated: Fri, 25 Jun 2004 4:26 PM
Environment: maven-ear-plugin-1.5, maven-1.0-rc3, windows XP SP1

Description:
The EAR plugin can generate an application.xml containing display-name and module elements but it lacks several others, i.e.

1) application/description
2) application/security-role/role-name

The changes described below are quite small and enable the creation of the above elements by specifying more properties, e.g.

1) maven.ear.appxml.description=Product ${pom.groupId}, version ${pom.currentVersion}
2) maven.ear.appxml.securityRoles=UserRole, AdminRole

The changes to the plugin.jelly, positioned correctly, would be:

1)     <j:set var="applicationDescription" value="${maven.ear.appxml.description}"/>
	<j:if test="${!empty(applicationDescription)}">
	   <x:element name="description">${maven.ear.appxml.description}</x:element>
        </j:if >
     
2)       <j:set var="securityRoles" value="${maven.ear.appxml.securityRoles}"/>
	 <j:if test="${!empty(securityRoles)}">
	 	<util:tokenize var="roles" delim="," trim="true">${maven.ear.appxml.securityRoles}</util:tokenize>
	 	<j:forEach var="role" items="${roles}">
	 		<x:element name="security-role">
	 			<x:element name="role-name">${role.trim()}</x:element>
	                 </x:element>
	 	</j:forEach>
	 </j:if > 
   


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org