You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/11/11 13:30:46 UTC
[GitHub] [maven-integration-testing] slawekjaranowski opened a new pull request, #211: Fix flappy test - mng-6720-fail-fast
slawekjaranowski opened a new pull request, #211:
URL: https://github.com/apache/maven-integration-testing/pull/211
- old m-resource-p can fail in multi thread executions
- test project use aggregation - so we need provided configuration in each module
- replace deprecated method
- add message for assertions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] michael-o commented on a diff in pull request #211: Fix flappy test - mng-6720-fail-fast
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #211:
URL: https://github.com/apache/maven-integration-testing/pull/211#discussion_r1021258792
##########
core-it-suite/src/test/resources/mng-6720-fail-fast/pom.xml:
##########
@@ -35,15 +35,4 @@ under the License.
<module>module-3</module>
</modules>
- <build>
- <pluginManagement>
- <plugins>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-resources-plugin</artifactId>
- <version>3.2.0</version>
- </plugin>
- </plugins>
- </pluginManagement>
- </build>
Review Comment:
Ah, yes. Make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] michael-o commented on a diff in pull request #211: Fix flappy test - mng-6720-fail-fast
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #211:
URL: https://github.com/apache/maven-integration-testing/pull/211#discussion_r1021223185
##########
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6720FailFastTest.java:
##########
@@ -36,7 +34,7 @@
* <a href="https://issues.apache.org/jira/browse/MNG-6720">MNG-6720</a>.
*
*/
-public class MavenITmng6720FailFastTest
+class MavenITmng6720FailFastTest
Review Comment:
Is the rest of our tests also package private?
##########
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6720FailFastTest.java:
##########
@@ -46,35 +44,34 @@ public MavenITmng6720FailFastTest()
}
@Test
- public void testItShouldWaitForConcurrentModulesToFinish()
+ void testItShouldWaitForConcurrentModulesToFinish()
throws Exception
{
File testDir = ResourceExtractor.simpleExtractResources( getClass(), "/mng-6720-fail-fast" );
Verifier verifier = newVerifier( testDir.getAbsolutePath(), false );
- verifier.setMavenDebug( false );
verifier.setAutoclean( false );
- verifier.addCliOption( "-T" );
- verifier.addCliOption( "2" );
- verifier.addCliOption( "-Dmaven.test.redirectTestOutputToFile=true" );
+ verifier.addCliArguments( "-T", "2" );
+ verifier.addCliArgument( "-Dmaven.test.redirectTestOutputToFile=true" );
+ verifier.addCliArguments( "clean", "test" );
Review Comment:
Beautiful, this new API :-D
##########
core-it-suite/src/test/resources/mng-6720-fail-fast/pom.xml:
##########
@@ -35,15 +35,4 @@ under the License.
<module>module-3</module>
</modules>
- <build>
- <pluginManagement>
- <plugins>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-resources-plugin</artifactId>
- <version>3.2.0</version>
- </plugin>
- </plugins>
- </pluginManagement>
- </build>
Review Comment:
Why not use plugin management in the part for those?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] slawekjaranowski commented on a diff in pull request #211: Fix flappy test - mng-6720-fail-fast
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #211:
URL: https://github.com/apache/maven-integration-testing/pull/211#discussion_r1021250320
##########
core-it-suite/src/test/resources/mng-6720-fail-fast/pom.xml:
##########
@@ -35,15 +35,4 @@ under the License.
<module>module-3</module>
</modules>
- <build>
- <pluginManagement>
- <plugins>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-resources-plugin</artifactId>
- <version>3.2.0</version>
- </plugin>
- </plugins>
- </pluginManagement>
- </build>
Review Comment:
because project use aggregation and child poms don't have defined parent - it is main reason for change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] slawekjaranowski commented on a diff in pull request #211: Fix flappy test - mng-6720-fail-fast
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #211:
URL: https://github.com/apache/maven-integration-testing/pull/211#discussion_r1021247827
##########
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6720FailFastTest.java:
##########
@@ -36,7 +34,7 @@
* <a href="https://issues.apache.org/jira/browse/MNG-6720">MNG-6720</a>.
*
*/
-public class MavenITmng6720FailFastTest
+class MavenITmng6720FailFastTest
Review Comment:
No yet, it is Junit5 convention ,so step by step
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] slawekjaranowski commented on pull request #211: Fix flappy test - mng-6720-fail-fast
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #211:
URL: https://github.com/apache/maven-integration-testing/pull/211#issuecomment-1312446964
example stack trace:
```
Caused by: org.apache.maven.plugin.PluginExecutionException:
Execution default-resources of goal org.apache.maven.plugins:maven-resources-plugin:2.6:resources failed.
...
Caused by: java.util.ConcurrentModificationException
at java.util.Hashtable$Enumerator.next (Hashtable.java:1387)
at java.util.Hashtable.putAll (Hashtable.java:523)
at org.apache.maven.shared.filtering.DefaultMavenFileFilter.getDefaultFilterWrappers (DefaultMavenFileFilter.java:198)
at org.apache.maven.shared.filtering.DefaultMavenResourcesFiltering.filterResources (DefaultMavenResourcesFiltering.java:161)
at org.apache.maven.plugin.resources.ResourcesMojo.execute (ResourcesMojo.java:301)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] slawekjaranowski merged pull request #211: Fix flappy test - mng-6720-fail-fast
Posted by GitBox <gi...@apache.org>.
slawekjaranowski merged PR #211:
URL: https://github.com/apache/maven-integration-testing/pull/211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org