[GitHub] paul-rogers commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework

[GitBox <gi...@apache.org>]

paul-rogers commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework
URL: https://github.com/apache/drill/pull/1618#discussion_r259596849
 
 

 ##########
 File path: exec/java-exec/src/test/java/org/apache/drill/exec/physical/rowSet/impl/RowSetTestUtils.java
 ##########
 @@ -30,11 +29,9 @@ private RowSetTestUtils() { }
 
   public static List<SchemaPath> projectList(String... names) {
     List<SchemaPath> selected = new ArrayList<>();
-    for (String name: names) {
-
-      // Parse from string does not handle wildcards.
-
-      if (name.equals(SchemaPath.DYNAMIC_STAR)) {
+    for (String name : names) {
+      if (name.equals(SchemaPath.DYNAMIC_STAR) ||
+          name.equals("*")) {
 
 Review comment:
   Checked the code. Seems the tests in this area all use the DYNAMIC_STAR constant, so I was able to remove this check.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services