You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by "paulirwin (via GitHub)" <gi...@apache.org> on 2026/06/12 17:07:40 UTC

[I] Finish porting Sandbox queries: Regex and SlowCollated [lucenenet]

paulirwin opened a new issue, #1341:
URL: https://github.com/apache/lucenenet/issues/1341

   ### Is there an existing issue for this?
   
   - [x] I have searched the existing issues
   
   ### Is your feature request related to a problem? Please describe the problem.
   
   I analyzed the gaps reported by the API check tool (#1022), and there were just two things that were not ported from Lucene 4.8.1, both in the Sandbox project:
   
   1. RegexQuery and related-types in `sandbox/queries/regex`
   2. SlowCollated types in `sandbox/queries`
   
   Funnily enough, I searched git history, and it turns out _I_ had ported these for the `branch_4x` work for the original 4.3 port work, 13 years ago: https://github.com/apache/lucenenet/tree/branch_4x/src/contrib/Sandbox/Queries
   
   So this work must have gotten lost in the 4.8 port work, or maybe was unable to be ported due to some unknown reason at the time.
   
   This is the only remaining feature gap of unported work for 4.8.1.
   
   ### Describe the solution you'd like
   
   The types and their tests are ported.
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Finish porting Sandbox queries: Regex and SlowCollated [lucenenet]

Posted by "paulirwin (via GitHub)" <gi...@apache.org>.
paulirwin commented on issue #1341:
URL: https://github.com/apache/lucenenet/issues/1341#issuecomment-4693548250

   Sorry for the back-to-back comments, but I missed this in the SlowCollated types: `Index collation keys with CollationKeyAnalyzer or ICUCollationKeyAnalyzer instead. This class will be removed in Lucene 5.0`
   
   Updating this issue to note that we should suppress this difference in the API check tool instead, as well as document why we didn't port these types.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Finish porting Sandbox queries: Regex and SlowCollated [lucenenet]

Posted by "paulirwin (via GitHub)" <gi...@apache.org>.
paulirwin commented on issue #1341:
URL: https://github.com/apache/lucenenet/issues/1341#issuecomment-4693524128

   Note that RegexQuery was effectively replaced by RegexpQuery, so if we determine that the sandbox version doesn't need to be ported, then we should at least put a note there in the package documentation about why this wasn't ported. Possibly also putting empty C# files with a comment explaining why it doesn't exist.
   
   Likewise for SlowCollated: if there is a good reason why these weren't ported, let's also document it and put in placeholder files.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Document/Suppress missing sandbox queries: Regex and SlowCollated [lucenenet]

Posted by "NightOwl888 (via GitHub)" <gi...@apache.org>.
NightOwl888 commented on issue #1341:
URL: https://github.com/apache/lucenenet/issues/1341#issuecomment-4693946634

   > I analyzed the gaps reported by the API check tool (https://github.com/apache/lucenenet/issues/1022), and there were just two things that were not ported from Lucene 4.8.1, both in the Sandbox project:
   >
   > RegexQuery and related-types in sandbox/queries/regex
   > SlowCollated types in sandbox/queries
   
   Okay, I think there must still be some kinks to work out with the comparison tool, then.
   
   1. The Misc project has [native .cpp files (native Directory implementations)](https://github.com/apache/lucene/tree/releases/lucene-solr/4.8.1/lucene/misc/src/java/org/apache/lucene/store) that were not ported. Okay, maybe it is asking a bit much for the comparison tool to expect this.
   2. Lucene.Net.Analysis.Common is missing the [Collation functionality](https://github.com/apache/lucenenet/tree/80b2a66f74f15f5596a2e2a03078038269cf87d1/src/Lucene.Net.Analysis.Common/Collation). It probably isn't much work. .NET's collator is called [`CompareInfo`](https://learn.microsoft.com/en-us/dotnet/api/system.globalization.compareinfo?view=net-10.0). The Lucene docs say that the ICU4J collator is faster than the JDK, but I suspect that in the BCL implementation will be faster than the one in ICU4N in most cases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Document/Suppress missing sandbox queries: Regex and SlowCollated [lucenenet]

Posted by "paulirwin (via GitHub)" <gi...@apache.org>.
paulirwin commented on issue #1341:
URL: https://github.com/apache/lucenenet/issues/1341#issuecomment-4695464496

   I split out those two above as #1342 and #1343. They weren't found as deltas because the AI agent that I had thoroughly reviewing every finding in the API tool output report was comparing to C# files on disk, not the reflected types that are actually compiled. Since both of those were partially implemented but excluded from compilation, it didn't detect that.
   
   I re-ran the comparison with focusing on what is actually compiled into the libraries, and it found no other significant porting gaps (just some minor things that we intentionally excluded, like AlreadyClosedException which we made internal, SPI stuff, etc).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Document/Suppress missing sandbox queries: Regex and SlowCollated [lucenenet]

Posted by "tomatotomata (via GitHub)" <gi...@apache.org>.
tomatotomata commented on issue #1341:
URL: https://github.com/apache/lucenenet/issues/1341#issuecomment-5150543704

   I was thinking of keeping this as a narrow documentation and API-check follow-up rather than attempting to revive the deprecated Java types: add a short note in the Sandbox package docs explaining the `RegexpQuery` replacement and the CollationKey alternatives, add placeholder comments only where the project prefers them, and suppress the two intentional API gaps in the comparison tool. I would first trace the existing API-check suppression format and package docs, then add focused coverage for the documented paths. Does that scope fit how you want #1341 handled?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Document/Suppress missing sandbox queries: Regex and SlowCollated [lucenenet]

Posted by "paulirwin (via GitHub)" <gi...@apache.org>.
paulirwin commented on issue #1341:
URL: https://github.com/apache/lucenenet/issues/1341#issuecomment-5151686904

   Thanks, that mostly sounds good! The only thing is the API check isn't merged yet, so that part can wait. Otherwise, you've got it right.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Document/Suppress missing sandbox queries: Regex and SlowCollated [lucenenet]

Posted by "paulirwin (via GitHub)" <gi...@apache.org>.
paulirwin closed issue #1341: Document/Suppress missing sandbox queries: Regex and SlowCollated
URL: https://github.com/apache/lucenenet/issues/1341


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org