You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "wu-sheng (via GitHub)" <gi...@apache.org> on 2023/08/08 14:37:59 UTC

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #11194: Add `view_as_seq` function in MQE for filtering the not empty metrics

wu-sheng commented on code in PR #11194:
URL: https://github.com/apache/skywalking/pull/11194#discussion_r1287223401


##########
oap-server/mqe-grammar/src/main/antlr4/org/apache/skywalking/mqe/rt/grammar/MQEParser.g4:
##########
@@ -33,6 +33,11 @@ expression
     | topN L_PAREN metric COMMA parameter COMMA order R_PAREN  #topNOP
     | relabels L_PAREN expression COMMA label R_PAREN #relablesOP
     | aggregateLabels L_PAREN expression COMMA aggregateLabelsFunc R_PAREN #aggregateLabelsOp
+    | viewAsSeq L_PAREN expressionList R_PAREN #viewAsSeqOp

Review Comment:
   @wankai123 Do we need a kind of function for this? I don't think `viewAsSeq` is so special, as generally, it is just a kind of in-memory logic operations.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org