You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/09/16 08:23:29 UTC
[GitHub] [airflow] francescomucio opened a new pull request #10971: Add configure_environment.sh to ./breeze --start-airflow
francescomucio opened a new pull request #10971:
URL: https://github.com/apache/airflow/pull/10971
With `./breeze --start-airflow` it was not possible to use the dags stored in `files/dags` in the host machine because the AIRFLOW__CORE__DAGS_FOLDER environment variable was not set.
This was because `scripts/in_container/configure_environment.sh` was not executed. I have added a call to that script.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10971: Add configure_environment.sh to ./breeze --start-airflow
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10971:
URL: https://github.com/apache/airflow/pull/10971#issuecomment-693605636
Fixed already by Ash and Kaxil
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #10971: Add configure_environment.sh to ./breeze --start-airflow
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #10971:
URL: https://github.com/apache/airflow/pull/10971
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] francescomucio commented on pull request #10971: Add configure_environment.sh to ./breeze --start-airflow
Posted by GitBox <gi...@apache.org>.
francescomucio commented on pull request #10971:
URL: https://github.com/apache/airflow/pull/10971#issuecomment-693593225
I can create a new PR to fix the formatting, will that be ok?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10971: Add configure_environment.sh to ./breeze --start-airflow
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10971:
URL: https://github.com/apache/airflow/pull/10971#issuecomment-693563324
It did run it but it took some time. That's my fault really - I should have checked. the GA works in the way that until it starts all the checks, the "rebase&squash" button gets "green". This is also when or two checks succeed but the dependent one did not start yet.
So if there are many PRs in the queue and there is a delay in running jobs, the PR looks green even if the checks did not start yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #10971: Add configure_environment.sh to ./breeze --start-airflow
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #10971:
URL: https://github.com/apache/airflow/pull/10971#issuecomment-693402286
@potiuk This didn't run CI for some reason -- so it failed on master (tabs was used for indentation). Could you look at why it didn't run please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] francescomucio commented on pull request #10971: Add configure_environment.sh to ./breeze --start-airflow
Posted by GitBox <gi...@apache.org>.
francescomucio commented on pull request #10971:
URL: https://github.com/apache/airflow/pull/10971#issuecomment-693607615
Oh, great, I didn't notice it. Thanks for fixing my error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] francescomucio commented on pull request #10971: Add configure_environment.sh to ./breeze --start-airflow
Posted by GitBox <gi...@apache.org>.
francescomucio commented on pull request #10971:
URL: https://github.com/apache/airflow/pull/10971#issuecomment-693359700
@mik-laj @potiuk thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10971: Add configure_environment.sh to ./breeze --start-airflow
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10971:
URL: https://github.com/apache/airflow/pull/10971#issuecomment-693567933
Created an inssue in Github Support : https://github.community/t/merge-button-green-with-jobs-not-started-in-github-actions/132604. Some likes are welcome :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #10971: Add configure_environment.sh to ./breeze --start-airflow
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #10971:
URL: https://github.com/apache/airflow/pull/10971#issuecomment-693570580
> It did run it but it took some time. That's my fault really - I should have checked. the GA works in the way that until it starts all the checks, the "rebase&squash" button gets "green". This is also when or two checks succeed but the dependent one did not start yet.
> So if there are many PRs in the queue and there is a delay in running jobs, the PR looks green even if the checks did not start yet.
Oh lovely. Makes sense how it happened now, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb edited a comment on pull request #10971: Add configure_environment.sh to ./breeze --start-airflow
Posted by GitBox <gi...@apache.org>.
ashb edited a comment on pull request #10971:
URL: https://github.com/apache/airflow/pull/10971#issuecomment-693402286
@potiuk This didn't run CI for some reason -- so it failed on master (tabs was used for indentation). Could you look at why it didn't run please? (Or did it run and we merged it with failing tests?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org