You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "mik-laj (via GitHub)" <gi...@apache.org> on 2025/04/07 15:14:52 UTC
[PR] Unify pre-coommit hooks for imports [airflow]
mik-laj opened a new pull request, #48881:
URL: https://github.com/apache/airflow/pull/48881
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Unify pre-coommit hooks for imports [airflow]
Posted by "mik-laj (via GitHub)" <gi...@apache.org>.
mik-laj commented on code in PR #48881:
URL: https://github.com/apache/airflow/pull/48881#discussion_r2035157723
##########
scripts/ci/pre_commit/update_providers_dependencies.py:
##########
@@ -67,38 +67,6 @@
ALL_PROVIDER_FILES: list[Path] = []
-class ImportFinder(NodeVisitor):
Review Comment:
I don't like ast.NodeVisitor. In most cases it can be replaced by `ast.walk` or `ast.iter_child_nodes` and the code is more readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Unify pre-coommit hooks for imports [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #48881:
URL: https://github.com/apache/airflow/pull/48881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Unify pre-coommit hooks for imports [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #48881:
URL: https://github.com/apache/airflow/pull/48881#discussion_r2035275204
##########
.pre-commit-config.yaml:
##########
@@ -424,8 +431,19 @@ repos:
language: python
files: ^airflow-core/src/airflow/.*\.py$
require_serial: true
- exclude: ^providers/.*/src/airflow/providers/
- entry: ./scripts/ci/pre_commit/check_cncf_k8s_used_for_k8s_executor_only.py
+ exclude: >
+ (?x)
+ ^providers/.*/src/airflow/providers/|
+ ^airflow-core/src/airflow/exceptions\.py$|
+ ^airflow-core/src/airflow/exceptions\.py$|
+ ^airflow-core/src/airflow/models/renderedtifields\.py$|
+ ^airflow-core/src/airflow/serialization/serialized_objects\.py$|
+ ^airflow-core/src/airflow/serialization/serialized_objects\.py$|
Review Comment:
Nice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Unify pre-coommit hooks for imports [airflow]
Posted by "mik-laj (via GitHub)" <gi...@apache.org>.
mik-laj commented on code in PR #48881:
URL: https://github.com/apache/airflow/pull/48881#discussion_r2035155295
##########
.pre-commit-config.yaml:
##########
@@ -424,8 +431,19 @@ repos:
language: python
files: ^airflow-core/src/airflow/.*\.py$
require_serial: true
- exclude: ^providers/.*/src/airflow/providers/
- entry: ./scripts/ci/pre_commit/check_cncf_k8s_used_for_k8s_executor_only.py
+ exclude: >
+ (?x)
+ ^providers/.*/src/airflow/providers/|
+ ^airflow-core/src/airflow/exceptions\.py$|
+ ^airflow-core/src/airflow/exceptions\.py$|
+ ^airflow-core/src/airflow/models/renderedtifields\.py$|
+ ^airflow-core/src/airflow/serialization/serialized_objects\.py$|
+ ^airflow-core/src/airflow/serialization/serialized_objects\.py$|
Review Comment:
Previously, we only checked top-level imports. Now we also check imports that are in functions, and "if TYPE_CHECKING" condition protected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org