You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Martin Kočí (Created JIRA)" <de...@myfaces.apache.org> on 2011/12/12 13:08:30 UTC
[jira] [Created] (MYFACES-3418) [perf] do not check for duplicate
ids when saving view on production stage
[perf] do not check for duplicate ids when saving view on production stage
--------------------------------------------------------------------------
Key: MYFACES-3418
URL: https://issues.apache.org/jira/browse/MYFACES-3418
Project: MyFaces Core
Issue Type: New Feature
Environment: myfaces trunk
Reporter: Martin Kočí
Assignee: Martin Kočí
Priority: Minor
see discussion here: http://www.mail-archive.com/dev@myfaces.apache.org/msg52995.html
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MYFACES-3418) [perf] do not check for duplicate
ids when saving view on production stage
Posted by "Martin Kočí (Updated JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Kočí updated MYFACES-3418:
---------------------------------
Status: Patch Available (was: Open)
> [perf] do not check for duplicate ids when saving view on production stage
> --------------------------------------------------------------------------
>
> Key: MYFACES-3418
> URL: https://issues.apache.org/jira/browse/MYFACES-3418
> Project: MyFaces Core
> Issue Type: New Feature
> Environment: myfaces trunk
> Reporter: Martin Kočí
> Assignee: Martin Kočí
> Priority: Minor
> Attachments: MYFACES-3418.patch
>
>
> see discussion here: http://www.mail-archive.com/dev@myfaces.apache.org/msg52995.html
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3418) [perf] do not check for duplicate
ids when saving view on production stage
Posted by "Leonardo Uribe (Commented) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185013#comment-13185013 ]
Leonardo Uribe commented on MYFACES-3418:
-----------------------------------------
Attached final patch. Changed param name to org.apache.myfaces.CHECK_ID_PRODUCTION_MODE with this description:
/**
* Define how duplicate ids are checked when ProjectStage is Production, by default (auto) it only check ids of
* components that does not encapsulate markup (like facelets UILeaf).
*
* <ul>
* <li>true: check all ids, including ids for components that are transient and encapsulate markup.</li>
* <li>auto: (default) check ids of components that does not encapsulate markup (like facelets UILeaf).
* Note ids of UILeaf instances are generated by facelets vdl, start with "j_id", are never rendered
* into the response and UILeaf instances are never used as a target for listeners, so in practice
* there is no need to check such ids. This reduce the overhead associated with generate client ids.</li>
* <li>false: do not do any check when ProjectStage is Production</li>
* </ul>
* <p> According to specification, identifiers must be unique within the scope of the nearest ancestor to
* the component that is a naming container.</p>
*/
> [perf] do not check for duplicate ids when saving view on production stage
> --------------------------------------------------------------------------
>
> Key: MYFACES-3418
> URL: https://issues.apache.org/jira/browse/MYFACES-3418
> Project: MyFaces Core
> Issue Type: New Feature
> Environment: myfaces trunk
> Reporter: Martin Kočí
> Assignee: Martin Kočí
> Priority: Minor
> Attachments: MYFACES-3418-alternative-1.patch, MYFACES-3418-final-1.patch, MYFACES-3418.patch
>
>
> see discussion here: http://www.mail-archive.com/dev@myfaces.apache.org/msg52995.html
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3418) [perf] do not check for duplicate
ids when saving view on production stage
Posted by "Leonardo Uribe (Commented) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184653#comment-13184653 ]
Leonardo Uribe commented on MYFACES-3418:
-----------------------------------------
I did another alternative for this one. The idea is do not take into account ids from components descending UILeaf (html markup) in production by default and do not use the parameter. Maybe we can combine both strategies, allowing org.apache.myfaces.CHECK_ID_IN_PRODUCTION with these values:
true : Check all client ids, including UILeaf components
auto : Check only client ids of components that does not extends from UILeaf.
false : Do not check for duplicate ids in production.
I think the advantage of the "auto" mode is that improve performance and reduce memory usage, and catch all duplicate id relevant cases (remember that facelets generates ids always starting with j_id_ , which is a reserved prefix for generated ids).
If no objections I'll combine both patches and commit the resulting code soon.
> [perf] do not check for duplicate ids when saving view on production stage
> --------------------------------------------------------------------------
>
> Key: MYFACES-3418
> URL: https://issues.apache.org/jira/browse/MYFACES-3418
> Project: MyFaces Core
> Issue Type: New Feature
> Environment: myfaces trunk
> Reporter: Martin Kočí
> Assignee: Martin Kočí
> Priority: Minor
> Attachments: MYFACES-3418-alternative-1.patch, MYFACES-3418.patch
>
>
> see discussion here: http://www.mail-archive.com/dev@myfaces.apache.org/msg52995.html
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MYFACES-3418) [perf] do not check for duplicate
ids when saving view on production stage
Posted by "Leonardo Uribe (Updated) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leonardo Uribe updated MYFACES-3418:
------------------------------------
Resolution: Fixed
Fix Version/s: 2.1.6
2.0.12
Status: Resolved (was: Patch Available)
> [perf] do not check for duplicate ids when saving view on production stage
> --------------------------------------------------------------------------
>
> Key: MYFACES-3418
> URL: https://issues.apache.org/jira/browse/MYFACES-3418
> Project: MyFaces Core
> Issue Type: New Feature
> Environment: myfaces trunk
> Reporter: Martin Kočí
> Assignee: Martin Kočí
> Priority: Minor
> Fix For: 2.0.12, 2.1.6
>
> Attachments: MYFACES-3418-alternative-1.patch, MYFACES-3418-final-1.patch, MYFACES-3418.patch
>
>
> see discussion here: http://www.mail-archive.com/dev@myfaces.apache.org/msg52995.html
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira