You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2017/07/12 22:14:21 UTC
[kudu-CR] KUDU-2067. Enable cfile checksumming by default
Grant Henke has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7409
Change subject: KUDU-2067. Enable cfile checksumming by default
......................................................................
KUDU-2067. Enable cfile checksumming by default
Cfile checksums were added in KUDU-463 but disabledby default to help avoid any issues preventing a userfrom downgrading Kudu.Note: This will a minor impact on read and write throughputdue to additional checksum creation, validation and data.
Change-Id: I615bf39cddcadbdac08b565f149106360e324269
---
M src/kudu/cfile/cfile_writer.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/7409/1
--
To view, visit http://gerrit.cloudera.org:8080/7409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I615bf39cddcadbdac08b565f149106360e324269
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
[kudu-CR] KUDU-2067. Enable cfile checksumming by default
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: KUDU-2067. Enable cfile checksumming by default
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I615bf39cddcadbdac08b565f149106360e324269
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] KUDU-2067. Enable cfile checksumming by default
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: KUDU-2067. Enable cfile checksumming by default
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7409/1//COMMIT_MSG
Commit Message:
Line 11: Change-Id: I615bf39cddcadbdac08b565f149106360e324269
That means you downgrade from 1.5 to 1.4 and everything will still work, right?
PS1, Line 13:
This will a word
--
To view, visit http://gerrit.cloudera.org:8080/7409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I615bf39cddcadbdac08b565f149106360e324269
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2067. Enable cfile checksumming by default
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change.
Change subject: KUDU-2067. Enable cfile checksumming by default
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7409/1//COMMIT_MSG
Commit Message:
Line 11: Change-Id: I615bf39cddcadbdac08b565f149106360e324269
> That means you downgrade from 1.5 to 1.4 and everything will still work, ri
Yes, that's right.
A downgrade from 1.5 to 1.3 will not work. If new data with checksums was written that data would be unreadable in 1.3.
This feature can also be disabled by setting cfile_write_checksums=false (write side) and cfile_verify_checksums=false (read side).
--
To view, visit http://gerrit.cloudera.org:8080/7409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I615bf39cddcadbdac08b565f149106360e324269
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2067. Enable cfile checksumming by default
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7409
to look at the new patch set (#2).
Change subject: KUDU-2067. Enable cfile checksumming by default
......................................................................
KUDU-2067. Enable cfile checksumming by default
Cfile checksums were added in KUDU-463 but disabledby default to help avoid any issues preventing a userfrom downgrading Kudu.Note: This will a have minor impact on read and write throughputdue to additional checksum creation, validation and data.
Change-Id: I615bf39cddcadbdac08b565f149106360e324269
---
M src/kudu/cfile/cfile_writer.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/7409/2
--
To view, visit http://gerrit.cloudera.org:8080/7409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I615bf39cddcadbdac08b565f149106360e324269
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-2067. Enable cfile checksumming by default
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has submitted this change and it was merged.
Change subject: KUDU-2067. Enable cfile checksumming by default
......................................................................
KUDU-2067. Enable cfile checksumming by default
Cfile checksums were added in KUDU-463 but disabledby default to help avoid any issues preventing a userfrom downgrading Kudu.Note: This will a have minor impact on read and write throughputdue to additional checksum creation, validation and data.
Change-Id: I615bf39cddcadbdac08b565f149106360e324269
Reviewed-on: http://gerrit.cloudera.org:8080/7409
Tested-by: Kudu Jenkins
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
---
M src/kudu/cfile/cfile_writer.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jean-Daniel Cryans: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I615bf39cddcadbdac08b565f149106360e324269
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>