You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "bschuchardt (GitHub)" <gi...@apache.org> on 2018/11/15 16:41:01 UTC
[GitHub] [geode] bschuchardt commented on issue #2857: GEODE-6013:
Use expected initial image requester's rvv information
For other reviewers, here is a diff between Anil's last PR and this one:
118c118
< index 7b03d48bfc8..ce10dfdc1b3 100644
---
> index 7b03d48bfc8..b53b5029b8d 100644
121c121
< @@ -977,34 +977,35 @@ public boolean isNewerThanOrCanFillExceptionsFor(RegionVersionVector<T> other) {
---
> @@ -977,7 +977,8 @@ public boolean isNewerThanOrCanFillExceptionsFor(RegionVersionVector<T> other) {
131,134c131
< RegionVersionHolder<T> holder = new RegionVersionHolder<T>(gcVersion.longValue());
< - return !holder.isNewerThanOrCanFillExceptionsFor(otherHolder);
< + return otherHolder.dominates(holder);
< }
---
> @@ -987,24 +988,24 @@ private boolean isGCVersionDominatedByHolder(Long gcVersion, RegionVersionHolder
184c181
< index deb7d4eaa3d..a018aaff6fa 100644
---
> index deb7d4eaa3d..ed671a6f09c 100644
187c184
< @@ -661,6 +661,145 @@ public void doesNotHangIfOtherThreadChangedVersion() throws Exception {
---
> @@ -661,6 +661,167 @@ public void doesNotHangIfOtherThreadChangedVersion() throws Exception {
235a233,254
> + public void isRvvGcDominatedByRequesterRvvReturnsFalseIfProviderRvvIsNotPresent()
> + throws Exception {
> + final String local = getIPLiteral();
> + InternalDistributedMember provider = new InternalDistributedMember(local, 101);
> + InternalDistributedMember requester = new InternalDistributedMember(local, 102);
> +
> + RegionVersionVector providerRvv = new VMRegionVersionVector(provider, null,
> + 1, null, 1, false, null);
> +
> + ConcurrentHashMap<InternalDistributedMember, RegionVersionHolder<InternalDistributedMember>> memberToRegionVersionHolder =
> + new ConcurrentHashMap<>();
> + RegionVersionHolder regionVersionHolder = new RegionVersionHolder(provider);
> + regionVersionHolder.setVersion(0);
> + // memberToRegionVersionHolder.put(provider, regionVersionHolder);
> + RegionVersionVector requesterRvv =
> + new VMRegionVersionVector(requester, memberToRegionVersionHolder,
> + 0, null, 0, false, null);
> +
> + assertThat(providerRvv.isRVVGCDominatedBy(requesterRvv)).isFalse();
> + }
> +
> + @Test
[ Full content available at: https://github.com/apache/geode/pull/2857 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org