[jira] [Commented] (HUDI-2170) Always choose the latest record for HoodieRecordPayload

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HUDI-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17391811#comment-17391811 ] 

ASF GitHub Bot commented on HUDI-2170:
--------------------------------------

vinothchandar commented on a change in pull request #3267:
URL: https://github.com/apache/hudi/pull/3267#discussion_r681298546



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/model/OverwriteWithLatestAvroPayload.java
##########
@@ -25,8 +25,12 @@
 import org.apache.avro.generic.GenericRecord;
 import org.apache.avro.generic.IndexedRecord;
 
+import javax.annotation.Nullable;

Review comment:
       deal with this across the board? instead of just for this class. 
   

##########
File path: hudi-common/src/main/java/org/apache/hudi/common/model/DefaultHoodieRecordPayload.java
##########
@@ -43,6 +43,10 @@
   public static final String METADATA_EVENT_TIME_KEY = "metadata.event_time.key";
   private Option<Object> eventTime = Option.empty();
 
+  public DefaultHoodieRecordPayload(GenericRecord record, String orderingField) {

Review comment:
       can this be not passed in the properties sent to the payload? Love to not introduce a new constructor, if we don't have to




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Always choose the latest record for HoodieRecordPayload
> -------------------------------------------------------
>
>                 Key: HUDI-2170
>                 URL: https://issues.apache.org/jira/browse/HUDI-2170
>             Project: Apache Hudi
>          Issue Type: Improvement
>          Components: Common Core
>            Reporter: Danny Chen
>            Assignee: Danny Chen
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.9.0
>
>
> Now in {{OverwriteWithLatestAvroPayload.preCombine}}, we still choose the old record when the new record has the same preCombine field with the old one, actually it is more natural to keep the new incoming record instead. The {{DefaultHoodieRecordPayload.combineAndGetUpdateValue}} method already did that.
> See issue: https://github.com/apache/hudi/issues/3266.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)