[GitHub] [incubator-tvm] masahi commented on a change in pull request #4992: [Frontend][Torch] Check graph inputs match expected

[GitBox <gi...@apache.org>]

masahi commented on a change in pull request #4992: [Frontend][Torch] Check graph inputs match expected
URL: https://github.com/apache/incubator-tvm/pull/4992#discussion_r388297235
 
 

 ##########
 File path: python/tvm/relay/frontend/pytorch.py
 ##########
 @@ -902,6 +902,21 @@ def _report_missing_conversion(op_names):
         msg = "The following operators are not implemented: {}".format(missing)
         raise NotImplementedError(msg)
 
+def _check_input_names(graph, input_shapes):
+    """ Check the graph inputs match the inputs """
+    # remove self at the 0th arg
+    ir_inputs = _get_input_names(graph)[1:]
 
 Review comment:
   Passing script_module and using _get_graph_input_names would be simpler? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services