You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by Karen Lease <ka...@club-internet.fr> on 2001/04/11 23:57:04 UTC

[WARNING: BEHAVIOR CHANGES] Table changes

Hi all,

Since there have been a lot of issues regarding tables lately, I decided
to commit some changes I've been working on, even though there may be
things that are still not quite right. Globally I think it is an
improvement.

This should fix the bug causing tables to be broken over pages or
columns when they shouldn't be. It also makes a lot of changes in border
drawing. I have tried to move FOP behavior closer to the W3C CR
specification. The down side is that it will certainly 'break' some
existing FO files.

There are a couple of things to look out for:
1. I implemented partial support for the border-collapse property. The
default value is "collapse". Unfortunately, this is a lot harder to do
right, so what is currently implemented is "separate". This more or less
corresponds to what FOP was already doing, but with some changes to
where borders and padding are drawn in relation to the cell grid. The
problem is that if you don't now specify "border-collapse='separate' on
the table (it inherits), your table will probably look worse than it
does now. Sorry....

2. The CR says that borders on TableRow and Column are supposed to be
ignored. They are now ignored on Row. You can use the "inherit" value on
the cells to copy the row value down, but it doesn't automatically
inherit. I agree that this doesn't seem very reasonable. It may be
(depending on how one interpretes the CR) that in the "collapse" style,
these values should be taken into account to determine the actual
borders that are drawn on a cell, but I'm really not sure.

There are still a bunch of bugs (missing cell backgrounds for example).
I'll try to get some approximation of the "collapse" style working ASAP.

Courage....

-Karen Lease

---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org


Re: [WARNING: BEHAVIOR CHANGES] Table changes

Posted by Karen Lease <ka...@club-internet.fr>.
Steve Switzer wrote:
> 
> I'm new to the group, but I think I've been suffering the effects of
> "the bug causing tables to be broken over pages" -- Can anyone
> fill me in as to what the symptoms are of this bug?
> - Steve Switzer.
> 
[snip snip]

Hi Steve,

The bug involved tables with cell borders. The "space remaining on page"
calculation was incorrect so the page seemed to be a lot shorter than it
was. The effect was that tables were split across two pages or that
other material following the table was put on the next page, even though
there was plenty of space left on the current page. The current CVS
version contains fixes for this problem.

Hope that helps you,
Karen Lease



---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org


Re: [WARNING: BEHAVIOR CHANGES] Table changes

Posted by Steve Switzer <ss...@myra.com>.
I'm new to the group, but I think I've been suffering the effects of
"the bug causing tables to be broken over pages" -- Can anyone
fill me in as to what the symptoms are of this bug?
- Steve Switzer.

Karen Lease wrote:

> Hi all,
>
> Since there have been a lot of issues regarding tables lately, I decided
> to commit some changes I've been working on, even though there may be
> things that are still not quite right. Globally I think it is an
> improvement.
>
> This should fix the bug causing tables to be broken over pages or
> columns when they shouldn't be. It also makes a lot of changes in border
> drawing. I have tried to move FOP behavior closer to the W3C CR
> specification. The down side is that it will certainly 'break' some
> existing FO files.
>
> There are a couple of things to look out for:
> 1. I implemented partial support for the border-collapse property. The
> default value is "collapse". Unfortunately, this is a lot harder to do
> right, so what is currently implemented is "separate". This more or less
> corresponds to what FOP was already doing, but with some changes to
> where borders and padding are drawn in relation to the cell grid. The
> problem is that if you don't now specify "border-collapse='separate' on
> the table (it inherits), your table will probably look worse than it
> does now. Sorry....
>
> 2. The CR says that borders on TableRow and Column are supposed to be
> ignored. They are now ignored on Row. You can use the "inherit" value on
> the cells to copy the row value down, but it doesn't automatically
> inherit. I agree that this doesn't seem very reasonable. It may be
> (depending on how one interpretes the CR) that in the "collapse" style,
> these values should be taken into account to determine the actual
> borders that are drawn on a cell, but I'm really not sure.
>
> There are still a bunch of bugs (missing cell backgrounds for example).
> I'll try to get some approximation of the "collapse" style working ASAP.
>
> Courage....
>
> -Karen Lease
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
> For additional commands, email: fop-dev-help@xml.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org


Re: [WARNING: BEHAVIOR CHANGES] Table changes

Posted by Daniel Bradby <da...@bjs.com.au>.
Karen, 

> This should fix the bug causing tables to be broken over pages or
> columns when they shouldn't be. It also makes a lot of changes in border

Ahhh .... my output looks so much better now :)

> 2. The CR says that borders on TableRow and Column are supposed to be
> ignored. They are now ignored on Row. You can use the "inherit" value on

It didn't take much to fix my FOs and it now is closer to the spec.
Thanks!

> There are still a bunch of bugs (missing cell backgrounds for example).
> I'll try to get some approximation of the "collapse" style working ASAP.

I noticed border.fo and table.fo are still all over the place. I really
am looking forward to seeing these fixed and row spanning implemented.
If there is anything I can do to help, pls let me know :)

Daniel

---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org


Re: [WARNING: BEHAVIOR CHANGES] Table changes

Posted by Peter Darke <pe...@murchison.com.au>.
Daniel Bradby wrote:
> 
> > I'm getting lots of:
> >
> > WARNING: no Maker for margin-
> >
> > followed by a few:
> >
> > WARNING: no Maker for padding-
> > WARNING: property padding- ignored
> >
> > and finally a:
> >
> > ERROR: null
> 
> maybe turn on debug (-d) to get some more info
> 
> > I get the same errors processing the examples in the table directory.
> >
> > (Using Linux, JDK 1.3, latest CVS)
> 
> hmmm ... I tried those examples with latest CVS, JDK1.3 and Windows 2000
> and it all seems ok
> 
> A build clean might help as well

Clean build fixed it.

Tables look better, but borders are still messed up sometimes when a
page break occurs. I'll have to try and make a simple test for it, after
Easter.

Thanks,
Peter

> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
> For additional commands, email: fop-dev-help@xml.apache.org

-- 
Peter Darke
Database Administrator
Murchison Productions Pty Ltd.
ABN : 35 009 566 401
Tel  (03) 6336 6700  Fax (03) 6334 5710
International Tel + 61 3 6336 6700
direct email: peter@murchison.com.au
general email: info@murchison.com.au
web site: http://www.murchison.com.au 
Launceston Office: 16 Paterson St. Launceston
P.O. Box 1699, Launceston 7250 Australia.

Melbourne Office: 340 Collins Street, Melbourne.

This email may contain confidential information.  If you have received
this email in error, please delete it immediately, and inform us of
the mistake by return email.  Any form of reproduction, or further
dissemination of this email is strictly prohibited.  Also, please note
that opinions expressed in this email are those of the author and are
not necessarily those of Murchison Productions Pty Ltd.

---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org


Re: [WARNING: BEHAVIOR CHANGES] Table changes

Posted by Daniel Bradby <da...@bjs.com.au>.
> I'm getting lots of:
> 
> WARNING: no Maker for margin-
> 
> followed by a few:
> 
> WARNING: no Maker for padding-
> WARNING: property padding- ignored
> 
> and finally a:
> 
> ERROR: null

maybe turn on debug (-d) to get some more info

> I get the same errors processing the examples in the table directory.
> 
> (Using Linux, JDK 1.3, latest CVS)

hmmm ... I tried those examples with latest CVS, JDK1.3 and Windows 2000
and it all seems ok

A build clean might help as well

---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org


Re: [WARNING: BEHAVIOR CHANGES] Table changes

Posted by Peter Darke <pe...@murchison.com.au>.
Karen Lease wrote:
> 
> Hi all,
> 
> Since there have been a lot of issues regarding tables lately, I
> decided
> to commit some changes I've been working on, even though there may be
> things that are still not quite right. Globally I think it is an
> improvement.
> 
> This should fix the bug causing tables to be broken over pages or
> columns when they shouldn't be. It also makes a lot of changes in
> border
> drawing. I have tried to move FOP behavior closer to the W3C CR
> specification. The down side is that it will certainly 'break' some
> existing FO files.
> 
> There are a couple of things to look out for:
> 1. I implemented partial support for the border-collapse property. The
> default value is "collapse". Unfortunately, this is a lot harder to do
> right, so what is currently implemented is "separate". This more or
> less
> corresponds to what FOP was already doing, but with some changes to
> where borders and padding are drawn in relation to the cell grid. The
> problem is that if you don't now specify "border-collapse='separate'
> on
> the table (it inherits), your table will probably look worse than it
> does now. Sorry....
> 
> 2. The CR says that borders on TableRow and Column are supposed to be
> ignored. They are now ignored on Row. You can use the "inherit" value
> on
> the cells to copy the row value down, but it doesn't automatically
> inherit. I agree that this doesn't seem very reasonable. It may be
> (depending on how one interpretes the CR) that in the "collapse"
> style,
> these values should be taken into account to determine the actual
> borders that are drawn on a cell, but I'm really not sure.
> 
> There are still a bunch of bugs (missing cell backgrounds for
> example).
> I'll try to get some approximation of the "collapse" style working
> ASAP.
> 
> Courage....
> 
> -Karen Lease
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
> For additional commands, email: fop-dev-help@xml.apache.org

I'm getting lots of:

WARNING: no Maker for margin-

followed by a few:

WARNING: no Maker for padding-
WARNING: property padding- ignored

and finally a:

ERROR: null

I get the same errors processing the examples in the table directory.

(Using Linux, JDK 1.3, latest CVS)

Any hints?

-- 
Peter Darke
Database Administrator
Murchison Productions Pty Ltd.
ABN : 35 009 566 401
Tel  (03) 6336 6700  Fax (03) 6334 5710
International Tel + 61 3 6336 6700
direct email: peter@murchison.com.au
general email: info@murchison.com.au
web site: http://www.murchison.com.au 
Launceston Office: 16 Paterson St. Launceston
P.O. Box 1699, Launceston 7250 Australia.

Melbourne Office: 340 Collins Street, Melbourne.

This email may contain confidential information.  If you have received
this email in error, please delete it immediately, and inform us of
the mistake by return email.  Any form of reproduction, or further
dissemination of this email is strictly prohibited.  Also, please note
that opinions expressed in this email are those of the author and are
not necessarily those of Murchison Productions Pty Ltd.

---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org