You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2012/06/18 22:37:42 UTC

[Bug 53433] New: LastCellOfRowDummyRecord is fired unneccessarily whenever formula cell(returning String Result) is encountered

https://issues.apache.org/bugzilla/show_bug.cgi?id=53433

          Priority: P2
            Bug ID: 53433
          Assignee: dev@poi.apache.org
           Summary: LastCellOfRowDummyRecord is fired unneccessarily
                    whenever formula cell(returning String Result) is
                    encountered
          Severity: normal
    Classification: Unclassified
          Reporter: overtomanu@gmail.com
          Hardware: PC
            Status: NEW
           Version: 3.8
         Component: HSSF
           Product: POI

Created attachment 28956
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=28956&action=edit
Test file for which XLS2CSVmra fails

Whenever a formula cell(returning String result) is encountered, three records
are fired by the HSSF Event API in the given
order(FormulaRecord,LastCellOfRowDummyRecord,StringRecord).

LastCellOfRowDummyRecord which is fired in between FormulaRecord and
StringRecord should not occur as it should be fired only when the row ends.


Attached is a Xltest file for which existing XLS2CSVmra program fails.
Also there is a patched program which manages to give correct output.
However it is not tested thoroughly.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 53433] LastCellOfRowDummyRecord is fired unneccessarily whenever formula cell(returning String Result) is encountered

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53433

--- Comment #1 from Manohar Bhat <ov...@gmail.com> ---
Created attachment 28957
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=28957&action=edit
This version ignores LastCellOfRowDummyRecord for detecting row end

This version of XLS2CSVmra does not depend on LastCellOfRowDummyRecord to
detect row end. But whenever the "thisRow" value of cell increases, it is
assumed that a new row is beginning.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 53433] LastCellOfRowDummyRecord is fired unneccessarily whenever formula cell(returning String Result) is encountered

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53433

Nick Burch <ap...@gagravarr.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Nick Burch <ap...@gagravarr.org> ---
It looks like this specific problem was solved some time ago

As of r1614789, I have added some very detailed unit tests for this, which show
that the string record following formula records behaves as expected. 

(I did find some other issues around missing rows at the start while working on
this, which have now been fixed)

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org