You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/12/17 23:13:06 UTC
[GitHub] [camel-website] ppalaga opened a new pull request #509: Blog: Camel Quarkus 1.5.0
ppalaga opened a new pull request #509:
URL: https://github.com/apache/camel-website/pull/509
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] zregvart commented on pull request #509: Blog: Camel Quarkus 1.5.0
Posted by GitBox <gi...@apache.org>.
zregvart commented on pull request #509:
URL: https://github.com/apache/camel-website/pull/509#issuecomment-748035698
We also need a [release note](https://github.com/apache/camel-website#sub-project-release) to make the release available on the download/release pages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] davsclaus commented on a change in pull request #509: Blog: Camel Quarkus 1.5.0
Posted by GitBox <gi...@apache.org>.
davsclaus commented on a change in pull request #509:
URL: https://github.com/apache/camel-website/pull/509#discussion_r545775386
##########
File path: content/blog/2020/12/camel-quarkus-release-1.5.0/index.md
##########
@@ -0,0 +1,69 @@
+---
+title: "Camel Quarkus 1.5.0 Released"
+date: 2020-12-18
+authors: ["ppalaga"]
+categories: ["Releases", "Camel Quarkus"]
+preview: "Camel Quarkus 1.5.0 Released"
+summary: "The highlights of Camel Quarkus 1.5.0"
+---
+
+<sub><sup>Original image by <a href="https://commons.wikimedia.org/wiki/User:99of9">Toby Hudson</a> <a href="https://creativecommons.org/licenses/by-sa/3.0">CC BY-SA 3.0</a> via <a href="https://en.wikipedia.org/wiki/Camel_racing#/media/File:CamelRacingCamelCup2009Heat.JPG">Wikipedia</a></sup></sub>
+
+We are pleased to announce the release 1.5.0 of Camel Quarkus! What's inside?
+
+## Camel 3.7.0
+
+Camel Quarkus 1.5.0 is based on Camel 3.7.0 LTS bringing new features and improvements relevant to Camel Quarkus:
+
+### CSimple language
+
+[CSimple language](https://camel.apache.org/components/latest/languages/csimple-language.html) is a new variant of the well known [Simple language](https://camel.apache.org/components/latest/languages/simple-language.html). The "C" in its name stands for "compiled" and indeed, the expressions are compiled into Java byte code or native code at application build time. This brings significant performance boost at runtime. Camel Quarkus 1.5.0 brings experimental support for the CSimple language in both JVM and native modes.
Review comment:
You cannot use absolute url, start from /components/...
##########
File path: content/blog/2020/12/camel-quarkus-release-1.5.0/index.md
##########
@@ -0,0 +1,69 @@
+---
+title: "Camel Quarkus 1.5.0 Released"
+date: 2020-12-18
+authors: ["ppalaga"]
+categories: ["Releases", "Camel Quarkus"]
+preview: "Camel Quarkus 1.5.0 Released"
+summary: "The highlights of Camel Quarkus 1.5.0"
+---
+
+<sub><sup>Original image by <a href="https://commons.wikimedia.org/wiki/User:99of9">Toby Hudson</a> <a href="https://creativecommons.org/licenses/by-sa/3.0">CC BY-SA 3.0</a> via <a href="https://en.wikipedia.org/wiki/Camel_racing#/media/File:CamelRacingCamelCup2009Heat.JPG">Wikipedia</a></sup></sub>
+
+We are pleased to announce the release 1.5.0 of Camel Quarkus! What's inside?
+
+## Camel 3.7.0
+
+Camel Quarkus 1.5.0 is based on Camel 3.7.0 LTS bringing new features and improvements relevant to Camel Quarkus:
+
+### CSimple language
+
+[CSimple language](https://camel.apache.org/components/latest/languages/csimple-language.html) is a new variant of the well known [Simple language](https://camel.apache.org/components/latest/languages/simple-language.html). The "C" in its name stands for "compiled" and indeed, the expressions are compiled into Java byte code or native code at application build time. This brings significant performance boost at runtime. Camel Quarkus 1.5.0 brings experimental support for the CSimple language in both JVM and native modes.
+
+### Lightweight mode
+
+In lightweight mode, Camel removes all references to the routes model after startup which allows the JVM to garbage collect all model objects and unload classes, freeing up memory. The downside is that after new Camel routes cannot be added once the application has fully started.
+
+Lightweight mode can be activated by adding the `camel-quarkus-main` dependency and adding
+
+```
+camel.main.lightweight=true
+```
+
+to `application.properties`.
+
+Check [Camel 3.7 what's new](https://camel.apache.org/blog/2020/12/Camel37-Whatsnew/) blog post by Claus Ibsen for more information about Camel 3.7.0.
Review comment:
Absolute urls to camel website itself will fail in build, see prev comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] zregvart commented on pull request #509: Blog: Camel Quarkus 1.5.0
Posted by GitBox <gi...@apache.org>.
zregvart commented on pull request #509:
URL: https://github.com/apache/camel-website/pull/509#issuecomment-748079338
[Download](https://deploy-preview-509--camel.netlify.app/download/) and [release](https://deploy-preview-509--camel.netlify.app/releases/q-1.5.0/) page look good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] ppalaga commented on a change in pull request #509: Blog: Camel Quarkus 1.5.0
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #509:
URL: https://github.com/apache/camel-website/pull/509#discussion_r545911970
##########
File path: .gitignore
##########
@@ -20,3 +20,5 @@ resources
!**/.yarn/sdks
!**/.yarn/unplugged
!**/.yarn/versions
+
+.pnp
Review comment:
> I'll remove that from .gitignore.
As I said, the change is not in the master anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] ppalaga merged pull request #509: Blog: Camel Quarkus 1.5.0
Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #509:
URL: https://github.com/apache/camel-website/pull/509
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] zregvart commented on a change in pull request #509: Blog: Camel Quarkus 1.5.0
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #509:
URL: https://github.com/apache/camel-website/pull/509#discussion_r545903632
##########
File path: .gitignore
##########
@@ -20,3 +20,5 @@ resources
!**/.yarn/sdks
!**/.yarn/unplugged
!**/.yarn/versions
+
+.pnp
Review comment:
Yeah, I don't think it should be ignored, PNP stands for plug and play which is a Yarn feature that replaces node_modules, we also use another Yarn feature called zero install that vendors all the dependencies. The end result is, if you checkout the repository you don't need to fetch anything to build. For example, we don't need `yarn install` on the CI:
https://github.com/apache/camel-website/blob/33fedc838299b8b0b84aa24726ff813eb7ec5218/Jenkinsfile#L58
In that way it's odd that you get this file/directory created, as we also have a GitHub action that checks that everything is present in `.yarn` and in sync with `.pnp.js` and `yarn.lock`:
https://github.com/apache/camel-website/blob/33fedc838299b8b0b84aa24726ff813eb7ec5218/.github/workflows/pr.yaml#L28
Nevermind, I'll remove that from .gitignore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] ppalaga commented on a change in pull request #509: Blog: Camel Quarkus 1.5.0
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #509:
URL: https://github.com/apache/camel-website/pull/509#discussion_r545901029
##########
File path: .gitignore
##########
@@ -20,3 +20,5 @@ resources
!**/.yarn/sdks
!**/.yarn/unplugged
!**/.yarn/versions
+
+.pnp
Review comment:
I have force-pushed without this change to the master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] ppalaga commented on pull request #509: Blog: Camel Quarkus 1.5.0
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #509:
URL: https://github.com/apache/camel-website/pull/509#issuecomment-747967151
Thanks for noticing, 26a7ea6 removes the unnecessary files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] ppalaga commented on pull request #509: Blog: Camel Quarkus 1.5.0
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #509:
URL: https://github.com/apache/camel-website/pull/509#issuecomment-748054795
34a3ff0:
* `s|https://camel.apache.org||`
* Added a release note
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] ppalaga commented on pull request #509: Blog: Camel Quarkus 1.5.0
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #509:
URL: https://github.com/apache/camel-website/pull/509#issuecomment-748068011
Is this good to merge now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] ppalaga commented on a change in pull request #509: Blog: Camel Quarkus 1.5.0
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #509:
URL: https://github.com/apache/camel-website/pull/509#discussion_r545880584
##########
File path: .gitignore
##########
@@ -20,3 +20,5 @@ resources
!**/.yarn/sdks
!**/.yarn/unplugged
!**/.yarn/versions
+
+.pnp
Review comment:
Ups, sorry, I have not noticed this comment. You mean it should not be ignored?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] davsclaus commented on pull request #509: Blog: Camel Quarkus 1.5.0
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #509:
URL: https://github.com/apache/camel-website/pull/509#issuecomment-747951355
No something is wrong, a blog post is only the blog itself, and maybe some images.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] davsclaus commented on pull request #509: Blog: Camel Quarkus 1.5.0
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #509:
URL: https://github.com/apache/camel-website/pull/509#issuecomment-747951734
Smells like you mistakenly added all temporary node files or something. I guess maybe we need to add more folders to gitignore or something.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] ppalaga commented on pull request #509: Blog: Camel Quarkus 1.5.0
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #509:
URL: https://github.com/apache/camel-website/pull/509#issuecomment-747763787
@zbendhiba could you please review too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] ppalaga commented on pull request #509: Blog: Camel Quarkus 1.5.0
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #509:
URL: https://github.com/apache/camel-website/pull/509#issuecomment-748122726
Thanks for the review, everyone!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] zregvart commented on a change in pull request #509: Blog: Camel Quarkus 1.5.0
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #509:
URL: https://github.com/apache/camel-website/pull/509#discussion_r545822553
##########
File path: .gitignore
##########
@@ -20,3 +20,5 @@ resources
!**/.yarn/sdks
!**/.yarn/unplugged
!**/.yarn/versions
+
+.pnp
Review comment:
Not sure where this is created or why, but it sounds like we need it or it generates by error on your side. Either way I think it needs to be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] zbendhiba commented on pull request #509: Blog: Camel Quarkus 1.5.0
Posted by GitBox <gi...@apache.org>.
zbendhiba commented on pull request #509:
URL: https://github.com/apache/camel-website/pull/509#issuecomment-747950616
@ppalaga is it normal to have 3000+ files changed ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org