[jira] [Commented] (FLINK-9888) Remove unsafe defaults from release scripts

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547709#comment-16547709 ] 

ASF GitHub Bot commented on FLINK-9888:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/6362

    [FLINK-9888][release] Remove unsafe defaults from release scripts

    ## What is the purpose of the change
    
    This PR removes several unnecessary and unsafe `*_VERSION` defaults from the release scripts.
    The scripts should never be called without explicitly setting these values.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 9888

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6362.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6362
    
----
commit 93c8f557af888020dca8ae81ae117f4e460f475d
Author: zentol <ch...@...>
Date:   2018-07-18T11:42:06Z

    [FLINK-9888][release] Remove unsafe defaults from release scripts

----


> Remove unsafe defaults from release scripts
> -------------------------------------------
>
>                 Key: FLINK-9888
>                 URL: https://issues.apache.org/jira/browse/FLINK-9888
>             Project: Flink
>          Issue Type: Bug
>          Components: Release System
>    Affects Versions: 1.5.1, 1.6.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Major
>              Labels: pull-request-available
>
> Several variables in the release scripts have unsafe defaults, like these from {{create_release_branch.sh}}:
> {code}
> OLD_VERSION=${OLD_VERSION:-1.2-SNAPSHOT}
> NEW_VERSION=${NEW_VERSION:-1.3-SNAPSHOT}
> {code}
> We should not allow the script to run successfully without these being explicitly set.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)