You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2020/10/22 09:32:36 UTC

[GitHub] [libcloud] dimgal1 opened a new pull request #1511: Packet rebranding to Equinix Metal

dimgal1 opened a new pull request #1511:
URL: https://github.com/apache/libcloud/pull/1511


   ## Packet rebranding to Equinix Metal
   
   ### Description
   Update driver, tests and assets to reflect the Packet rebranding to Equinix Metal
   
   
   ### Status
   done, ready for review
   
   ### Checklist (tick everything that applies)
   
   - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
   - [x] Documentation
   - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
   - [x] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [libcloud] displague commented on pull request #1511: Packet rebranding to Equinix Metal

Posted by GitBox <gi...@apache.org>.
displague commented on pull request #1511:
URL: https://github.com/apache/libcloud/pull/1511#issuecomment-714479333


   This looks good to me, if the preference is to leave a deprecated Packet driver in place, the old Packet drivers could take on the new API endpoints and continue working until the deprecation deadline is met.  There would be a minor change in the API results because the `href` values have changed.
   
   I see more "Packet" references leftover in the code and documentation (`git grep -n -i packet`), there are also more "packet.net", "packet.com", "packethost.net", and "net.packet" references.  It's a tricky rename because TCP "packet" appears in several locations of the code.
   
   The image ./docs/_static/images/provider_logos/packet.png should be updated to an Equinix Metal name and logo (`find . -name \*packet\*`).
   
   Also, `libcloud/test/compute/test_equinixmetal.py` has two incorrect email address in the comment block.  The maintainer should be updated and the credit to jed@packet.com (@jedsmith) should be jed@linode.com (which isn't a current email address either).  This portion of the comment block can probably be removed.
   
    


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [libcloud] jedsmith edited a comment on pull request #1511: Packet rebranding to Equinix Metal

Posted by GitBox <gi...@apache.org>.
jedsmith edited a comment on pull request #1511:
URL: https://github.com/apache/libcloud/pull/1511#issuecomment-714618632


   Looks like someone copied over Linode code and did a `sed` to replace `linode` with `packet`, to explain the incorrect e-mail address for me. I've never been employed by Packet, and I'm relatively annoyed to have made this discovery this morning. Poor form. Nice catch, @displague.
   
   Edit: [Here's where it came from.](https://github.com/apache/libcloud/commit/4d51ede113df6a16f55e1027726fe858aff1e8d5#diff-47fa639cd27b7d1b06fd76ccc4afb4ae4e7cbb273c7f4d689e5ccc2b18fec5fbR17)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [libcloud] dimgal1 commented on pull request #1511: Packet rebranding to Equinix Metal

Posted by GitBox <gi...@apache.org>.
dimgal1 commented on pull request #1511:
URL: https://github.com/apache/libcloud/pull/1511#issuecomment-720420039


   Done!
   I have added the new logo but left the old packet one. Should I remove it?
   Also, is there anything else I should change?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [libcloud] jedsmith commented on pull request #1511: Packet rebranding to Equinix Metal

Posted by GitBox <gi...@apache.org>.
jedsmith commented on pull request #1511:
URL: https://github.com/apache/libcloud/pull/1511#issuecomment-714506635


   My valid email is jed@jedsmith.org, if it’s helpful.
   
   On Thu, Oct 22, 2020, at 09:04, Marques Johansson wrote:
   > 
   > 
   > This looks good to me, if the preference is to leave a deprecated 
   > Packet driver in place, the old Packet drivers could take on the new 
   > API endpoints and continue working until the deprecation deadline is 
   > met. There would be a minor change in the API results because the 
   > `href` values have changed.
   > 
   > I see more "Packet" references leftover in the code and documentation 
   > (`git grep -n -i packet`), there are also more "packet.net", 
   > "packet.com", "packethost.net", and "net.packet" references. It's a 
   > tricky rename because TCP "packet" appears in several locations of the 
   > code.
   > 
   > The image ./docs/_static/images/provider_logos/packet.png should be 
   > updated to an Equinix Metal name and logo (`find . -name \*packet\*`).
   > 
   > Also, `libcloud/test/compute/test_equinixmetal.py` has two incorrect 
   > email address in the comment block. The maintainer should be updated 
   > and the credit to jed@packet.com (@jedsmith 
   > <https://github.com/jedsmith>) should be jed@linode.com (which isn't a 
   > current email address either). This portion of the comment block can 
   > probably be removed.
   > 
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub 
   > <https://github.com/apache/libcloud/pull/1511#issuecomment-714479333>, 
   > or unsubscribe 
   > <https://github.com/notifications/unsubscribe-auth/AAAUETYQZEDJ2YRBLLWJGJTSMAUURANCNFSM4S253XBA>.
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [libcloud] asfgit merged pull request #1511: Packet rebranding to Equinix Metal

Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #1511:
URL: https://github.com/apache/libcloud/pull/1511


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [libcloud] jedsmith edited a comment on pull request #1511: Packet rebranding to Equinix Metal

Posted by GitBox <gi...@apache.org>.
jedsmith edited a comment on pull request #1511:
URL: https://github.com/apache/libcloud/pull/1511#issuecomment-714618632


   Looks like someone copied over Linode code and did a `sed` to replace `linode` with `packet`, to explain the incorrect e-mail address for me. I've never been employed by Packet, and I'm relatively annoyed to have made this discovery this morning. Poor form.
   
   Edit: [Here's where it came from.](https://github.com/apache/libcloud/commit/4d51ede113df6a16f55e1027726fe858aff1e8d5#diff-47fa639cd27b7d1b06fd76ccc4afb4ae4e7cbb273c7f4d689e5ccc2b18fec5fbR17)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [libcloud] dimgal1 commented on pull request #1511: Packet rebranding to Equinix Metal

Posted by GitBox <gi...@apache.org>.
dimgal1 commented on pull request #1511:
URL: https://github.com/apache/libcloud/pull/1511#issuecomment-714522081


   Thanks for the feedback. Just to summarize:
   1. Regarding the deprecation of the old Packet driver, I think it's best for the maintainers to decide how to handle (@Kami?).
   2. Regarding docs, most files seem to be auto-generated but I can't find guidelines on how to build and commit them. Any insights?
   3. Regarding the image, the new one is already included. Didn't remove the old one because of (2) above.
   4. Regarding the maintainer, @displague I see you work for Equinix. Will you pick up this role or should I leave it blank?
   5. Regarding the reference to @jedsmith, I will update to the email address above.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [libcloud] displague edited a comment on pull request #1511: Packet rebranding to Equinix Metal

Posted by GitBox <gi...@apache.org>.
displague edited a comment on pull request #1511:
URL: https://github.com/apache/libcloud/pull/1511#issuecomment-714479333


   This looks good to me, if the preference is to leave a deprecated Packet driver in place, the old Packet drivers could take on the new API endpoints and continue working until the deprecation deadline is met.  There would be a minor change in the API results because the `href` values have changed.
   
   I see more "Packet" references leftover in the code and documentation (`git grep -n -i packet`), there are also more "packet.net", "packet.com", "packethost.net", and "net.packet" references.  It's a tricky rename because TCP "packet" appears in several locations of the code.
   
   The image `docs/_static/images/provider_logos/packet.png` should be updated to an Equinix Metal name and logo (`find . -name \*packet\*`).
   
   Also, `libcloud/test/compute/test_equinixmetal.py` has two incorrect email address in the comment block.  The maintainer should be updated and the credit to jed@packet.com (@jedsmith) should be jed@linode.com (which isn't a current email address either).  This portion of the comment block can probably be removed.
   
    


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [libcloud] Kami commented on pull request #1511: Packet rebranding to Equinix Metal

Posted by GitBox <gi...@apache.org>.
Kami commented on pull request #1511:
URL: https://github.com/apache/libcloud/pull/1511#issuecomment-739508608


   Thanks for the contribution - this has now been merged into trunk.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [libcloud] jedsmith commented on pull request #1511: Packet rebranding to Equinix Metal

Posted by GitBox <gi...@apache.org>.
jedsmith commented on pull request #1511:
URL: https://github.com/apache/libcloud/pull/1511#issuecomment-714618632


   Looks like someone copied over Linode code and did a `sed` to replace `linode` with `packet`, to explain the incorrect e-mail address for me. I've never been employed by Packet, and I'm relatively annoyed to have made this discovery this morning.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org