You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2021/10/22 06:22:21 UTC
[GitHub] [incubator-eventmesh] Alonexc opened a new pull request #566: Update JarExtensionClassLoader.java
Alonexc opened a new pull request #566:
URL: https://github.com/apache/incubator-eventmesh/pull/566
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes ISSUE#<XXX>`.)
-->
Fixes ISSUE#<#565>.
### Motivation
- Fix the problem that the plugin could not be loaded when standalone was changed to rocketmq.
### Modifications
- Update JarExtensionClassLoader.java
### Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov-commenter edited a comment on pull request #566: Update JarExtensionClassLoader.java
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #566:
URL: https://github.com/apache/incubator-eventmesh/pull/566#issuecomment-949339567
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/566?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#566](https://codecov.io/gh/apache/incubator-eventmesh/pull/566?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fbb2345) into [develop](https://codecov.io/gh/apache/incubator-eventmesh/commit/dd3385f1431126c5c8babef01e5e958b86f644af?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dd3385f) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-eventmesh/pull/566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #566 +/- ##
=============================================
- Coverage 11.00% 10.98% -0.02%
Complexity 391 391
=============================================
Files 263 263
Lines 12490 12488 -2
Branches 1046 1046
=============================================
- Hits 1374 1372 -2
Misses 10998 10998
Partials 118 118
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../eventmesh/spi/loader/JarExtensionClassLoader.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXNwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL3NwaS9sb2FkZXIvSmFyRXh0ZW5zaW9uQ2xhc3NMb2FkZXIuamF2YQ==) | `9.83% <0.00%> (-2.87%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/566?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/566?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dd3385f...fbb2345](https://codecov.io/gh/apache/incubator-eventmesh/pull/566?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun commented on pull request #566: Update JarExtensionClassLoader.java
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on pull request #566:
URL: https://github.com/apache/incubator-eventmesh/pull/566#issuecomment-949498465
BTW, please change the title to `[ISSUE #565] Update JarExtensionClassLoader.java` this can help to relate this pr to issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov-commenter edited a comment on pull request #566: [ISSUE #565] Update JarExtensionClassLoader.java
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #566:
URL: https://github.com/apache/incubator-eventmesh/pull/566#issuecomment-949339567
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/566?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#566](https://codecov.io/gh/apache/incubator-eventmesh/pull/566?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (edbf62d) into [develop](https://codecov.io/gh/apache/incubator-eventmesh/commit/dd3385f1431126c5c8babef01e5e958b86f644af?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dd3385f) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-eventmesh/pull/566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #566 +/- ##
=============================================
- Coverage 11.00% 10.98% -0.02%
Complexity 391 391
=============================================
Files 263 263
Lines 12490 12488 -2
Branches 1046 1046
=============================================
- Hits 1374 1372 -2
Misses 10998 10998
Partials 118 118
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../eventmesh/spi/loader/JarExtensionClassLoader.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXNwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL3NwaS9sb2FkZXIvSmFyRXh0ZW5zaW9uQ2xhc3NMb2FkZXIuamF2YQ==) | `9.83% <0.00%> (-2.87%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/566?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/566?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dd3385f...edbf62d](https://codecov.io/gh/apache/incubator-eventmesh/pull/566?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov-commenter commented on pull request #566: Update JarExtensionClassLoader.java
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #566:
URL: https://github.com/apache/incubator-eventmesh/pull/566#issuecomment-949339567
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/566?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#566](https://codecov.io/gh/apache/incubator-eventmesh/pull/566?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b9ee05d) into [develop](https://codecov.io/gh/apache/incubator-eventmesh/commit/dd3385f1431126c5c8babef01e5e958b86f644af?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dd3385f) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-eventmesh/pull/566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #566 +/- ##
=============================================
- Coverage 11.00% 10.98% -0.02%
Complexity 391 391
=============================================
Files 263 263
Lines 12490 12488 -2
Branches 1046 1046
=============================================
- Hits 1374 1372 -2
Misses 10998 10998
Partials 118 118
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../eventmesh/spi/loader/JarExtensionClassLoader.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXNwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL3NwaS9sb2FkZXIvSmFyRXh0ZW5zaW9uQ2xhc3NMb2FkZXIuamF2YQ==) | `9.83% <0.00%> (-2.87%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/566?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/566?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dd3385f...b9ee05d](https://codecov.io/gh/apache/incubator-eventmesh/pull/566?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun commented on a change in pull request #566: Update JarExtensionClassLoader.java
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on a change in pull request #566:
URL: https://github.com/apache/incubator-eventmesh/pull/566#discussion_r734424395
##########
File path: eventmesh-spi/src/main/java/org/apache/eventmesh/spi/loader/JarExtensionClassLoader.java
##########
@@ -56,8 +56,8 @@
Joiner.on(File.separator).join(Lists.newArrayList(".", "plugin")));
// META-INF/eventmesh
- private static final String EVENTMESH_EXTENSION_META_DIR =
- Paths.get("META-INF", "eventmesh").toString();
+ private static final String EVENTMESH_EXTENSION_META_DIR = "META-INF/eventmesh/";
+ // Paths.get("META-INF", "eventmesh").toString();
Review comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] Alonexc commented on pull request #566: [ISSUE #565] Update JarExtensionClassLoader.java
Posted by GitBox <gi...@apache.org>.
Alonexc commented on pull request #566:
URL: https://github.com/apache/incubator-eventmesh/pull/566#issuecomment-950478102
@ruanwenjun I have modified it according to your suggestion. Thank you for your suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] Alonexc commented on pull request #566: Update JarExtensionClassLoader.java
Posted by GitBox <gi...@apache.org>.
Alonexc commented on pull request #566:
URL: https://github.com/apache/incubator-eventmesh/pull/566#issuecomment-950470061
@qqeasonchen OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen commented on pull request #566: Update JarExtensionClassLoader.java
Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on pull request #566:
URL: https://github.com/apache/incubator-eventmesh/pull/566#issuecomment-950250963
@Alonexc please see the comments and update it, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] Alonexc commented on a change in pull request #566: Update JarExtensionClassLoader.java
Posted by GitBox <gi...@apache.org>.
Alonexc commented on a change in pull request #566:
URL: https://github.com/apache/incubator-eventmesh/pull/566#discussion_r735217504
##########
File path: eventmesh-spi/src/main/java/org/apache/eventmesh/spi/loader/JarExtensionClassLoader.java
##########
@@ -56,8 +56,8 @@
Joiner.on(File.separator).join(Lists.newArrayList(".", "plugin")));
// META-INF/eventmesh
- private static final String EVENTMESH_EXTENSION_META_DIR =
- Paths.get("META-INF", "eventmesh").toString();
+ private static final String EVENTMESH_EXTENSION_META_DIR = "META-INF/eventmesh/";
+ // Paths.get("META-INF", "eventmesh").toString();
Review comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 merged pull request #566: [ISSUE #565] Update JarExtensionClassLoader.java
Posted by GitBox <gi...@apache.org>.
xwm1992 merged pull request #566:
URL: https://github.com/apache/incubator-eventmesh/pull/566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org