You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "Pengzna (via GitHub)" <gi...@apache.org> on 2025/05/22 09:33:42 UTC

[PR] IoTV2: Make consensus event retry forever. [iotdb]

Pengzna opened a new pull request, #15565:
URL: https://github.com/apache/iotdb/pull/15565

   as title.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IoTV2: Make consensus event retry forever. [iotdb]

Posted by "Caideyipi (via GitHub)" <gi...@apache.org>.
Caideyipi commented on code in PR #15565:
URL: https://github.com/apache/iotdb/pull/15565#discussion_r2102117910


##########
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/agent/task/subtask/PipeReportableSubtask.java:
##########
@@ -56,6 +56,20 @@ public synchronized void onFailure(final Throwable throwable) {
     // is dropped or the process is running normally.
   }
 
+  private long getSleepIntervalBasedOnThrowable(final Throwable throwable) {
+    long sleepInterval = Math.min(1000L * retryCount.get(), 10000);
+    // if receiver is read-only/internal-error/write-reject, connector will retry will

Review Comment:
   retry with
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IoTV2: Make consensus event retry forever. [iotdb]

Posted by "Pengzna (via GitHub)" <gi...@apache.org>.
Pengzna commented on code in PR #15565:
URL: https://github.com/apache/iotdb/pull/15565#discussion_r2102671171


##########
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/agent/task/subtask/PipeReportableSubtask.java:
##########
@@ -56,6 +56,20 @@ public synchronized void onFailure(final Throwable throwable) {
     // is dropped or the process is running normally.
   }
 
+  private long getSleepIntervalBasedOnThrowable(final Throwable throwable) {
+    long sleepInterval = Math.min(1000L * retryCount.get(), 10000);
+    // if receiver is read-only/internal-error/write-reject, connector will retry will

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IoTV2: Make consensus event retry forever. [iotdb]

Posted by "SteveYurongSu (via GitHub)" <gi...@apache.org>.
SteveYurongSu merged PR #15565:
URL: https://github.com/apache/iotdb/pull/15565


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org