You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/28 00:40:17 UTC
[GitHub] [beam] y1chi opened a new pull request #11545: Update BigQuery source in bigquery_tornadoes example
y1chi opened a new pull request #11545:
URL: https://github.com/apache/beam/pull/11545
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #11545: Update BigQuery source in bigquery_tornadoes example
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #11545:
URL: https://github.com/apache/beam/pull/11545#issuecomment-620815458
Adding project auto-inference here; https://github.com/apache/beam/pull/11560
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #11545: Update BigQuery source in bigquery_tornadoes example
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #11545:
URL: https://github.com/apache/beam/pull/11545#issuecomment-620752846
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] y1chi commented on pull request #11545: Update BigQuery source in bigquery_tornadoes example
Posted by GitBox <gi...@apache.org>.
y1chi commented on pull request #11545:
URL: https://github.com/apache/beam/pull/11545#issuecomment-620973239
Should I remove the project option and use project auto-inference?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #11545: Update BigQuery source in bigquery_tornadoes example
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #11545:
URL: https://github.com/apache/beam/pull/11545#issuecomment-620745721
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] y1chi commented on pull request #11545: Update BigQuery source in bigquery_tornadoes example
Posted by GitBox <gi...@apache.org>.
y1chi commented on pull request #11545:
URL: https://github.com/apache/beam/pull/11545#issuecomment-620309409
R: @pabloem
Please also try PostCommit test :).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] y1chi commented on pull request #11545: Update BigQuery source in bigquery_tornadoes example
Posted by GitBox <gi...@apache.org>.
y1chi commented on pull request #11545:
URL: https://github.com/apache/beam/pull/11545#issuecomment-621350872
> Agh it's looking like it's a more complicated problem. I'm working on project inference, and I'll add ReadFromBQ to tornadoes in that PR. Is that reasonable Yichi? So sorry about the trouble...
> […](#)
> On Tue, Apr 28, 2020 at 8:41 PM Yichi Zhang ***@***.***> wrote: Should I remove the project option and use project auto-inference? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <[#11545 (comment)](https://github.com/apache/beam/pull/11545#issuecomment-620973239)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJ5Z3BUOU3BLLVK3WFZJUDRO6OVBANCNFSM4MSMFGLA> .
SGTM, thanks for the help Pablo:)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #11545: Update BigQuery source in bigquery_tornadoes example
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #11545:
URL: https://github.com/apache/beam/pull/11545#issuecomment-620764314
Run Python 3.5 PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #11545: Update BigQuery source in bigquery_tornadoes example
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #11545:
URL: https://github.com/apache/beam/pull/11545#issuecomment-620981601
Agh it's looking like it's a more complicated problem. I'm working on
project inference, and I'll add ReadFromBQ to tornadoes in that PR. Is that
reasonable Yichi? So sorry about the trouble...
On Tue, Apr 28, 2020 at 8:41 PM Yichi Zhang <no...@github.com>
wrote:
> Should I remove the project option and use project auto-inference?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/beam/pull/11545#issuecomment-620973239>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAJ5Z3BUOU3BLLVK3WFZJUDRO6OVBANCNFSM4MSMFGLA>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #11545: Update BigQuery source in bigquery_tornadoes example
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #11545:
URL: https://github.com/apache/beam/pull/11545#issuecomment-620313276
Run Python 3.5 PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #11545: Update BigQuery source in bigquery_tornadoes example
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #11545:
URL: https://github.com/apache/beam/pull/11545#issuecomment-620312322
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #11545: Update BigQuery source in bigquery_tornadoes example
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #11545:
URL: https://github.com/apache/beam/pull/11545#issuecomment-620825306
Run Python 3.5 PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #11545: Update BigQuery source in bigquery_tornadoes example
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #11545:
URL: https://github.com/apache/beam/pull/11545#issuecomment-620327216
Run Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #11545: Update BigQuery source in bigquery_tornadoes example
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #11545:
URL: https://github.com/apache/beam/pull/11545#issuecomment-620763591
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org