You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2026/02/24 20:05:37 UTC

[PR] HDDS-14708. Move server code out of ozone-common [ozone]

adoroszlai opened a new pull request, #9821:
URL: https://github.com/apache/ozone/pull/9821

   ## What changes were proposed in this pull request?
   
   - Classes in `org.apache.hadoop.ozone.om.lock` are not for clients, so should be moved to `ozone-interface-storage` (where `OMMetadataManager` uses some of them).
   - Classes `org.apache.hadoop.ozone.om.S3Secret*` are used only in `ozone-manager`, move to that module.
   - Adjust dependencies accordingly.
   
   https://issues.apache.org/jira/browse/HDDS-14708
   
   ## How was this patch tested?
   
   https://github.com/adoroszlai/ozone/actions/runs/22364980180


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-14708. Move server code out of ozone-common [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #9821:
URL: https://github.com/apache/ozone/pull/9821#issuecomment-3988888508

   @sadanand48 please take a look


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-14708. Move server code out of ozone-common [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #9821:
URL: https://github.com/apache/ozone/pull/9821#issuecomment-4016706028

   Thanks @ivandika3, @sodonnel for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-14708. Move server code out of ozone-common [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #9821:
URL: https://github.com/apache/ozone/pull/9821


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-14708. Move server code out of ozone-common [ozone]

Posted by "sodonnel (via GitHub)" <gi...@apache.org>.
sodonnel commented on PR #9821:
URL: https://github.com/apache/ozone/pull/9821#issuecomment-4011149149

   There is no logic change here, so I am fine with it. I just worry about these reorganizations from a backport perspective, as it can make them more difficult. That said, we cannot prevent any code improvements just to make backports easier.
   
   +1 from me for the change with the above in mind.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-14708. Move server code out of ozone-common [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #9821:
URL: https://github.com/apache/ozone/pull/9821#issuecomment-4012716677

   > In this case, should we simply move them to the ozone-manager module instead?
   
   `OMMetadataManager`, defined in `interface-storage`, uses some of the lock interfaces, which in turn use other types from the `....om.lock` package.  Moved the rest to `ozone-manager`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org