You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "insomnes (via GitHub)" <gi...@apache.org> on 2025/01/09 15:26:56 UTC
[I] KubernetesExecutor shadowing timeout_seconds and _request_seconds [airflow]
insomnes opened a new issue, #45517:
URL: https://github.com/apache/airflow/issues/45517
### Apache Airflow Provider(s)
cncf-kubernetes
### Versions of Apache Airflow Providers
apache-airflow-providers-cncf-kubernetes==10.0.1
### Apache Airflow version
2.10.4
### Operating System
Debian Bookworm
### Deployment
Other
### Deployment details
It's deployment independent and related to code directly
### What happened
kube client query options of `timeout_seconds` and `_request_seconds` provided via `kube_client_request_args` config option are re-written via hardcoded values in executor code.
### What you think should happen instead
Values set via `AIRFLOW__KUBERNETES_EXECUTOR__KUBE_CLIENT_REQUEST_ARGS` for `timeout_seconds` and `_request_seconds` should be respected, hardcoded values should be provided only in case of missing keys in the provided JSON.
Simple if for checking if key is already present would be enough
### How to reproduce
1. Set the [kube_client_request_args](https://airflow.apache.org/docs/apache-airflow-providers-cncf-kubernetes/stable/configurations-ref.html#kube-client-request-args) option with JSON: `{"timeout_seconds": 1800, "_request_timeout": 60}`
2. Run airflow scheduler with kubernetes executor configured
3. In logs you can see that without pod events the watcher will still die every 30 seconds instead of 60.
### Anything else
The problem was introduced with:
https://github.com/apache/airflow/commit/610747d25a6153574c07624afaadcbf575aa2960#diff-d884d637ab746b1301ce80b30ba2c1908299ba6f13edcad6535c837fb4d30938R151
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] KubernetesExecutor shadowing timeout_seconds and _request_seconds [airflow]
Posted by "RNHTTR (via GitHub)" <gi...@apache.org>.
RNHTTR commented on issue #45517:
URL: https://github.com/apache/airflow/issues/45517#issuecomment-2580798313
Cool -- assigned you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] KubernetesExecutor shadowing timeout_seconds and _request_seconds [airflow]
Posted by "insomnes (via GitHub)" <gi...@apache.org>.
insomnes commented on issue #45517:
URL: https://github.com/apache/airflow/issues/45517#issuecomment-2580586649
I am happy to provide the PR fixing it.
I see this behavior as a 100% bug. But I want to be sure it's not intended in any way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] KubernetesExecutor shadowing timeout_seconds and _request_seconds [airflow]
Posted by "insomnes (via GitHub)" <gi...@apache.org>.
insomnes commented on issue #45517:
URL: https://github.com/apache/airflow/issues/45517#issuecomment-2580722237
Yes. I was thinking about checking the presence of these keys:
```python
if "_request_timeout" not in kwargs:
client_timeout = 30
kwargs["_request_timeout"] = client_timeout
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] KubernetesExecutor shadowing timeout_seconds and _request_seconds [airflow]
Posted by "RNHTTR (via GitHub)" <gi...@apache.org>.
RNHTTR commented on issue #45517:
URL: https://github.com/apache/airflow/issues/45517#issuecomment-2580704350
Is the idea to update these lines to default to 30/3600 but allow them to be overwritten via kube_client_request_args? If so, I think that makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] KubernetesExecutor shadowing timeout_seconds and _request_seconds [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed issue #45517: KubernetesExecutor shadowing timeout_seconds and _request_seconds
URL: https://github.com/apache/airflow/issues/45517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] KubernetesExecutor shadowing timeout_seconds and _request_seconds [airflow]
Posted by "Mizokuiam (via GitHub)" <gi...@apache.org>.
Mizokuiam commented on issue #45517:
URL: https://github.com/apache/airflow/issues/45517#issuecomment-2581033839
Thank you for raising this issue! I'll look into it and try to help if I can.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org