[GitHub] [beam] aromanenko-dev commented on a diff in pull request #25216: Test Avro extension against multiple Avro versions

["aromanenko-dev (via GitHub)" <gi...@apache.org>]

aromanenko-dev commented on code in PR #25216:
URL: https://github.com/apache/beam/pull/25216#discussion_r1158475435


##########
sdks/java/extensions/avro/src/test/avro192/org/apache/beam/sdk/extensions/avro/schemas/TestAvroFactory.java:
##########
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.extensions.avro.schemas;
+
+/**
+ * Create a {@link TestAvro} with some default values.
+ */
+public class TestAvroFactory extends AbstractTestAvroFactory {
+  private static final TestAvroNested AVRO_NESTED_SPECIFIC_RECORD = new TestAvroNested(true, 42);
+
+  public static TestAvro newInstanceForAvroCoderTest() throws ReflectiveOperationException {

Review Comment:
   Finally, I implemented all required logic to create a right class instance depending on Avro version in a one dedicated factory class with one method. Empty map logic is handled inside the test that was failing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org