You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Gautam Borad <gb...@gmail.com> on 2015/10/19 08:02:49 UTC
Review Request 39431: RANGER-701 : Update setup scripts to allow
special characters in passwords
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39431/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-701
https://issues.apache.org/jira/browse/RANGER-701
Repository: ranger
Description
-------
Attached patch has changes in setup scripts to allow all special characters for passwords except escape characters: \ ` ' "
Diffs
-----
kms/scripts/db_setup.py 5e2f9506a990af9f91d8627b033cd8470e58967e
kms/scripts/dba_script.py 950b8c3603165c11084bb2b1f6ce5d7b3f8ec859
kms/scripts/setup.sh 96bf6a0d4da9679d054f823b2d4e2c3de00b33a4
security-admin/scripts/db_setup.py 1edc628d96d926309b720eb93eb44ee650fd1e46
security-admin/scripts/dba_script.py 4fd5593894175fdd2977b9c812cc293ca3d8cad3
security-admin/scripts/set_globals.sh 9a4159ca8e3fabea79f206b6a6d4081ed08105fe
security-admin/scripts/setup.sh cd5d2bfa8a875e3ec5597a2e78abf2cda6376d01
security-admin/src/main/java/org/apache/ranger/common/RESTErrorUtil.java c46964c2d8940d9056dc9caed00fd67487376903
security-admin/src/main/java/org/apache/ranger/service/AbstractBaseResourceService.java 0ddfb0ed0f60c4221e06802640184fcbf10d4d67
security-admin/src/main/webapp/scripts/views/permissions/ModulePermissionCreate.js 7981d34c3c184a70e0289b46ccfd41b8d0554fa7
security-admin/src/main/webapp/scripts/views/users/GroupCreate.js 40e68374187fa7136fc296596cee9bb0eaccea04
security-admin/src/main/webapp/scripts/views/users/UserCreate.js a37fd8876170f1aae7cc749c5ad46301a5cec9d9
unixauthservice/scripts/set_globals.sh c92dfdcff79cb0401a25424be1107fa169447dff
unixauthservice/scripts/setup.py 31c486eecb4a768f4b14395cb28d953c2a8d943c
Diff: https://reviews.apache.org/r/39431/diff/
Testing
-------
Tested Ranger/ Usersync/ KMS installation using Mysql, Oracle, Postgres, MS SQL, SQLAnywhere, Azure DB by using various combinations of special characters.
Mentioned password combinations were also tested on Bind Password field for AD/LDAP Sync/Authentication.
Thanks,
Gautam Borad
Re: Review Request 39431: RANGER-701 : Update setup scripts to allow
special characters in passwords
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39431/
-----------------------------------------------------------
(Updated Oct. 19, 2015, 11:11 a.m.)
Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Changes
-------
minor change in setup.py
Bugs: RANGER-701
https://issues.apache.org/jira/browse/RANGER-701
Repository: ranger
Description
-------
Attached patch has changes in setup scripts to allow all special characters for passwords except escape characters: \ ` ' "
Diffs (updated)
-----
kms/scripts/db_setup.py 5e2f9506a990af9f91d8627b033cd8470e58967e
kms/scripts/dba_script.py 950b8c3603165c11084bb2b1f6ce5d7b3f8ec859
kms/scripts/setup.sh 96bf6a0d4da9679d054f823b2d4e2c3de00b33a4
security-admin/scripts/db_setup.py 1edc628d96d926309b720eb93eb44ee650fd1e46
security-admin/scripts/dba_script.py 4fd5593894175fdd2977b9c812cc293ca3d8cad3
security-admin/scripts/set_globals.sh 9a4159ca8e3fabea79f206b6a6d4081ed08105fe
security-admin/scripts/setup.sh cd5d2bfa8a875e3ec5597a2e78abf2cda6376d01
security-admin/src/main/java/org/apache/ranger/common/RESTErrorUtil.java c46964c2d8940d9056dc9caed00fd67487376903
security-admin/src/main/java/org/apache/ranger/service/AbstractBaseResourceService.java 0ddfb0ed0f60c4221e06802640184fcbf10d4d67
security-admin/src/main/webapp/scripts/views/permissions/ModulePermissionCreate.js 7981d34c3c184a70e0289b46ccfd41b8d0554fa7
security-admin/src/main/webapp/scripts/views/users/GroupCreate.js 40e68374187fa7136fc296596cee9bb0eaccea04
security-admin/src/main/webapp/scripts/views/users/UserCreate.js a37fd8876170f1aae7cc749c5ad46301a5cec9d9
unixauthservice/scripts/set_globals.sh c92dfdcff79cb0401a25424be1107fa169447dff
unixauthservice/scripts/setup.py 31c486eecb4a768f4b14395cb28d953c2a8d943c
Diff: https://reviews.apache.org/r/39431/diff/
Testing
-------
Tested Ranger/ Usersync/ KMS installation using Mysql, Oracle, Postgres, MS SQL, SQLAnywhere, Azure DB by using various combinations of special characters.
Mentioned password combinations were also tested on Bind Password field for AD/LDAP Sync/Authentication.
Thanks,
Gautam Borad