[GitHub] [iceberg] jackye1995 commented on pull request #3668: AWS: Make the error message of GlueCatalog's isValidIdentifier more detailed

[GitBox <gi...@apache.org>]

jackye1995 commented on pull request #3668:
URL: https://github.com/apache/iceberg/pull/3668#issuecomment-995283213


   I am a bit hesitated with this change. It changes exception type from `IllegalArgumentException` to `ValidationException`, which will break any system that catches the specific exception type.
   
   I also talked in #3698 , which I will quote here:
   
   > I think that is already tested in `testCreateNamespaceBadName` and `testToDatabaseNameFailure`...But I agree the current `TestGlueCatalog` lacks a lot of features. I am thinking about implementing a proper local Glue client to test the code in unit test properly, let me know if you would like to pick up the task.
   
   I think that is the right way to go about this whole situation, comparing to checking the exact error message.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org