[GitHub] [incubator-pinot] snleee commented on a change in pull request #4858: Introduce the base JSON config class and clean up the config classes

[GitBox <gi...@apache.org>]

snleee commented on a change in pull request #4858: Introduce the base JSON config class and clean up the config classes
URL: https://github.com/apache/incubator-pinot/pull/4858#discussion_r350992144
 
 

 ##########
 File path: pinot-common/src/main/java/org/apache/pinot/common/config/ReplicaGroupStrategyConfig.java
 ##########
 @@ -18,48 +18,27 @@
  */
 package org.apache.pinot.common.config;
 
-import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
+import com.fasterxml.jackson.annotation.JsonCreator;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.google.common.base.Preconditions;
 import javax.annotation.Nullable;
-import org.apache.pinot.common.utils.EqualityUtils;
 
 
 /**
  * Class representing configurations related to segment assignment strategy.
- *
  */
-@JsonIgnoreProperties(ignoreUnknown = true)
-public class ReplicaGroupStrategyConfig {
-  private String _partitionColumn;
-  private int _numInstancesPerPartition;
-  private boolean _mirrorAssignmentAcrossReplicaGroups;
-
-  /**
-   * Returns the number of instances that segments for a partition span.
-   *
-   * @return Number of instances used for a partition.
-   */
-  public int getNumInstancesPerPartition() {
-    return _numInstancesPerPartition;
-  }
-
-  public void setNumInstancesPerPartition(int numInstancesPerPartition) {
+public class ReplicaGroupStrategyConfig extends BaseJsonConfig {
 
 Review comment:
   Are we deleting `mirrorAssignmentAcrossReplicaGroups`?
   Previously, we used to use it for rebalance. The new rebalancer code doesn't use `mirror` config at all?
   
   In that case, we should do one time clean up for tables configs for all tables after deploying this code. Also, nuage has replica group config field so we need to clean it up as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org