[GitHub] [pinot] andimiller commented on a diff in pull request #10982: Allow extra aggregation types in RealtimeToOfflineSegmentsTask

["andimiller (via GitHub)" <gi...@apache.org>]

andimiller commented on code in PR #10982:
URL: https://github.com/apache/pinot/pull/10982#discussion_r1248857733


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##########
@@ -42,6 +42,7 @@
 import org.apache.pinot.common.request.context.RequestContextUtils;
 import org.apache.pinot.common.tier.TierFactory;
 import org.apache.pinot.common.utils.config.TagNameUtils;
+import org.apache.pinot.segment.local.aggregator.ValueAggregatorFactory;

Review Comment:
   > We should be able to use `ValueAggregatorFactory.getValueAggregator()`. `dataType` can be read from the schema
   
   that one is in `pinot-core`, which isn't available in `pinot-segment-local`, I could add the dependency but that seemed like a big change



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org