[GitHub] [arrow-datafusion] liukun4515 commented on a diff in pull request #4741: revert some code for #4726

[GitBox <gi...@apache.org>]

liukun4515 commented on code in PR #4741:
URL: https://github.com/apache/arrow-datafusion/pull/4741#discussion_r1057666532


##########
datafusion/expr/src/type_coercion/binary.rs:
##########
@@ -575,6 +575,7 @@ fn temporal_coercion(lhs_type: &DataType, rhs_type: &DataType) -> Option<DataTyp
         },
         (Timestamp(_, tz), Utf8) => Some(Timestamp(TimeUnit::Nanosecond, tz.clone())),
         (Utf8, Timestamp(_, tz)) => Some(Timestamp(TimeUnit::Nanosecond, tz.clone())),
+        // TODO: need to investigate the result type for the comparison between timestamp and date

Review Comment:
   https://github.com/apache/arrow-datafusion/issues/4644#issuecomment-1365869161
   we need to get the behavior for the comparison in the PG.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org