You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Abhishek Rawat (Code Review)" <ge...@cloudera.org> on 2023/04/08 08:00:42 UTC
[Impala-ASF-CR] IMPALA-12039: graceful shutdown doesn't work in redhat docker image
Abhishek Rawat has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19711
Change subject: IMPALA-12039: graceful shutdown doesn't work in redhat docker image
......................................................................
IMPALA-12039: graceful shutdown doesn't work in redhat docker image
'pgrep' was missing in redhat docker image and as a result graceful
shutdown script (bin/graceful_shutdown_backends.sh) was terminating
the impalad immediately without waiting for the
'shutdown_grace_period_s' grace period. Since, there wasn't enough
time window for cluster membership changes to propagate to
coordinator, it was scheduling query fragments on already deleted
executors and queries were failing.
Built an ubuntu 20 image and it had the 'pgrep' utility already
installed.
Testing:
- Built redhat 8 image and manually tested graceful shutdown in a
docker container.
Change-Id: I91ffc1fe3e022ce7f7507b2bd79a3e2c3851956d
---
M docker/install_os_packages.sh
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/19711/1
--
To view, visit http://gerrit.cloudera.org:8080/19711
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I91ffc1fe3e022ce7f7507b2bd79a3e2c3851956d
Gerrit-Change-Number: 19711
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-12039: graceful shutdown doesn't work in redhat docker image
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19711 )
Change subject: IMPALA-12039: graceful shutdown doesn't work in redhat docker image
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12763/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19711
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91ffc1fe3e022ce7f7507b2bd79a3e2c3851956d
Gerrit-Change-Number: 19711
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Sat, 08 Apr 2023 08:21:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12039: graceful shutdown doesn't work in redhat docker image
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19711 )
Change subject: IMPALA-12039: graceful shutdown doesn't work in redhat docker image
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19711
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91ffc1fe3e022ce7f7507b2bd79a3e2c3851956d
Gerrit-Change-Number: 19711
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Sun, 09 Apr 2023 16:27:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12039: graceful shutdown doesn't work in redhat docker image
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19711 )
Change subject: IMPALA-12039: graceful shutdown doesn't work in redhat docker image
......................................................................
Patch Set 1: Code-Review+2
LGTM
--
To view, visit http://gerrit.cloudera.org:8080/19711
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91ffc1fe3e022ce7f7507b2bd79a3e2c3851956d
Gerrit-Change-Number: 19711
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Sat, 08 Apr 2023 16:43:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12039: graceful shutdown doesn't work in redhat docker image
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19711 )
Change subject: IMPALA-12039: graceful shutdown doesn't work in redhat docker image
......................................................................
IMPALA-12039: graceful shutdown doesn't work in redhat docker image
'pgrep' was missing in redhat docker image and as a result graceful
shutdown script (bin/graceful_shutdown_backends.sh) was terminating
the impalad immediately without waiting for the
'shutdown_grace_period_s' grace period. Since, there wasn't enough
time window for cluster membership changes to propagate to
coordinator, it was scheduling query fragments on already deleted
executors and queries were failing.
Built an ubuntu 20 image and it had the 'pgrep' utility already
installed.
Testing:
- Built redhat 8 image and manually tested graceful shutdown in a
docker container.
Change-Id: I91ffc1fe3e022ce7f7507b2bd79a3e2c3851956d
Reviewed-on: http://gerrit.cloudera.org:8080/19711
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docker/install_os_packages.sh
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/19711
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I91ffc1fe3e022ce7f7507b2bd79a3e2c3851956d
Gerrit-Change-Number: 19711
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-12039: graceful shutdown doesn't work in redhat docker image
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19711 )
Change subject: IMPALA-12039: graceful shutdown doesn't work in redhat docker image
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19711
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91ffc1fe3e022ce7f7507b2bd79a3e2c3851956d
Gerrit-Change-Number: 19711
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Sun, 09 Apr 2023 21:42:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12039: graceful shutdown doesn't work in redhat docker image
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19711 )
Change subject: IMPALA-12039: graceful shutdown doesn't work in redhat docker image
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9212/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/19711
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91ffc1fe3e022ce7f7507b2bd79a3e2c3851956d
Gerrit-Change-Number: 19711
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Sun, 09 Apr 2023 16:27:00 +0000
Gerrit-HasComments: No