You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2017/12/12 21:03:26 UTC

[GitHub] pracheer commented on a change in pull request #9027: Usability improvement for cnn_chinese_text_classification

pracheer commented on a change in pull request #9027: Usability improvement for cnn_chinese_text_classification
URL: https://github.com/apache/incubator-mxnet/pull/9027#discussion_r156494304
 
 

 ##########
 File path: example/cnn_chinese_text_classification/text_cnn.py
 ##########
 @@ -20,20 +20,19 @@
 
 # -*- coding: utf-8 -*-
 
-import sys
-import os
+import sys, os
 import mxnet as mx
 import numpy as np
 import argparse
 import logging
-
 import time
 
 from mxnet import random
 from mxnet.initializer import Xavier, Initializer
 
 import data_helpers
 
+print("Training logs are generated in ./cnn_text_classification.log")
 
 Review comment:
   nitpick: There is only one log file. Isn't it? If yes, then this may be more appropriate "Training log is generated at ./cnn_text_classification.log" or "Training log can be found at cnn_text_classification.log"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services